Bind directly to VM, removes last of the leaked bindings.

Author: comintern

Rubberduck.Core/UI/Inspections/InspectionResultsControl.xaml

@@ -235,12 +235,12 @@
                         <ColumnDefinition />
                     </Grid.ColumnDefinitions>
                     <Image Style="{StaticResource IconMargin}" VerticalAlignment="Top" Grid.Column="0"
-                           Source="{Binding SelectedItem.Inspection.Severity, Converter={StaticResource SeverityIconConverter}}"/>
-                    <TextBlock Grid.Column="1" Margin="4" Text="{Binding SelectedItem.Inspection.Description}" FontWeight="Bold" TextWrapping="WrapWithOverflow"/>
+                           Source="{Binding SelectedSeverity, Converter={StaticResource SeverityIconConverter}}"/>
+                    <TextBlock Grid.Column="1" Margin="4" Text="{Binding SelectedDescription}" FontWeight="Bold" TextWrapping="WrapWithOverflow"/>
                 </Grid>
 
-                <TextBlock Margin="4" Text="{Binding SelectedItem.Inspection.Meta}" FontSize="10" TextWrapping="WrapWithOverflow"/>
-                <TextBlock Margin="8" Text="{Binding SelectedItem.QualifiedSelection}" FontSize="10" TextWrapping="WrapWithOverflow" />
+                <TextBlock Margin="4" Text="{Binding SelectedMeta}" FontSize="10" TextWrapping="WrapWithOverflow"/>
+                <TextBlock Margin="8" Text="{Binding SelectedSelection}" FontSize="10" TextWrapping="WrapWithOverflow" />
 
                 <WrapPanel>
                     <controls:LinkButton Margin="4"

Rubberduck.Core/UI/Inspections/InspectionResultsViewModel.cs

@@ -18,6 +18,7 @@
 using Rubberduck.UI.Command;
 using Rubberduck.UI.Controls;
 using Rubberduck.UI.Settings;
+using Rubberduck.VBEditor;
 
 namespace Rubberduck.UI.Inspections
 {
@@ -140,6 +141,9 @@ public INavigateSource SelectedItem
                 _selectedItem = value; 
                 OnPropertyChanged();
                 OnPropertyChanged(nameof(QuickFixes));
+                OnPropertyChanged(nameof(SelectedDescription));
+                OnPropertyChanged(nameof(SelectedMeta));
+                OnPropertyChanged(nameof(SelectedSeverity));
 
                 SelectedInspection = null;
                 CanQuickFix = false;
@@ -150,6 +154,8 @@ public INavigateSource SelectedItem
                 if (_selectedItem is IInspectionResult inspectionResult)
                 {
                     SelectedInspection = inspectionResult.Inspection;
+                    SelectedSelection = inspectionResult.QualifiedSelection;
+                    
                     CanQuickFix = _quickFixProvider.HasQuickFixes(inspectionResult);
                     _defaultFix = _quickFixProvider.QuickFixes(inspectionResult).FirstOrDefault();
                     CanExecuteQuickFixInProcedure = _defaultFix != null && _defaultFix.CanFixInProcedure;
@@ -170,9 +176,18 @@ public IInspection SelectedInspection
             {
                 _selectedInspection = value;
                 OnPropertyChanged();
+                OnPropertyChanged(nameof(SelectedSelection));
             }
         }
 
+        public string SelectedDescription => SelectedInspection?.Description ?? string.Empty;
+
+        public string SelectedMeta => SelectedInspection?.Meta ?? string.Empty;
+
+        public CodeInspectionSeverity SelectedSeverity => SelectedInspection?.Severity ?? CodeInspectionSeverity.DoNotShow;
+
+        public QualifiedSelection SelectedSelection { get; private set; }
+
         public IEnumerable<DisplayQuickFix> QuickFixes
         {
             get

Rubberduck.Core/UI/Inspections/InspectionSeverityImageSourceConverter.cs

@@ -17,6 +17,7 @@ public class InspectionSeverityImageSourceConverter : IValueConverter
         private static readonly IDictionary<CodeInspectionSeverity,ImageSource> Icons = 
             new Dictionary<CodeInspectionSeverity, ImageSource>
             {
+                { CodeInspectionSeverity.DoNotShow, null },
                 { CodeInspectionSeverity.Hint, ToImageSource(InspectionsUI.information_white) },
                 { CodeInspectionSeverity.Suggestion, ToImageSource(InspectionsUI.information) },
                 { CodeInspectionSeverity.Warning, ToImageSource(InspectionsUI.exclamation) },