Skip to content

Commit 778d916

Browse files
committed
Adjust implementation of CodeExplorerAddComponentService
1 parent 6c7dd4c commit 778d916

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

Rubberduck.Core/UI/CodeExplorer/CodeExplorerAddComponentService.cs

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System;
22
using System.Linq;
3+
using System.Text;
34
using Rubberduck.Navigation.CodeExplorer;
45
using Rubberduck.Parsing.VBA;
56
using Rubberduck.VBEditor.SafeComWrappers;
@@ -48,13 +49,16 @@ public void AddComponentWithAttributes(CodeExplorerItemViewModel node, Component
4849
var folderAnnotation = FolderAnnotation(node);
4950
var optionCompare = OptionCompareStatement();
5051

51-
var basePrefixInModule = optionCompare != null
52-
? $"{folderAnnotation}{Environment.NewLine}{optionCompare}"
53-
: folderAnnotation;
54-
55-
var prefixInModule = additionalPrefixInModule != null
56-
? $"{basePrefixInModule}{Environment.NewLine}{additionalPrefixInModule}"
57-
: basePrefixInModule;
52+
var modulePrefix = new StringBuilder(folderAnnotation);
53+
if (optionCompare != null)
54+
{
55+
modulePrefix.Append(Environment.NewLine).Append(optionCompare);
56+
}
57+
if (additionalPrefixInModule != null)
58+
{
59+
modulePrefix.Append(Environment.NewLine).Append(additionalPrefixInModule);
60+
}
61+
var prefixInModule = modulePrefix.ToString();
5862

5963
_parseManager.OnSuspendParser(
6064
this,
@@ -79,7 +83,7 @@ private string Folder(CodeExplorerItemViewModel node)
7983
var declaration = node?.Declaration;
8084
if (declaration == null)
8185
{
82-
return ActiveProjectName();
86+
return ActiveProjectFolder();
8387
}
8488

8589
var customFolder = declaration.CustomFolder;

Rubberduck.Core/UI/CodeExplorer/Commands/CodeExplorerFindAllReferencesCommand.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,10 @@ public CodeExplorerFindAllReferencesCommand(RubberduckParserState state, FindAll
3030

3131
private bool SpecialEvaluateCanExecute(object parameter)
3232
{
33-
return ((ICodeExplorerNode)parameter).Declaration != null &&
34-
(!(parameter is CodeExplorerReferenceViewModel reference) || !reference.IsDimmed) &&
35-
_state.Status == ParserState.Ready;
33+
return _state.Status == ParserState.Ready
34+
&& ((ICodeExplorerNode)parameter).Declaration != null
35+
&& !(parameter is CodeExplorerReferenceViewModel reference
36+
&& reference.IsDimmed);
3637
}
3738

3839
protected override void OnExecute(object parameter)

0 commit comments

Comments
 (0)