fixes #4460

Author: retailcoder

Rubberduck.VBEEditor/SourceCodeHandling/CodePaneSourceCodeHandler.cs

@@ -125,10 +125,10 @@ public CodeString Prettify(ICodeModule module, CodeString original)
             }
 
             var prettifiedPosition = new Selection(
-                    original.SnippetPosition.StartLine - 1 + original.CaretPosition.StartLine,
+                    original.SnippetPosition.ToZeroBased().StartLine + original.CaretPosition.StartLine,
                     prettifiedCode[original.CaretPosition.StartLine].Trim().Length == 0
                         ? indent
-                        : Math.Min(prettifiedCode[original.CaretPosition.StartLine].Length, prettifiedCaretCharIndex + 1))
+                        : Math.Min(prettifiedCode[original.CaretPosition.StartLine].Length, original.CaretPosition.StartColumn))
                 .ToOneBased();
 
             SetSelection(module, prettifiedPosition);

RubberduckTests/AutoComplete/SelfClosingPairCompletionTests.cs

@@ -176,22 +176,6 @@ public void DeletingOpeningChar_IndexExpr()
             Assert.AreEqual(expected, result);
         }
 
-        [Test] // ref. #4460
-        public void OpeningOnSecondLineDoesNotJumpToEndOfLine()
-        {
-            var pair = new SelfClosingPair('"', '"');
-            var input = '"';
-            var original = @"
-ExecuteStoredProcedure (""AddAppointmentCountForAClinic"", False,dbconfig.SQLConString, _
-                | thisClinic.ClinicID ,".ToCodeString();
-            var expected = @"
-ExecuteStoredProcedure (""AddAppointmentCountForAClinic"", False,dbconfig.SQLConString, _
-                ""|"" thisClinic.ClinicID ,".ToCodeString();
-
-            var result = Run(pair, original, input);
-            Assert.AreEqual(expected, result);
-        }
-
         [Test]
         public void DeletingOpeningCharRemovesPairedClosingChar_NestedParensMultiline()
         {