Simplify bindings by removing VM as an intermediary. Addresses #4597

Author: comintern

Rubberduck.Core/UI/Inspections/InspectionResultsControl.xaml

@@ -212,12 +212,12 @@
                         <ColumnDefinition />
                     </Grid.ColumnDefinitions>
                     <Image Style="{StaticResource IconMargin}" VerticalAlignment="Top" Grid.Column="0"
-                           Source="{Binding SelectedSeverity, Converter={StaticResource SeverityIconConverter}}"/>
-                    <TextBlock Grid.Column="1" Margin="4" Text="{Binding SelectedDescription}" FontWeight="Bold" TextWrapping="WrapWithOverflow"/>
+                           Source="{Binding SelectedInspection.Severity, Converter={StaticResource SeverityIconConverter}}"/>
+                    <TextBlock Grid.Column="1" Margin="4" Text="{Binding SelectedInspection.Description}" FontWeight="Bold" TextWrapping="WrapWithOverflow"/>
                 </Grid>
 
-                <TextBlock Margin="4" Text="{Binding SelectedMeta}" FontSize="10" TextWrapping="WrapWithOverflow"/>
-                <TextBlock Margin="8" Text="{Binding SelectedSelection}" FontSize="10" TextWrapping="WrapWithOverflow" />
+                <TextBlock Margin="4" Text="{Binding SelectedInspection.Meta}" FontSize="10" TextWrapping="WrapWithOverflow"/>
+                <TextBlock Margin="8" Text="{Binding SelectedInspection.QualifiedSelection}" FontSize="10" TextWrapping="WrapWithOverflow" />
 
                 <WrapPanel>
                     <controls:LinkButton Margin="4"

Rubberduck.Core/UI/Inspections/InspectionResultsViewModel.cs

@@ -160,10 +160,6 @@ public INavigateSource SelectedItem
                 _selectedItem = value; 
                 OnPropertyChanged();
                 OnPropertyChanged(nameof(QuickFixes));
-                OnPropertyChanged(nameof(SelectedDescription));
-                OnPropertyChanged(nameof(SelectedMeta));
-                OnPropertyChanged(nameof(SelectedSeverity));
-
                 SelectedInspection = null;
                 CanQuickFix = false;
                 CanExecuteQuickFixInProcedure = false;
@@ -173,8 +169,7 @@ public INavigateSource SelectedItem
                 if (_selectedItem is IInspectionResult inspectionResult)
                 {
                     SelectedInspection = inspectionResult.Inspection;
-                    SelectedSelection = inspectionResult.QualifiedSelection;
-                    
+
                     CanQuickFix = _quickFixProvider.HasQuickFixes(inspectionResult);
                     _defaultFix = _quickFixProvider.QuickFixes(inspectionResult).FirstOrDefault();
                     CanExecuteQuickFixInProcedure = _defaultFix != null && _defaultFix.CanFixInProcedure;
@@ -195,18 +190,9 @@ public IInspection SelectedInspection
             {
                 _selectedInspection = value;
                 OnPropertyChanged();
-                OnPropertyChanged(nameof(SelectedSelection));
             }
         }
 
-        public string SelectedDescription => SelectedInspection?.Description ?? string.Empty;
-
-        public string SelectedMeta => SelectedInspection?.Meta ?? string.Empty;
-
-        public CodeInspectionSeverity SelectedSeverity => SelectedInspection?.Severity ?? CodeInspectionSeverity.DoNotShow;
-
-        public QualifiedSelection SelectedSelection { get; private set; }
-
         public IEnumerable<DisplayQuickFix> QuickFixes
         {
             get