Skip to content

Commit 76c8731

Browse files
committed
fixed failing tests
1 parent b35910f commit 76c8731

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

RetailCoder.VBE/Inspections/InspectionResultBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace Rubberduck.Inspections
1313
public abstract class InspectionResultBase : ICodeInspectionResult, INavigateSource
1414
{
1515
protected InspectionResultBase(IInspection inspection, Declaration target)
16-
: this(inspection, target.QualifiedName.QualifiedModuleName, null)
16+
: this(inspection, target.QualifiedName.QualifiedModuleName, target.Context)
1717
{
1818
_target = target;
1919
}

RetailCoder.VBE/Inspections/ParameterCanBeByValInspectionResult.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public PassParameterByValueQuickFix(ParserRuleContext context, QualifiedSelectio
4343

4444
public override void Fix()
4545
{
46-
var parameter = Context.Parent.GetText();
46+
var parameter = Context.GetText();
4747
var newContent = string.Concat(Tokens.ByVal, " ", parameter.Replace(Tokens.ByRef, string.Empty).Trim());
4848
var selection = Selection.Selection;
4949

RetailCoder.VBE/Inspections/ParameterNotUsedInspection.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,7 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
5555
!IsInterfaceMemberParameter(parameter, interfaceMemberScopes)
5656
&& !builtInHandlers.Contains(parameter.ParentDeclaration))
5757
let isInterfaceImplementationMember = IsInterfaceMemberImplementationParameter(issue, interfaceImplementationMemberScopes)
58-
select new ParameterNotUsedInspectionResult(this, string.Format(Description, issue.IdentifierName),
59-
((dynamic) issue.Context).ambiguousIdentifier(), issue.QualifiedName,
60-
isInterfaceImplementationMember, quickFixRefactoring, State);
58+
select new ParameterNotUsedInspectionResult(this, issue, isInterfaceImplementationMember, quickFixRefactoring, State);
6159

6260
return issues.ToList();
6361
}

RetailCoder.VBE/Inspections/ParameterNotUsedInspectionResult.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System.Collections.Generic;
22
using Antlr4.Runtime;
3+
using Rubberduck.Parsing.Symbols;
34
using Rubberduck.Parsing.VBA;
45
using Rubberduck.Refactorings.RemoveParameters;
56
using Rubberduck.VBEditor;
@@ -10,10 +11,9 @@ public class ParameterNotUsedInspectionResult : InspectionResultBase
1011
{
1112
private readonly IEnumerable<CodeInspectionQuickFix> _quickFixes;
1213

13-
public ParameterNotUsedInspectionResult(IInspection inspection, string result,
14-
ParserRuleContext context, QualifiedMemberName qualifiedName, bool isInterfaceImplementation,
14+
public ParameterNotUsedInspectionResult(IInspection inspection, Declaration declaration, bool isInterfaceImplementation,
1515
RemoveParametersRefactoring refactoring, RubberduckParserState parseResult)
16-
: base(inspection, qualifiedName.QualifiedModuleName, context)
16+
: base(inspection, declaration)
1717
{
1818
_quickFixes = isInterfaceImplementation ? new CodeInspectionQuickFix[] {} : new CodeInspectionQuickFix[]
1919
{

0 commit comments

Comments
 (0)