Ensure RD directories exist on app startup, short circuit bad settings file loads.

Author: comintern

RetailCoder.VBE/App.cs

@@ -1,4 +1,5 @@
-using Infralution.Localization.Wpf;
+using System.IO;
+using Infralution.Localization.Wpf;
 using Microsoft.Vbe.Interop;
 using NLog;
 using Rubberduck.Common;
@@ -169,13 +170,29 @@ private void _configService_SettingsChanged(object sender, ConfigurationChangedE
             }
         }
 
+        private void EnsureDirectoriesExist()
+        {
+            try
+            {
+                if (!Directory.Exists(ApplicationConstants.LOG_FOLDER_PATH))
+                {
+                    Directory.CreateDirectory(ApplicationConstants.LOG_FOLDER_PATH);
+                }
+            }
+            catch
+            {
+                //Does this need to display some sort of dialog?
+            }
+        }
+
         private void UpdateLoggingLevel()
         {
             LogLevelHelper.SetMinimumLogLevel(LogLevel.FromOrdinal(_config.UserSettings.GeneralSettings.MinimumLogLevel));
         }
 
         public void Startup()
         {
+            EnsureDirectoriesExist();
             LoadConfig();
             _appMenus.Initialize();
             _hooks.HookHotkeys(); // need to hook hotkeys before we localize menus, to correctly display ShortcutTexts

RetailCoder.VBE/Common/ApplicationConstants.cs

@@ -5,6 +5,7 @@ namespace Rubberduck.Common
 {
     public static class ApplicationConstants
     {
-        public static readonly string LOG_FOLDER_PATH = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), "Rubberduck", "Logs");
+        public static readonly string RUBBERDUCK_FOLDER_PATH = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData), "Rubberduck");
+        public static readonly string LOG_FOLDER_PATH = Path.Combine(RUBBERDUCK_FOLDER_PATH, "Logs");
     }
 }

RetailCoder.VBE/Common/WindowsOperatingSystem.cs

@@ -1,11 +1,16 @@
 using System.Diagnostics;
+using System.IO;
 
 namespace Rubberduck.Common
 {
     public sealed class WindowsOperatingSystem : IOperatingSystem
     {
         public void ShowFolder(string folderPath)
         {
+            if (!Directory.Exists(folderPath))
+            {
+                Directory.CreateDirectory(folderPath);
+            }
             Process.Start(folderPath);
         }
     }

Rubberduck.SettingsProvider/XmlPersistanceService.cs

@@ -33,8 +33,14 @@ public string FilePath
 
         public T Load(T toDeserialize)
         {
-            var doc = GetConfigurationDoc(FilePath);
             var type = typeof(T);
+
+            if (!File.Exists(FilePath))
+            {
+                return (T)Convert.ChangeType(null, type);
+            }
+            var doc = GetConfigurationDoc(FilePath);
+            
             var node = doc.Descendants().FirstOrDefault(e => e.Name.LocalName.Equals(type.Name));
             if (node == null)
             {