Multiple resolver and parser/parser state fixes, ExcelObjectModel, and inspections fixes, fixes #1157

Author: retailcoder

RetailCoder.VBE/Inspections/ImplicitActiveSheetReferenceInspection.cs

@@ -37,10 +37,11 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
                 // if host isn't Excel, the ExcelObjectModel declarations shouldn't be loaded anyway.
             }
 
-            var issues = Declarations.Where(item => item.IsBuiltIn 
-                && item.ParentScope == "Excel.Global"
-                && Targets.Contains(item.IdentifierName)
-                && item.References.Any())
+            var matches = BuiltInDeclarations.Where(item =>
+                (item.ParentScope == "Excel.Global" || item.ParentScope == "Excel.Application")
+                && Targets.Contains(item.IdentifierName)).ToList();
+
+            var issues = matches.Where(item => item.References.Any())
                 .SelectMany(declaration => declaration.References);
 
             return issues.Select(issue => 

RetailCoder.VBE/Inspections/InspectionBase.cs

@@ -74,6 +74,11 @@ protected virtual IEnumerable<Declaration> Declarations
             get { return State.AllDeclarations.Where(declaration => !declaration.IsInspectionDisabled(AnnotationName)); }
         }
 
+        protected virtual IEnumerable<Declaration> BuiltInDeclarations
+        {
+            get { return State.AllDeclarations.Where(declaration => declaration.IsBuiltIn); }
+        }
+
         /// <summary>
         /// Gets all user declarations in the parser state without an @Ignore annotation for this inspection.
         /// </summary>

RetailCoder.VBE/Inspections/InspectionsUI.Designer.cs

@@ -166,13 +166,13 @@
     <value>Ignore once</value>
   </data>
   <data name="ImplicitActiveSheetReferenceInspectionMeta" xml:space="preserve">
-    <value>Implicit references to the active sheet make the code frail and harder to debug. Consider making these references explicit when they're intended, and prefer working off object references.</value>
+    <value>Implicit references to the active sheet make the code frail and harder to debug. Consider making these references explicit when they're intended, and prefer working off object references. Ignore if the member call is referring to a type Rubberduck can't resolve.</value>
   </data>
   <data name="ImplicitActiveSheetReferenceInspectionName" xml:space="preserve">
     <value>Implicit reference to ActiveSheet</value>
   </data>
   <data name="ImplicitActiveWorkbookReferenceInspectionMeta" xml:space="preserve">
-    <value>Implicit references to the active workbook make the code frail and harder to debug. Consider making these references explicit when they're intended, and prefer working off object references.</value>
+    <value>Implicit references to the active workbook make the code frail and harder to debug. Consider making these references explicit when they're intended, and prefer working off object references. Ignore if the member call is referring to a type Rubberduck can't resolve.</value>
   </data>
   <data name="ImplicitActiveWorkbookReferenceInspectionName" xml:space="preserve">
     <value>Implicit reference to ActiveWorkbook</value>
@@ -274,7 +274,7 @@
     <value>'Option Base 1' is specified</value>
   </data>
   <data name="OptionExplicitInspectionMeta" xml:space="preserve">
-    <value>Rubberduck cannot see variables that aren't declared. VBA will happily compile a typo and you'll soon be asking an embarassing question on Stack Overflow. Avoid problems, use 'Option Explicit'. </value>
+    <value>Rubberduck cannot see variables that aren't declared. VBA will happily compile a typo: use 'Option Explicit' to prevent successfully compiling an erroneous program.</value>
   </data>
   <data name="OptionExplicitInspectionName" xml:space="preserve">
     <value>'Option Explicit' is not specified</value>

RetailCoder.VBE/Inspections/InspectionsUI.resx

@@ -432,5 +432,15 @@ public override int GetHashCode()
                 return hash;
             }
         }
+
+        public void ClearReferences()
+        {
+            var references = _references.ToList();
+            for (var i = 0; i < references.Count; i++)
+            {
+                IdentifierReference reference;
+                _references.TryTake(out reference);
+            }
+        }
     }
 }

Rubberduck.Parsing/Symbols/Declaration.cs

@@ -44,7 +44,7 @@ private class ExcelLib
 
         private class WorkbookClass
         {
-            public static readonly Declaration Workbook = new Declaration(new QualifiedMemberName(ExcelModuleName, "Workbook"), ExcelLib.Excel, "Excel", "Workbook", false, false, Accessibility.Global, DeclarationType.Class);
+            public static readonly Declaration Workbook = new Declaration(new QualifiedMemberName(WorkbookModuleName, "Workbook"), ExcelLib.Excel, "Excel", "Workbook", false, false, Accessibility.Global, DeclarationType.Class);
 
             public static Declaration ActiveSheet = new Declaration(new QualifiedMemberName(WorkbookModuleName, "ActiveSheet"), Workbook, "Excel.Workbook", "Worksheet", false, false, Accessibility.Public, DeclarationType.PropertyGet); // cheating on return type
             public static Declaration Sheets = new Declaration(new QualifiedMemberName(WorkbookModuleName, "Sheets"), Workbook, "Excel.Workbook", "Sheets", false, false, Accessibility.Public, DeclarationType.PropertyGet);
@@ -91,7 +91,7 @@ private class WorkbookClass
 
         private class WorksheetClass
         {
-            public static readonly Declaration Worksheet = new Declaration(new QualifiedMemberName(ExcelModuleName, "Worksheet"), ExcelLib.Excel, "Excel", "Worksheet", false, false, Accessibility.Global, DeclarationType.Class);
+            public static readonly Declaration Worksheet = new Declaration(new QualifiedMemberName(WorksheetModuleName, "Worksheet"), ExcelLib.Excel, "Excel", "Worksheet", false, false, Accessibility.Global, DeclarationType.Class);
 
             public static Declaration Evaluate = new Declaration(new QualifiedMemberName(WorksheetModuleName, "Evaluate"), Worksheet, "Excel.Worksheet", "Variant", false, false, Accessibility.Public, DeclarationType.Function);
             public static Declaration Range = new Declaration(new QualifiedMemberName(WorksheetModuleName, "Range"), Worksheet, "Excel.Worksheet", "Range", true, false, Accessibility.Public, DeclarationType.PropertyGet);
@@ -125,7 +125,7 @@ private class WorksheetClass
 
         private class RangeClass
         {
-            public static readonly Declaration Range = new Declaration(new QualifiedMemberName(ExcelModuleName, "Range"), ExcelLib.Excel, "Excel", "Range", false, false, Accessibility.Global, DeclarationType.Class);
+            public static readonly Declaration Range = new Declaration(new QualifiedMemberName(RangeModuleName, "Range"), ExcelLib.Excel, "Excel", "Range", false, false, Accessibility.Global, DeclarationType.Class);
 
             public static Declaration Cells = new Declaration(new QualifiedMemberName(RangeModuleName, "Cells"), Range, "Excel.Range", "Range", false, false, Accessibility.Public, DeclarationType.PropertyGet);
             public static Declaration CellsAssign = new Declaration(new QualifiedMemberName(RangeModuleName, "Cells"), Range, "Excel.Range", "Range", false, false, Accessibility.Public, DeclarationType.PropertyLet); // cheating to simulate default property of return type.
@@ -163,28 +163,28 @@ private class GlobalClass
 
         private class ApplicationClass
         {
-            public static readonly Declaration Application = new Declaration(new QualifiedMemberName(ExcelModuleName, "Application"), ExcelLib.Excel, "Application", "Application", false, false, Accessibility.Global, DeclarationType.Module); // cheating, it's actually a class.
-
-            public static Declaration Evaluate = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Evaluate"), Application, "Excel.Application", "Variant", false, false, Accessibility.Global, DeclarationType.Function);
-            public static Declaration Range = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Range"), Application, "Excel.Application", "Range", true, false, Accessibility.Global, DeclarationType.PropertyGet);
-            public static Declaration RangeAssign = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Range"), Application, "Excel.Application", "Range", true, false, Accessibility.Global, DeclarationType.PropertyLet); // cheating to simuate default property of return type.
-            public static Declaration Selection = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Selection"), Application, "Excel.Application", "Object", true, false, Accessibility.Global, DeclarationType.PropertyGet);
-
-            public static Declaration Activate = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Activate"), Application, "Excel.Application", "Variant", false, false, Accessibility.Global, DeclarationType.Function);
-            public static Declaration Select = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Select"), Application, "Excel.Application", "Variant", false, false, Accessibility.Global, DeclarationType.Function);
-            public static Declaration Cells = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Cells"), Application, "Excel.Application", "Range", false, false, Accessibility.Global, DeclarationType.PropertyGet);
-            public static Declaration CellsAssign = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Cells"), Application, "Excel.Application", "Range", false, false, Accessibility.Global, DeclarationType.PropertyLet); // cheating to simulate default property of return type.
-            public static Declaration Names = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Names"), Application, "Excel.Application", "Names", false, false, Accessibility.Global, DeclarationType.PropertyGet);
-            public static Declaration Sheets = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Sheets"), Application, "Excel.Application", "Sheets", false, false, Accessibility.Global, DeclarationType.PropertyGet);
-            public static Declaration Worksheets = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Worksheets"), Application, "Excel.Application", "Worksheets", false, false, Accessibility.Global, DeclarationType.PropertyGet);
-            public static Declaration WorksheetFunction = new Declaration(new QualifiedMemberName(ApplicationModuleName, "WorksheetFunction"), Application, "Excel.Application", "WorksheetFunction", false, false, Accessibility.Global, DeclarationType.PropertyGet);
-
-            public static Declaration Columns = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Columns"), Application, "Excel.Application", "Range", false, false, Accessibility.Global, DeclarationType.PropertyGet);
-            public static Declaration Rows = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Rows"), Application, "Excel.Application", "Range", false, false, Accessibility.Global, DeclarationType.PropertyGet);
-
-            public static Declaration ActiveCell = new Declaration(new QualifiedMemberName(ApplicationModuleName, "ActiveCell"), Application, "Excel.Application", "Range", false, false, Accessibility.Global, DeclarationType.PropertyGet);
-            public static Declaration ActiveSheet = new Declaration(new QualifiedMemberName(ApplicationModuleName, "ActiveSheet"), Application, "Excel.Application", "Worksheet", false, false, Accessibility.Global, DeclarationType.PropertyGet); // cheating on return type
-            public static Declaration ActiveWorkbook = new Declaration(new QualifiedMemberName(ApplicationModuleName, "ActiveWorkbook"), Application, "Excel.Application", "Workbook", false, false, Accessibility.Global, DeclarationType.PropertyGet);
+            public static readonly Declaration Application = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Application"), ExcelLib.Excel, "Application", "Application", false, false, Accessibility.Global, DeclarationType.Module); // cheating, it's actually a class.
+
+            public static Declaration Evaluate = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Evaluate"), Application, "Excel.Application", "Variant", false, false, Accessibility.Public, DeclarationType.Function);
+            public static Declaration Range = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Range"), Application, "Excel.Application", "Range", true, false, Accessibility.Public, DeclarationType.PropertyGet);
+            public static Declaration RangeAssign = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Range"), Application, "Excel.Application", "Range", true, false, Accessibility.Public, DeclarationType.PropertyLet); // cheating to simuate default property of return type.
+            public static Declaration Selection = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Selection"), Application, "Excel.Application", "Object", true, false, Accessibility.Public, DeclarationType.PropertyGet);
+
+            public static Declaration Activate = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Activate"), Application, "Excel.Application", "Variant", false, false, Accessibility.Public, DeclarationType.Function);
+            public static Declaration Select = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Select"), Application, "Excel.Application", "Variant", false, false, Accessibility.Public, DeclarationType.Function);
+            public static Declaration Cells = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Cells"), Application, "Excel.Application", "Range", false, false, Accessibility.Public, DeclarationType.PropertyGet);
+            public static Declaration CellsAssign = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Cells"), Application, "Excel.Application", "Range", false, false, Accessibility.Public, DeclarationType.PropertyLet); // cheating to simulate default property of return type.
+            public static Declaration Names = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Names"), Application, "Excel.Application", "Names", false, false, Accessibility.Public, DeclarationType.PropertyGet);
+            public static Declaration Sheets = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Sheets"), Application, "Excel.Application", "Sheets", false, false, Accessibility.Public, DeclarationType.PropertyGet);
+            public static Declaration Worksheets = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Worksheets"), Application, "Excel.Application", "Worksheets", false, false, Accessibility.Public, DeclarationType.PropertyGet);
+            public static Declaration WorksheetFunction = new Declaration(new QualifiedMemberName(ApplicationModuleName, "WorksheetFunction"), Application, "Excel.Application", "WorksheetFunction", false, false, Accessibility.Public, DeclarationType.PropertyGet);
+
+            public static Declaration Columns = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Columns"), Application, "Excel.Application", "Range", false, false, Accessibility.Public, DeclarationType.PropertyGet);
+            public static Declaration Rows = new Declaration(new QualifiedMemberName(ApplicationModuleName, "Rows"), Application, "Excel.Application", "Range", false, false, Accessibility.Public, DeclarationType.PropertyGet);
+
+            public static Declaration ActiveCell = new Declaration(new QualifiedMemberName(ApplicationModuleName, "ActiveCell"), Application, "Excel.Application", "Range", false, false, Accessibility.Public, DeclarationType.PropertyGet);
+            public static Declaration ActiveSheet = new Declaration(new QualifiedMemberName(ApplicationModuleName, "ActiveSheet"), Application, "Excel.Application", "Worksheet", false, false, Accessibility.Public, DeclarationType.PropertyGet); // cheating on return type
+            public static Declaration ActiveWorkbook = new Declaration(new QualifiedMemberName(ApplicationModuleName, "ActiveWorkbook"), Application, "Excel.Application", "Workbook", false, false, Accessibility.Public, DeclarationType.PropertyGet);
         }
     }
 }