add behaviours for getting extracted declaration

Author: grleachman

RetailCoder.VBE/Refactorings/ExtractMethod/IExtractMethodRule.cs

@@ -36,11 +36,10 @@ public class ExtractMethodRuleExternalReference : IExtractMethodRule
     {
         public void setValidFlag(ref byte flags, IdentifierReference reference, Selection selection)
         {
+            var decStartLine = reference.Declaration.Selection.StartLine;
             if (reference.Selection.StartLine > selection.EndLine &&
-                selection.StartLine <= reference.Declaration.Selection.StartLine &&
-                reference.Declaration.Selection.StartLine <= selection.EndLine)
+                selection.StartLine <= decStartLine &&  decStartLine <= selection.EndLine)
             {
-
                 flags = (byte)(flags | (byte)ExtractMethodRuleFlags.IsExternallyReferenced);
             }
         }

RubberduckTests/Refactoring/ExtractMethod/ExtractMethodModelTests.cs

@@ -11,6 +11,65 @@
 
 namespace RubberduckTests.Refactoring.ExtractMethod
 {
+    [TestClass]
+    public class ExtractMethodRuleExternalReferenceTests
+    {
+
+        [TestClass]
+        public class WhenSetValidFlagIsCalledWhenTheReferenceIsInternal: ExtractMethodRuleExternalReferenceTests
+        {
+            [TestMethod]
+            [TestCategory("ExtractMethodRuleTests")]
+            public void shouldSetTheFlag()
+            {
+                byte flag = new byte();
+                var usedSelection = new Selection(4, 1, 7, 10);
+                var referenceSelection = new Selection(8, 1, 8, 10);
+                
+                var decQualifiedMemberName = new QualifiedMemberName(new QualifiedModuleName(),"");
+                var decSelection = new Selection(5,1,5,10);
+                var referenceDeclaration = new Declaration(decQualifiedMemberName, null, "", "", "", 
+                    false, false, Accessibility.Friend, DeclarationType.ClassModule, 
+                    context: null, selection: decSelection, isArray: false, asTypeContext: null);
+
+                IdentifierReference reference = new IdentifierReference(new QualifiedModuleName(), null, null, "a", referenceSelection, null, referenceDeclaration);
+
+                var SUT = new ExtractMethodRuleExternalReference();
+                SUT.setValidFlag(ref flag, reference, usedSelection);
+                var expected = ((byte)ExtractMethodRuleFlags.IsExternallyReferenced);
+                Assert.AreEqual(expected, flag);
+            }
+        }
+        
+        [TestClass]
+        public class WhenSetValidFlagIsCalledWhenTheReferenceIsUsedInternallyOnly : ExtractMethodRuleExternalReferenceTests
+        {
+            [TestMethod]
+            [TestCategory("ExtractMethodRuleTests")]
+            public void shouldNotSetFlag()
+            {
+                byte flag = new byte();
+                var usedSelection = new Selection(4, 1, 7, 10);
+
+                var referenceSelection = new Selection(7, 1, 7, 10);
+                
+                var decQualifiedMemberName = new QualifiedMemberName(new QualifiedModuleName(),"");
+                var decSelection = new Selection(5,1,5,10);
+                var referenceDeclaration = new Declaration(decQualifiedMemberName, null, "", "", "", 
+                    false, false, Accessibility.Friend, DeclarationType.ClassModule, 
+                    context: null, selection: decSelection, isArray: false, asTypeContext: null);
+
+                IdentifierReference reference = new IdentifierReference(new QualifiedModuleName(), null, null, "a", referenceSelection, null, referenceDeclaration);
+
+                var SUT = new ExtractMethodRuleExternalReference();
+                SUT.setValidFlag(ref flag, reference, usedSelection);
+
+                Assert.AreEqual(0, flag);
+
+            }
+        }
+    }
+
     [TestClass]
     public class ExtractMethodRuleInSelectionTests
     {