Skip to content

Commit 73201d4

Browse files
committed
Unit test for #1029
1 parent 6843bdf commit 73201d4

File tree

1 file changed

+29
-3
lines changed

1 file changed

+29
-3
lines changed

RubberduckTests/Inspections/UseMeaningfulNameInspectionTests.cs

Lines changed: 29 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ public void UseMeaningfulName_ReturnsResult_NameEndsWithDigit()
9494
}
9595

9696
[TestMethod]
97-
public void UseMeaningfulName_DoesNotReturnsResult()
97+
public void UseMeaningfulName_DoesNotReturnsResult_GoodName()
9898
{
9999
const string inputCode =
100100
@"Sub FooBar()
@@ -103,7 +103,7 @@ public void UseMeaningfulName_DoesNotReturnsResult()
103103
//Arrange
104104
var builder = new MockVbeBuilder();
105105
var project = builder.ProjectBuilder("VBAProject", vbext_ProjectProtection.vbext_pp_none)
106-
.AddComponent("Class1", vbext_ComponentType.vbext_ct_ClassModule, inputCode)
106+
.AddComponent("MyClass", vbext_ComponentType.vbext_ct_ClassModule, inputCode)
107107
.Build();
108108
var vbe = builder.AddProject(project).Build();
109109

@@ -117,7 +117,33 @@ public void UseMeaningfulName_DoesNotReturnsResult()
117117
var inspection = new UseMeaningfulNameInspection(null, parser.State);
118118
var inspectionResults = inspection.GetInspectionResults();
119119

120-
Assert.AreEqual(1, inspectionResults.Count());
120+
Assert.AreEqual(0, inspectionResults.Count());
121+
}
122+
123+
[TestMethod]
124+
public void UseMeaningfulName_DoesNotReturnsResult_OptionBase()
125+
{
126+
const string inputCode =
127+
@"Option Base 1";
128+
129+
//Arrange
130+
var builder = new MockVbeBuilder();
131+
var project = builder.ProjectBuilder("VBAProject", vbext_ProjectProtection.vbext_pp_none)
132+
.AddComponent("MyClass", vbext_ComponentType.vbext_ct_ClassModule, inputCode)
133+
.Build();
134+
var vbe = builder.AddProject(project).Build();
135+
136+
var mockHost = new Mock<IHostApplication>();
137+
mockHost.SetupAllProperties();
138+
var parser = new RubberduckParser(vbe.Object, new RubberduckParserState());
139+
140+
parser.Parse();
141+
if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
142+
143+
var inspection = new UseMeaningfulNameInspection(null, parser.State);
144+
var inspectionResults = inspection.GetInspectionResults();
145+
146+
Assert.AreEqual(0, inspectionResults.Count());
121147
}
122148

123149
[TestMethod]

0 commit comments

Comments
 (0)