Fix inspections reset

Author: Hosch250

RetailCoder.VBE/Inspections/IInspectionModel.cs

@@ -22,6 +22,11 @@ public interface IInspectionModel
         /// </summary>
         CodeInspectionType InspectionType { get; }
 
+        /// <summary>
+        /// Gets a value indicating the default severity level of the code inspection.
+        /// </summary>
+        CodeInspectionSeverity DefaultSeverity { get; }
+
         /// <summary>
         /// Gets a value indicating the severity level of the code inspection.
         /// </summary>

RetailCoder.VBE/Settings/CodeInspectionSettings.cs

@@ -34,6 +34,9 @@ public class CodeInspectionSetting : IInspectionModel
         [XmlIgnore]
         public string AnnotationName { get; set; }
 
+        [XmlIgnore]
+        public CodeInspectionSeverity DefaultSeverity { get; private set; }
+
         [XmlAttribute]
         public CodeInspectionSeverity Severity { get; set; }
 
@@ -76,16 +79,17 @@ public CodeInspectionSetting()
             //default constructor required for serialization
         }
 
-        public CodeInspectionSetting(string name, string description, CodeInspectionType type, CodeInspectionSeverity severity)
+        public CodeInspectionSetting(string name, string description, CodeInspectionType type, CodeInspectionSeverity defaultSeverity, CodeInspectionSeverity severity)
         {
             Name = name;
             Description = description;
             InspectionType = type;
             Severity = severity;
+            DefaultSeverity = defaultSeverity;
         }
 
         public CodeInspectionSetting(IInspectionModel inspection)
-            : this(inspection.Name, inspection.Description, inspection.InspectionType, inspection.Severity)
+            : this(inspection.Name, inspection.Description, inspection.InspectionType, inspection.DefaultSeverity, inspection.Severity)
         { }
     }
 }

RetailCoder.VBE/Settings/ConfigurationLoader.cs

@@ -5,8 +5,6 @@
 using System.Text;
 using System.Windows.Forms;
 using Rubberduck.Inspections;
-using Rubberduck.SmartIndenter;
-using Rubberduck.ToDoItems;
 using Rubberduck.UI;
 using MessageBox = System.Windows.Forms.MessageBox;
 
@@ -157,7 +155,9 @@ public ToDoMarker[] GetDefaultTodoMarkers()
         /// <returns>   An array of Config.CodeInspection. </returns>
         public CodeInspectionSetting[] GetDefaultCodeInspections()
         {
-            return _inspections.Select(x => new CodeInspectionSetting(x)).ToArray();
+            return _inspections.Select(x =>
+                        new CodeInspectionSetting(x.Name, x.Description, x.InspectionType, x.DefaultSeverity,
+                            x.DefaultSeverity)).ToArray();
         }
 
         public IndenterSettings GetDefaultIndenterSettings()

RetailCoder.VBE/UI/Settings/InspectionSettings.xaml

@@ -50,7 +50,7 @@
 			    HeadersVisibility="None" ScrollViewer.HorizontalScrollBarVisibility="Disabled"
 			    ColumnHeaderHeight="22" BorderThickness="0">
                 <controls:GroupingGrid.Columns>
-                    <DataGridTemplateColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=NameLabelText}" Width="2.75*" IsReadOnly="True">
+                    <DataGridTemplateColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=NameLabelText}" Width="2.75*" IsReadOnly="True" SortMemberPath="{Binding Description}">
                         <DataGridTemplateColumn.CellTemplate>
                             <DataTemplate>
                                 <TextBlock Text="{Binding Description}">

RubberduckTests/ConfigurationTests.cs

@@ -2,7 +2,6 @@
 using Moq;
 using Rubberduck.Inspections;
 using Rubberduck.Settings;
-using Rubberduck.ToDoItems;
 
 namespace RubberduckTests
 {
@@ -24,9 +23,9 @@ public void GetDefaultTodoMarkersTest()
         public void DefaultCodeInspectionsIsAsSpecified()
         {
             var inspection = new Mock<IInspection>();
-            //inspection.SetupGet(m => m.Description).Returns("TestInspection");
-            //inspection.SetupGet(m => m.Name).Returns("TestInspection");
-            //inspection.SetupGet(m => m.Severity).Returns(CodeInspectionSeverity.DoNotShow);
+            inspection.SetupGet(m => m.Description).Returns("TestInspection");
+            inspection.SetupGet(m => m.Name).Returns("TestInspection");
+            inspection.SetupGet(m => m.Severity).Returns(CodeInspectionSeverity.DoNotShow);
 
             var expected = new[] { inspection.Object };
             var configService = new ConfigurationLoader(expected);