Skip to content

Commit 710acb4

Browse files
committed
Add todo marker and clean up the comments a bit
1 parent 46c000f commit 710acb4

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Rubberduck.Main/Extension.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,9 @@ private void InitializeAddIn()
211211
catch (Exception exception)
212212
{
213213
_logger.Fatal(exception);
214-
System.Windows.Forms.MessageBox.Show(
214+
// TODO Use Rubberduck Interaction instead and provide exception stack trace as
215+
// an optional "more info" collapsible section to eliminate the conditional.
216+
MessageBox.Show(
215217
#if DEBUG
216218
exception.ToString(),
217219
#else

Rubberduck.Parsing/Common/DisabledAttribute.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
using System;
2-
using System.Diagnostics;
32

43
namespace Rubberduck.Parsing.Common
54
{
6-
// Conditional cannot be expressed negatively, so we use combined #if and Conditional
7-
// to ensure that the code is always checked but omitted in non-debug builds.
5+
// Conditional cannot be an expression, so we use combined #if and an
6+
// non-existent flag to ensure that the code is always checked at the
7+
// compile time but omitted in non-debug builds.
88
#if !DEBUG
99
[Conditional("I_WILL_NEVER_EXIST_CRY_MY_BELOVED_DUCK")]
1010
#endif

0 commit comments

Comments
 (0)