Fix leaks due to missing using or Dispose()

Author: bclothier

Rubberduck.Core/Common/RubberduckHooks.cs

@@ -18,8 +18,16 @@ public class RubberduckHooks : SubclassingWindow, IRubberduckHooks
         private readonly IList<IAttachable> _hooks = new List<IAttachable>();
         private static readonly Logger Logger = LogManager.GetCurrentClassLogger();
 
+        private static IntPtr GetVbeMainWindowPtr(IVBE vbe)
+        {
+            using (var window = vbe.MainWindow)
+            {
+                return (IntPtr)window.HWnd;
+            }
+        }
+
         public RubberduckHooks(IVBE vbe, IGeneralConfigService config, HotkeyFactory hotkeyFactory, AutoCompleteService autoComplete)
-            : base((IntPtr)vbe.MainWindow.HWnd, (IntPtr)vbe.MainWindow.HWnd)
+            : base(GetVbeMainWindowPtr(vbe), GetVbeMainWindowPtr(vbe))
         {
             _config = config;
             _hotkeyFactory = hotkeyFactory;

Rubberduck.Core/Properties/Settings.Designer.cs

@@ -123,6 +123,7 @@
       <AutoGen>True</AutoGen>
       <DesignTimeSharedInput>True</DesignTimeSharedInput>
       <DependentUpon>Settings.settings</DependentUpon>
+      <DesignTime>True</DesignTime>
     </Compile>
     <None Include="Properties\Settings.settings">
       <Generator>PublicSettingsSingleFileGenerator</Generator>

Rubberduck.Core/Rubberduck.Core.csproj

@@ -3,7 +3,6 @@
 using NLog;
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
 using Rubberduck.Navigation.CodeExplorer;
-using Rubberduck.UI.CodeExplorer.Commands;
 using Rubberduck.Resources;
 using Rubberduck.VBEditor.SafeComWrappers;
 
@@ -32,17 +31,32 @@ protected override bool EvaluateCanExecute(object parameter)
                 return false;
             }
 
-            var projectNode = parameter as CodeExplorerProjectViewModel;
-
-            var project = parameter as IVBProject;
-
-            return Evaluate(projectNode?.Declaration.Project ?? project ?? _vbe.ActiveVBProject);
+            switch (parameter)
+            {
+                case CodeExplorerProjectViewModel projectNode:
+                    return Evaluate(projectNode.Declaration.Project);
+                case IVBProject project:
+                    return Evaluate(project);
+            }
 
+            using (var activeProject = _vbe.ActiveVBProject)
+            {
+                return Evaluate(activeProject);
+            }
         }
 
         private bool Evaluate(IVBProject project)
         {
-            return project != null && !project.IsWrappingNullReference && project.VBComponents.Count > 0;
+            if (project == null || project.IsWrappingNullReference)
+            {
+                return false;
+            }
+
+            using (var compontents = project.VBComponents)
+            {
+                return compontents.Count > 0;
+            }
+
         }
 
         protected override void OnExecute(object parameter)

Rubberduck.Core/UI/Command/ExportAllCommand.cs

@@ -192,24 +192,24 @@ private Declaration FindTarget(object parameter)
                 return declaration;
             }
 
-            bool findDesigner;
             using (var activePane = _vbe.ActiveCodePane)
             {
+                bool findDesigner;
                 using (var selectedComponent = _vbe.SelectedVBComponent)
                 {
-                    findDesigner = activePane != null && !activePane.IsWrappingNullReference 
-                                    && (selectedComponent?.HasDesigner ?? false);
+                    findDesigner = activePane != null && !activePane.IsWrappingNullReference
+                                                      && (selectedComponent?.HasDesigner ?? false);
                 }
-            }
 
-            return findDesigner
-                ? FindFormDesignerTarget()
-                : FindCodePaneTarget();
+                return findDesigner
+                    ? FindFormDesignerTarget()
+                    : FindCodePaneTarget(activePane);
+            }
         }
 
-        private Declaration FindCodePaneTarget()
+        private Declaration FindCodePaneTarget(ICodePane codePane)
         {
-            return _state.FindSelectedDeclaration(_vbe.ActiveCodePane);
+            return _state.FindSelectedDeclaration(codePane);
         }
 
         private Declaration FindFormDesignerTarget(QualifiedModuleName? qualifiedModuleName = null)

Rubberduck.Core/UI/Command/FindAllReferencesCommand.cs

@@ -23,7 +23,11 @@ public IndentCurrentProjectCommand(IVBE vbe, IIndenter indenter, RubberduckParse
 
         protected override bool EvaluateCanExecute(object parameter)
         {
-            return !_vbe.ActiveVBProject.IsWrappingNullReference && _vbe.ActiveVBProject.Protection != ProjectProtection.Locked;
+            using (var vbProject = _vbe.ActiveVBProject)
+            {
+                return !vbProject.IsWrappingNullReference &&
+                       vbProject.Protection != ProjectProtection.Locked;
+            }
         }
 
         protected override void OnExecute(object parameter)

Rubberduck.Core/UI/Command/IndentCurrentProjectCommand.cs

@@ -26,7 +26,7 @@ protected override bool EvaluateCanExecute(object parameter)
             Declaration target;
             using (var activePane = Vbe.ActiveCodePane)
             {
-                if (Vbe.ActiveCodePane == null || activePane.IsWrappingNullReference)
+                if (activePane == null || activePane.IsWrappingNullReference)
                 {
                     return false;
                 }

Rubberduck.Core/UI/Command/Refactorings/CodePaneRefactorRenameCommand.cs

@@ -57,32 +57,35 @@ private Declaration GetTarget(QualifiedModuleName? qualifiedModuleName = null)
             {
                 projectId = activeProject.ProjectId;
             }
-            var component = Vbe.SelectedVBComponent;
 
-            if (component?.HasDesigner ?? false)
+            using (var component = Vbe.SelectedVBComponent)
             {
-                DeclarationType selectedType;
-                string selectedName;
-                using (var selectedControls = component.SelectedControls)
+                if (component?.HasDesigner ?? false)
                 {
-                    var selectedCount = selectedControls.Count;
-                    if (selectedCount > 1)
+                    DeclarationType selectedType;
+                    string selectedName;
+                    using (var selectedControls = component.SelectedControls)
                     {
-                        return null;
+                        var selectedCount = selectedControls.Count;
+                        if (selectedCount > 1)
+                        {
+                            return null;
+                        }
+
+                        // Cannot use DeclarationType.UserForm, parser only assigns UserForms the ClassModule flag
+                        (selectedType, selectedName) = selectedCount == 0
+                            ? (DeclarationType.ClassModule, component.Name)
+                            : (DeclarationType.Control, selectedControls[0].Name);
                     }
 
-                    // Cannot use DeclarationType.UserForm, parser only assigns UserForms the ClassModule flag
-                    (selectedType, selectedName) = selectedCount == 0
-                        ? (DeclarationType.ClassModule, component.Name)
-                        : (DeclarationType.Control, selectedControls[0].Name);
+                    return _state.DeclarationFinder
+                        .MatchName(selectedName)
+                        .SingleOrDefault(m => m.ProjectId == projectId
+                                              && m.DeclarationType.HasFlag(selectedType)
+                                              && m.ComponentName == component.Name);
                 }
+            }
 
-                return _state.DeclarationFinder
-                    .MatchName(selectedName)
-                    .SingleOrDefault(m => m.ProjectId == projectId
-                        && m.DeclarationType.HasFlag(selectedType)
-                        && m.ComponentName == component.Name);
-             }
             return null;
         }
 

Rubberduck.Core/UI/Command/Refactorings/FormDesignerRefactorRenameCommand.cs

@@ -53,7 +53,8 @@ private IWindow CreateToolWindow(IDockableUserControl control)
             {
                 using (var windows = _vbe.Windows)
                 {
-                    var info = windows.CreateToolWindow(_addin, RubberduckProgId.DockableWindowHostProgId, control.Caption, control.ClassId);
+                    var info = windows.CreateToolWindow(_addin, RubberduckProgId.DockableWindowHostProgId,
+                        control.Caption, control.ClassId);
                     _userControlObject = info.UserControl;
                     toolWindow = info.ToolWindow;
                 }
@@ -68,14 +69,17 @@ private IWindow CreateToolWindow(IDockableUserControl control)
                 Logger.Error(exception);
                 throw;
             }
-            
+
             toolWindow.IsVisible = true; //window resizing doesn't work without this
             EnsureMinimumWindowSize(toolWindow);
             toolWindow.IsVisible = _settings != null && _settings.IsWindowVisible(this);
 
             // currently we always inject _DockableToolWindowHost from Rubberduck.Main.
             // that method is not exposed in any of the interfaces we know, though, so we need to invoke it blindly
-            ((dynamic)_userControlObject).AddUserControl(control as UserControl, new IntPtr(_vbe.MainWindow.HWnd));
+            using (var mainWindow = _vbe.MainWindow)
+            {
+                ((dynamic) _userControlObject).AddUserControl(control as UserControl, new IntPtr(mainWindow.HWnd));
+            }
 
             return toolWindow;
         }