Careful assignment of ProjectID - Avoids project collisions

ThunderFrame · ThunderFrame · commit 70a49e9c2d50 · 2016-06-07T15:06:16.000+10:00
All @Hosch250's work
diff --git a/Rubberduck.Parsing/VBA/RubberduckParserState.cs b/Rubberduck.Parsing/VBA/RubberduckParserState.cs
@@ -83,10 +83,15 @@ public void AddProject(VBProject project)
                 return;
             }
 
-            if (string.IsNullOrEmpty(project.HelpFile))
+            //if (string.IsNullOrEmpty(project.HelpFile))
+            //{
+            //    project.HelpFile = project.GetHashCode().ToString();
+            //}
+            while (string.IsNullOrEmpty(project.HelpFile) || _projects.Any(a => a.Key == project.HelpFile))
             {
-                project.HelpFile = project.GetHashCode().ToString();
+                project.HelpFile = (project.GetHashCode() ^ project.HelpFile.GetHashCode()).ToString();
             }
+
             var projectId = project.HelpFile;
             if (!_projects.ContainsKey(projectId))
             {

Original file line number	Diff line number	Diff line change
`@@ -83,10 +83,15 @@ public void AddProject(VBProject project)`
`83`	`83`	`return;`
`84`	`84`	`}`
`85`	`85`
`86`		`- if (string.IsNullOrEmpty(project.HelpFile))`
	`86`	`+ //if (string.IsNullOrEmpty(project.HelpFile))`
	`87`	`+ //{`
	`88`	`+ // project.HelpFile = project.GetHashCode().ToString();`
	`89`	`+ //}`
	`90`	`+ while (string.IsNullOrEmpty(project.HelpFile) \|\| _projects.Any(a => a.Key == project.HelpFile))`
`87`	`91`	`{`
`88`		`- project.HelpFile = project.GetHashCode().ToString();`
	`92`	`+ project.HelpFile = (project.GetHashCode() ^ project.HelpFile.GetHashCode()).ToString();`
`89`	`93`	`}`
	`94`	`+`
`90`	`95`	`var projectId = project.HelpFile;`
`91`	`96`	`if (!_projects.ContainsKey(projectId))`
`92`	`97`	`{`