Skip to content

Commit 6c6791f

Browse files
committed
Fix two premature disposals of SCWs
The return inside using one is somewhat hiddeous.
1 parent b25e5be commit 6c6791f

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Rubberduck.Core/UI/UnitTesting/Commands/AddTestModuleCommand.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,10 +143,13 @@ private IVBProject GetProject()
143143

144144
protected override bool EvaluateCanExecute(object parameter)
145145
{
146+
bool canExecute;
146147
using (var project = GetProject())
147148
{
148-
return project != null && !project.IsWrappingNullReference && CanExecuteCode(project);
149+
canExecute = project != null && !project.IsWrappingNullReference && CanExecuteCode(project);
149150
}
151+
152+
return canExecute;
150153
}
151154

152155
private bool CanExecuteCode(IVBProject project)

Rubberduck.VBEEditor/SourceCodeHandling/CodePaneSourceCodeHandler.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,8 @@ public CodeString GetCurrentLogicalLine(QualifiedModuleName module)
283283

284284
public Selection GetSelection(QualifiedModuleName module)
285285
{
286-
using (var component = _projectsProvider.Component(module))
286+
var component = _projectsProvider.Component(module);
287+
287288
using (var codeModule = component.CodeModule)
288289
using (var pane = codeModule.CodePane)
289290
{

0 commit comments

Comments
 (0)