Merge pull request #1192 from retailcoder/TypeInfo

Fixes #1191

Author: retailcoder

RetailCoder.VBE/Inspections/ParameterCanBeByValInspection.cs

@@ -67,7 +67,8 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
             var ignoredScopes = formEventHandlerScopes.Concat(eventScopes).Concat(declareScopes);
 
             var issues = declarations.Where(declaration =>
-                !ignoredScopes.Contains(declaration.ParentScope)
+                !declaration.IsArray()
+                && !ignoredScopes.Contains(declaration.ParentScope)
                 && declaration.DeclarationType == DeclarationType.Parameter
                 && !interfaceMembers.Select(m => m.Scope).Contains(declaration.ParentScope)
                 && ((VBAParser.ArgContext) declaration.Context).BYVAL() == null

Rubberduck.Parsing/VBA/AttributeParser.cs

@@ -105,7 +105,10 @@ public override void EnterSubStmt(AttributesParser.SubStmtContext context)
 
             public override void ExitSubStmt(AttributesParser.SubStmtContext context)
             {
-                _attributes.Add(_currentScope, _currentScopeAttributes);
+                if (_currentScopeAttributes.Any())
+                {
+                    _attributes.Add(_currentScope, _currentScopeAttributes);
+                }
             }
 
             public override void EnterFunctionStmt(AttributesParser.FunctionStmtContext context)
@@ -115,7 +118,10 @@ public override void EnterFunctionStmt(AttributesParser.FunctionStmtContext cont
 
             public override void ExitFunctionStmt(AttributesParser.FunctionStmtContext context)
             {
-                _attributes.Add(_currentScope, _currentScopeAttributes);
+                if (_currentScopeAttributes.Any())
+                {
+                    _attributes.Add(_currentScope, _currentScopeAttributes);
+                }
             }
 
             public override void EnterPropertyGetStmt(AttributesParser.PropertyGetStmtContext context)
@@ -125,7 +131,10 @@ public override void EnterPropertyGetStmt(AttributesParser.PropertyGetStmtContex
 
             public override void ExitPropertyGetStmt(AttributesParser.PropertyGetStmtContext context)
             {
-                _attributes.Add(_currentScope, _currentScopeAttributes);
+                if (_currentScopeAttributes.Any())
+                {
+                    _attributes.Add(_currentScope, _currentScopeAttributes);
+                }
             }
 
             public override void EnterPropertyLetStmt(AttributesParser.PropertyLetStmtContext context)
@@ -135,7 +144,10 @@ public override void EnterPropertyLetStmt(AttributesParser.PropertyLetStmtContex
 
             public override void ExitPropertyLetStmt(AttributesParser.PropertyLetStmtContext context)
             {
-                _attributes.Add(_currentScope, _currentScopeAttributes);
+                if (_currentScopeAttributes.Any())
+                {
+                    _attributes.Add(_currentScope, _currentScopeAttributes);
+                }
             }
 
             public override void EnterPropertySetStmt(AttributesParser.PropertySetStmtContext context)
@@ -145,7 +157,10 @@ public override void EnterPropertySetStmt(AttributesParser.PropertySetStmtContex
 
             public override void ExitPropertySetStmt(AttributesParser.PropertySetStmtContext context)
             {
-                _attributes.Add(_currentScope, _currentScopeAttributes);
+                if (_currentScopeAttributes.Any())
+                {
+                    _attributes.Add(_currentScope, _currentScopeAttributes);
+                }
             }
 
             public override void ExitAttributeStmt(AttributesParser.AttributeStmtContext context)

RubberduckTests/Inspections/ParameterCanBeByValInspectionTests.cs

@@ -218,6 +218,33 @@ public void ParameterCanByByVal_ReturnsResult_QuickFixWorks_PassedByRefUnassigne
             Assert.AreEqual(expectedCode, module.Lines());
         }
 
+        [TestMethod]
+        public void GivenArrayParameter_ReturnsNoResult()
+        {
+            const string inputCode =
+@"Sub Foo(ByRef arg1() As Variant)
+End Sub";
+
+            //Arrange
+            var builder = new MockVbeBuilder();
+            VBComponent component;
+            var vbe = builder.BuildFromSingleStandardModule(inputCode, out component);
+            var project = vbe.Object.VBProjects.Item(0);
+            var module = project.VBComponents.Item(0).CodeModule;
+            var mockHost = new Mock<IHostApplication>();
+            mockHost.SetupAllProperties();
+            var parser = MockParser.Create(vbe.Object, new RubberduckParserState());
+
+            parser.Parse();
+            if (parser.State.Status == ParserState.Error) { Assert.Inconclusive("Parser Error"); }
+
+            var inspection = new ParameterCanBeByValInspection(parser.State);
+            
+            var results = inspection.GetInspectionResults().ToList();
+
+            Assert.AreEqual(0, results.Count);
+        }
+
         [TestMethod]
         public void InspectionType()
         {