Skip to content

Commit 6a5ae19

Browse files
committed
Fix bug where no references need to be updated.
1 parent 6d82ad9 commit 6a5ae19

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

RetailCoder.VBE/Refactorings/MoveCloserToUsage/MoveCloserToUsageRefactoring.cs

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ private void _state_StateChanged(object sender, ParserStateEventArgs e)
121121

122122
if (newTarget != null)
123123
{
124-
UpdateCallsToOtherModule(newTarget.References);
124+
UpdateCallsToOtherModule(newTarget.References.ToList());
125125
RemoveField(newTarget);
126126
}
127127

@@ -273,13 +273,16 @@ private string RemoveExtraComma(string str, int numParams, int indexRemoved)
273273
return str.Remove(str.NthIndexOf(',', commaToRemove), 1);
274274
}
275275

276-
private void UpdateCallsToOtherModule(IEnumerable<IdentifierReference> references)
276+
private void UpdateCallsToOtherModule(List<IdentifierReference> references)
277277
{
278-
var identifierReferences = references.ToList();
278+
if (!references.Any())
279+
{
280+
return;
281+
}
279282

280-
var module = identifierReferences[0].QualifiedModuleName.Component.CodeModule;
283+
var module = references[0].QualifiedModuleName.Component.CodeModule;
281284

282-
foreach (var reference in identifierReferences.OrderByDescending(o => o.Selection.StartLine).ThenByDescending(t => t.Selection.StartColumn))
285+
foreach (var reference in references.OrderByDescending(o => o.Selection.StartLine).ThenByDescending(t => t.Selection.StartColumn))
283286
{
284287
var parent = reference.Context.Parent;
285288
while (!(parent is VBAParser.MemberAccessExprContext))

0 commit comments

Comments
 (0)