Skip to content

Commit 6910972

Browse files
committed
fix merge faceplants.
1 parent 414c059 commit 6910972

File tree

4 files changed

+9
-39
lines changed

4 files changed

+9
-39
lines changed

Rubberduck.Core/UI/Settings/SettingsForm.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public SettingsForm(IGeneralConfigService configService,
5353
},
5454
new SettingsView
5555
{
56-
Control = new UnitTestSettings(viewModelFactory.Create<Rubberduck.Settings.UnitTestSettings>(config)),
56+
Control = new UnitTestSettings(viewModelFactory.Create<Rubberduck.UnitTesting.Settings.UnitTestSettings>(config)),
5757
View = SettingsViews.UnitTestSettings
5858
},
5959
new SettingsView

Rubberduck.Core/UI/Settings/UnitTestSettingsViewModel.cs

Lines changed: 4 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77

88
namespace Rubberduck.UI.Settings
99
{
10-
public sealed class UnitTestSettingsViewModel : SettingsViewModelBase<Rubberduck.Settings.UnitTestSettings>, ISettingsViewModel<Rubberduck.Settings.UnitTestSettings>
10+
public sealed class UnitTestSettingsViewModel : SettingsViewModelBase<Rubberduck.UnitTesting.Settings.UnitTestSettings>, ISettingsViewModel<Rubberduck.UnitTesting.Settings.UnitTestSettings>
1111
{
12-
public UnitTestSettingsViewModel(Configuration config, IFilePersistanceService<Rubberduck.Settings.UnitTestSettings> service)
12+
public UnitTestSettingsViewModel(Configuration config, IFilePersistanceService<Rubberduck.UnitTesting.Settings.UnitTestSettings> service)
1313
: base(service)
1414
{
1515
BindingMode = config.UserSettings.UnitTestSettings.BindingMode;
@@ -18,7 +18,7 @@ public UnitTestSettingsViewModel(Configuration config, IFilePersistanceService<R
1818
MethodInit = config.UserSettings.UnitTestSettings.MethodInit;
1919
DefaultTestStubInNewModule = config.UserSettings.UnitTestSettings.DefaultTestStubInNewModule;
2020
ExportButtonCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(),
21-
_ => ExportSettings(new Rubberduck.Settings.UnitTestSettings(BindingMode, AssertMode, ModuleInit,
21+
_ => ExportSettings(new Rubberduck.UnitTesting.Settings.UnitTestSettings(BindingMode, AssertMode, ModuleInit,
2222
MethodInit, DefaultTestStubInNewModule)));
2323
ImportButtonCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), _ => ImportSettings());
2424
}
@@ -114,44 +114,13 @@ public void SetToDefaults(Configuration config)
114114

115115
protected override string DialogLoadTitle => SettingsUI.DialogCaption_LoadUnitTestSettings;
116116
protected override string DialogSaveTitle => SettingsUI.DialogCaption_SaveUnitTestSettings;
117-
protected override void TransferSettingsToView(Rubberduck.Settings.UnitTestSettings toLoad)
117+
protected override void TransferSettingsToView(Rubberduck.UnitTesting.Settings.UnitTestSettings toLoad)
118118
{
119119
BindingMode = toLoad.BindingMode;
120120
AssertMode = toLoad.AssertMode;
121121
ModuleInit = toLoad.ModuleInit;
122122
MethodInit = toLoad.MethodInit;
123123
DefaultTestStubInNewModule = toLoad.DefaultTestStubInNewModule;
124124
}
125-
126-
private void ImportSettings()
127-
{
128-
using (var dialog = new OpenFileDialog
129-
{
130-
Filter = SettingsUI.DialogMask_XmlFilesOnly,
131-
Title = SettingsUI.DialogCaption_LoadUnitTestSettings
132-
})
133-
{
134-
dialog.ShowDialog();
135-
if (string.IsNullOrEmpty(dialog.FileName)) return;
136-
var service = new XmlPersistanceService<Rubberduck.UnitTesting.Settings.UnitTestSettings> { FilePath = dialog.FileName };
137-
var loaded = service.Load(new Rubberduck.UnitTesting.Settings.UnitTestSettings());
138-
TransferSettingsToView(loaded);
139-
}
140-
}
141-
142-
private void ExportSettings()
143-
{
144-
using (var dialog = new SaveFileDialog
145-
{
146-
Filter = SettingsUI.DialogMask_XmlFilesOnly,
147-
Title = SettingsUI.DialogCaption_SaveUnitTestSettings
148-
})
149-
{
150-
dialog.ShowDialog();
151-
if (string.IsNullOrEmpty(dialog.FileName)) return;
152-
var service = new XmlPersistanceService<Rubberduck.UnitTesting.Settings.UnitTestSettings> { FilePath = dialog.FileName };
153-
service.Save(new Rubberduck.UnitTesting.Settings.UnitTestSettings(BindingMode, AssertMode, ModuleInit, MethodInit, DefaultTestStubInNewModule));
154-
}
155-
}
156125
}
157126
}

Rubberduck.Core/UI/UnitTesting/TestExplorerViewModel.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
using Rubberduck.UI.UnitTesting.ViewModels;
1616
using Rubberduck.UnitTesting;
1717
using Rubberduck.VBEditor.ComManagement;
18+
using Rubberduck.VBEditor.Utility;
1819
using DataFormats = System.Windows.DataFormats;
1920

2021
namespace Rubberduck.UI.UnitTesting
@@ -32,7 +33,7 @@ internal sealed class TestExplorerViewModel : ViewModelBase, INavigateSelection,
3233
private readonly IClipboardWriter _clipboard;
3334
private readonly ISettingsFormFactory _settingsFormFactory;
3435

35-
public TestExplorerViewModel(IProjectsProvider projectsProvider,
36+
public TestExplorerViewModel(ISelectionService selectionService,
3637
TestExplorerModel model,
3738
IClipboardWriter clipboard,
3839
// ReSharper disable once UnusedParameter.Local - left in place because it will likely be needed for app wide font settings, etc.
@@ -42,7 +43,7 @@ public TestExplorerViewModel(IProjectsProvider projectsProvider,
4243
_clipboard = clipboard;
4344
_settingsFormFactory = settingsFormFactory;
4445

45-
NavigateCommand = new NavigateCommand(projectsProvider);
46+
NavigateCommand = new NavigateCommand(selectionService);
4647
RunSingleTestCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteSingleTestCommand, CanExecuteSingleTest);
4748
RunSelectedTestsCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteSelectedTestsCommand, CanExecuteSelectedTestsCommand);
4849
RunSelectedGroupCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteRunSelectedGroupCommand, CanExecuteSelectedGroupCommand);

RubberduckTests/UnitTesting/MockedTestExplorer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public MockedTestExplorer(MockedTestExplorerModel model)
1414
Vbe = model.Engine.Vbe.Object;
1515
State = model.Engine.ParserState;
1616
Model = model.Model;
17-
ViewModel = new TestExplorerViewModel(State.ProjectsProvider, Model, ClipboardWriter.Object, null, null);
17+
ViewModel = new TestExplorerViewModel(null, Model, ClipboardWriter.Object, null, null);
1818
}
1919

2020
public RubberduckParserState State { get; set; }

0 commit comments

Comments
 (0)