Refresh CE and TE after declarations are resolved, rather than waiting for inspections and reference resolving. Prevent reparse without changes from firing Ready when state is Error.

Author: Hosch250

RetailCoder.VBE/Navigation/CodeExplorer/CodeExplorerViewModel.cs

@@ -245,36 +245,39 @@ public ObservableCollection<CodeExplorerItemViewModel> Projects
 
         private void ParserState_StateChanged(object sender, EventArgs e)
         {
-            if (Projects == null)
+            UiDispatcher.InvokeAsync(() =>
             {
-                Projects = new ObservableCollection<CodeExplorerItemViewModel>();
-            }
+                if (Projects == null)
+                {
+                    Projects = new ObservableCollection<CodeExplorerItemViewModel>();
+                }
 
-            IsBusy = _state.Status == ParserState.Parsing;
-            if (_state.Status != ParserState.Ready)
-            {
-                return;
-            }
-            
-            var userDeclarations = _state.AllUserDeclarations
-                .GroupBy(declaration => declaration.Project)
-                .Where(grouping => grouping.Key != null)
-                .ToList();
+                IsBusy = _state.Status < ParserState.ResolvedDeclarations;
+                if (_state.Status != ParserState.ResolvedDeclarations)
+                {
+                    return;
+                }
 
-            if (userDeclarations.Any(
+                var userDeclarations = _state.AllUserDeclarations
+                    .GroupBy(declaration => declaration.Project)
+                    .Where(grouping => grouping.Key != null)
+                    .ToList();
+
+                if (userDeclarations.Any(
                     grouping => grouping.All(declaration => declaration.DeclarationType != DeclarationType.Project)))
-            {
-                return;
-            }
+                {
+                    return;
+                }
 
-            var newProjects = userDeclarations.Select(grouping =>
-                new CodeExplorerProjectViewModel(_folderHelper,
-                    grouping.SingleOrDefault(declaration => declaration.DeclarationType == DeclarationType.Project),
-                    grouping)).ToList();
+                var newProjects = userDeclarations.Select(grouping =>
+                    new CodeExplorerProjectViewModel(_folderHelper,
+                        grouping.SingleOrDefault(declaration => declaration.DeclarationType == DeclarationType.Project),
+                        grouping)).ToList();
 
-            UpdateNodes(Projects, newProjects);
-            
-            Projects = new ObservableCollection<CodeExplorerItemViewModel>(newProjects);
+                UpdateNodes(Projects, newProjects);
+
+                Projects = new ObservableCollection<CodeExplorerItemViewModel>(newProjects);
+            });
         }
 
         private void UpdateNodes(IEnumerable<CodeExplorerItemViewModel> oldList,

RetailCoder.VBE/UI/Command/MenuItems/RubberduckCommandBar.cs

@@ -94,7 +94,11 @@ private void SetSelectionText(QualifiedSelection selection)
         private void State_StateChanged(object sender, EventArgs e)
         {
             _logger.Debug("RubberduckCommandBar handles StateChanged...");
-            SetStatusText(RubberduckUI.ResourceManager.GetString("ParserState_" + _state.Status));
+            
+            if (_state.Status != ParserState.ResolvedDeclarations)
+            {
+                SetStatusText(RubberduckUI.ResourceManager.GetString("ParserState_" + _state.Status));
+            }
         }
 
         public event EventHandler Refresh;

RetailCoder.VBE/UI/UnitTesting/TestExplorerModel.cs

@@ -26,18 +26,17 @@ public TestExplorerModel(VBE vbe, RubberduckParserState state)
 
         private void State_StateChanged(object sender, ParserStateEventArgs e)
         {
-            if (e.State != ParserState.Ready) { return; }
-
-            var tests = UnitTestHelpers.GetAllTests(_vbe, _state).ToList();
-
-            var removedTests = Tests.Where(test =>
-                         !tests.Any(t =>
-                                 t.Declaration.ComponentName == test.Declaration.ComponentName &&
-                                 t.Declaration.IdentifierName == test.Declaration.IdentifierName &&
-                                 t.Declaration.ProjectId == test.Declaration.ProjectId)).ToList();
+            if (e.State != ParserState.ResolvedDeclarations) { return; }
 
             _dispatcher.Invoke(() =>
             {
+                var tests = UnitTestHelpers.GetAllTests(_vbe, _state).ToList();
+
+                var removedTests = Tests.Where(test =>
+                             !tests.Any(t =>
+                                     t.Declaration.ComponentName == test.Declaration.ComponentName &&
+                                     t.Declaration.IdentifierName == test.Declaration.IdentifierName &&
+                                     t.Declaration.ProjectId == test.Declaration.ProjectId)).ToList();
 
                 // remove old tests
                 foreach (var test in removedTests)

Rubberduck.Parsing/VBA/ParserState.cs

@@ -24,6 +24,10 @@ public enum ParserState
         /// </summary>
         Resolving,
         /// <summary>
+        /// Resolving identifier references.
+        /// </summary>
+        ResolvedDeclarations,
+        /// <summary>
         /// Parser state is in sync with the actual code in the VBE.
         /// </summary>
         Ready,

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -143,7 +143,7 @@ private void ParseAll()
 
             if (!toParse.Any())
             {
-                State.SetStatusAndFireStateChanged(ParserState.Ready);
+                State.SetStatusAndFireStateChanged(_state.Status);
                 return;
             }
 
@@ -496,6 +496,8 @@ private void ResolveInternal(CancellationToken token)
                 ResolveDeclarations(qualifiedName.Component, kvp.Value);
             }
 
+            _state.SetStatusAndFireStateChanged(ParserState.ResolvedDeclarations);
+
             // walk all parse trees (modified or not) for identifier references
             var finder = new DeclarationFinder(_state.AllDeclarations, _state.AllComments, _state.AllAnnotations);
             var passes = new List<ICompilationPass>