Merge branch 'next' of https://github.com/rubberduck-vba/Rubberduck into interpreter

Author: Andrin Meier

RetailCoder.VBE/App.cs

@@ -15,7 +15,6 @@
 using Rubberduck.SmartIndenter;
 using Rubberduck.UI;
 using Rubberduck.UI.Command.MenuItems;
-using Rubberduck.VBEditor.Extensions;
 using Infralution.Localization.Wpf;
 using Rubberduck.Common.Dispatch;
 
@@ -99,7 +98,7 @@ async void sink_ProjectAdded(object sender, DispatcherEventArgs<VBProject> e)
         {
             Debug.WriteLine(string.Format("Project '{0}' was added.", e.Item.Name));
             var connectionPointContainer = (IConnectionPointContainer)e.Item.VBComponents;
-            Guid interfaceId = typeof(_dispVBComponentsEvents).GUID;
+            var interfaceId = typeof(_dispVBComponentsEvents).GUID;
 
             IConnectionPoint connectionPoint;
             connectionPointContainer.FindConnectionPoint(ref interfaceId, out connectionPoint);
@@ -128,6 +127,7 @@ async void sink_ComponentSelected(object sender, DispatcherEventArgs<VBComponent
         async void sink_ComponentRenamed(object sender, DispatcherRenamedEventArgs<VBComponent> e)
         {
             Debug.WriteLine(string.Format("Component '{0}' was renamed.", e.Item.Name));
+
             _parser.State.ClearDeclarations(e.Item);
             _parser.State.OnParseRequested(e.Item);
         }

RetailCoder.VBE/Inspections/ImplicitActiveSheetReferenceInspection.cs

@@ -37,10 +37,11 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
                 // if host isn't Excel, the ExcelObjectModel declarations shouldn't be loaded anyway.
             }
 
-            var issues = Declarations.Where(item => item.IsBuiltIn 
-                && item.ParentScope == "Excel.Global"
-                && Targets.Contains(item.IdentifierName)
-                && item.References.Any())
+            var matches = BuiltInDeclarations.Where(item =>
+                (item.ParentScope == "Excel.Global" || item.ParentScope == "Excel.Application")
+                && Targets.Contains(item.IdentifierName)).ToList();
+
+            var issues = matches.Where(item => item.References.Any())
                 .SelectMany(declaration => declaration.References);
 
             return issues.Select(issue => 

RetailCoder.VBE/Inspections/InspectionBase.cs

@@ -74,6 +74,11 @@ protected virtual IEnumerable<Declaration> Declarations
             get { return State.AllDeclarations.Where(declaration => !declaration.IsInspectionDisabled(AnnotationName)); }
         }
 
+        protected virtual IEnumerable<Declaration> BuiltInDeclarations
+        {
+            get { return State.AllDeclarations.Where(declaration => declaration.IsBuiltIn); }
+        }
+
         /// <summary>
         /// Gets all user declarations in the parser state without an @Ignore annotation for this inspection.
         /// </summary>

RetailCoder.VBE/Inspections/InspectionsUI.Designer.cs

@@ -166,13 +166,13 @@
     <value>Ignore once</value>
   </data>
   <data name="ImplicitActiveSheetReferenceInspectionMeta" xml:space="preserve">
-    <value>Implicit references to the active sheet make the code frail and harder to debug. Consider making these references explicit when they're intended, and prefer working off object references.</value>
+    <value>Implicit references to the active sheet make the code frail and harder to debug. Consider making these references explicit when they're intended, and prefer working off object references. Ignore if the member call is referring to a type Rubberduck can't resolve.</value>
   </data>
   <data name="ImplicitActiveSheetReferenceInspectionName" xml:space="preserve">
     <value>Implicit reference to ActiveSheet</value>
   </data>
   <data name="ImplicitActiveWorkbookReferenceInspectionMeta" xml:space="preserve">
-    <value>Implicit references to the active workbook make the code frail and harder to debug. Consider making these references explicit when they're intended, and prefer working off object references.</value>
+    <value>Implicit references to the active workbook make the code frail and harder to debug. Consider making these references explicit when they're intended, and prefer working off object references. Ignore if the member call is referring to a type Rubberduck can't resolve.</value>
   </data>
   <data name="ImplicitActiveWorkbookReferenceInspectionName" xml:space="preserve">
     <value>Implicit reference to ActiveWorkbook</value>
@@ -274,7 +274,7 @@
     <value>'Option Base 1' is specified</value>
   </data>
   <data name="OptionExplicitInspectionMeta" xml:space="preserve">
-    <value>Rubberduck cannot see variables that aren't declared. VBA will happily compile a typo and you'll soon be asking an embarassing question on Stack Overflow. Avoid problems, use 'Option Explicit'. </value>
+    <value>Rubberduck cannot see variables that aren't declared. VBA will happily compile a typo: use 'Option Explicit' to prevent successfully compiling an erroneous program.</value>
   </data>
   <data name="OptionExplicitInspectionName" xml:space="preserve">
     <value>'Option Explicit' is not specified</value>
@@ -497,4 +497,7 @@
   <data name="VariableNotAssignedInspectionResultFormat" xml:space="preserve">
     <value>Variable '{0}' is never assigned</value>
   </data>
+  <data name="DisableThisInspection" xml:space="preserve">
+    <value>Disable this inspection</value>
+  </data>
 </root>

RetailCoder.VBE/Inspections/InspectionsUI.resx

@@ -25,7 +25,7 @@ where p.Context.GetSelection().LineCount > 1
                 select p;
 
             var issues = multilineParameters
-                .Select(param => new MultilineParameterInspectionResult(this, param.Context, param.QualifiedName));
+                .Select(param => new MultilineParameterInspectionResult(this, param));
 
             return issues;
         }

RetailCoder.VBE/Inspections/MultilineParameterInspection.cs

@@ -1,17 +1,16 @@
 using System.Collections.Generic;
-using Antlr4.Runtime;
 using Rubberduck.Parsing;
+using Rubberduck.Parsing.Symbols;
 using Rubberduck.UI;
-using Rubberduck.VBEditor;
 
 namespace Rubberduck.Inspections
 {
     public class MultilineParameterInspectionResult : InspectionResultBase
     {
         private readonly IEnumerable<CodeInspectionQuickFix> _quickFixes;
 
-        public MultilineParameterInspectionResult(IInspection inspection, ParserRuleContext context, QualifiedMemberName qualifiedName)
-            : base(inspection, qualifiedName.QualifiedModuleName, context)
+        public MultilineParameterInspectionResult(IInspection inspection, Declaration target)
+            : base(inspection, target)
         {
             _quickFixes = new[]
             {

RetailCoder.VBE/Inspections/MultilineParameterInspectionResult.cs

@@ -42,9 +42,10 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
                 handlers.AddRange(forms.SelectMany(form => declarations.FindFormEventHandlers(form)));
             }
 
-            var issues = declarations
-                .Where(item => !IsIgnoredDeclaration(declarations, item, handlers, classes, modules))
-                .Select(issue => new IdentifierNotUsedInspectionResult(this, issue, issue.Context, issue.QualifiedName.QualifiedModuleName));
+            var items = declarations
+                .Where(item => !IsIgnoredDeclaration(declarations, item, handlers, classes, modules)
+                            && !item.IsInspectionDisabled(AnnotationName)).ToList();
+            var issues = items.Select(issue => new IdentifierNotUsedInspectionResult(this, issue, issue.Context, issue.QualifiedName.QualifiedModuleName));
 
             issues = DocumentNames.DocumentEventHandlerPrefixes.Aggregate(issues, (current, item) => current.Where(issue => !issue.Description.Contains("'" + item)));
 

RetailCoder.VBE/Inspections/ProcedureNotUsedInspection.cs

@@ -2,10 +2,8 @@
 using System.Diagnostics;
 using System.Linq;
 using System.Windows.Input;
-using System.Windows.Media.Imaging;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
-using Rubberduck.Properties;
 using Rubberduck.UI;
 using Rubberduck.UI.Command;
 
@@ -80,7 +78,7 @@ public ObservableCollection<CodeExplorerProjectViewModel> Projects
         private void ParserState_StateChanged(object sender, ParserStateEventArgs e)
         {
             IsBusy = e.State == ParserState.Parsing;
-            if (e.State != ParserState.Parsed) 
+            if (e.State < ParserState.Parsed) 
             {
                 return;
             }

RetailCoder.VBE/Navigation/CodeExplorer/CodeExplorerViewModel.cs

@@ -120,7 +120,7 @@
 
         <Style x:Key="CodeExplorerTreeViewStyle" TargetType="TreeView">
             <Setter Property="ItemTemplate" Value="{StaticResource CodeExplorerTemplate}" />
-            <Setter Property="ItemsSource" Value="{Binding Projects}" />
+            <Setter Property="ItemsSource" Value="{Binding Projects, UpdateSourceTrigger=PropertyChanged}" />
         </Style>
 
     </UserControl.Resources>