Add allowed argument types to IAnnotation

MDoerner · MDoerner · commit 6710770530a4 · 2020-04-16T00:17:30.000+02:00
There has to be at least one per required argument. All optional arguments have the last allowed type in the list.
diff --git a/Rubberduck.Core/UI/Controls/FindAllReferencesService.cs b/Rubberduck.Core/UI/Controls/FindAllReferencesService.cs
@@ -22,9 +22,13 @@ public class FindAllReferencesService : IDisposable
         private readonly SearchResultPresenterInstanceManager _presenterService;
         private readonly IUiDispatcher _uiDispatcher;
 
-        public FindAllReferencesService(INavigateCommand navigateCommand, IMessageBox messageBox,
-            RubberduckParserState state, ISearchResultsWindowViewModel viewModel,
-            SearchResultPresenterInstanceManager presenterService, IUiDispatcher uiDispatcher)
+        public FindAllReferencesService(
+            INavigateCommand navigateCommand, 
+            IMessageBox messageBox,
+            RubberduckParserState state, 
+            ISearchResultsWindowViewModel viewModel,
+            SearchResultPresenterInstanceManager presenterService, 
+            IUiDispatcher uiDispatcher)
         {
             _navigateCommand = navigateCommand;
             _messageBox = messageBox;
diff --git a/Rubberduck.Parsing/Annotations/AnnotationBase.cs b/Rubberduck.Parsing/Annotations/AnnotationBase.cs
@@ -8,16 +8,18 @@ public abstract class AnnotationBase : IAnnotation
         public bool AllowMultiple { get; }
         public int RequiredArguments { get; }
         public int? AllowedArguments { get; }
+        public IReadOnlyList<AnnotationArgumentType> AllowedArgumentTypes { get; }
         public string Name { get; }
         public AnnotationTarget Target { get; }
 
-        protected AnnotationBase(string name, AnnotationTarget target, int requiredArguments = 0, int? allowedArguments = 0, bool allowMultiple = false)
+        protected AnnotationBase(string name, AnnotationTarget target, int requiredArguments = 0, int? allowedArguments = 0, IReadOnlyList<AnnotationArgumentType> allowedArgumentTypes = null, bool allowMultiple = false)
         {
             Name = name;
             Target = target;
             AllowMultiple = allowMultiple;
             RequiredArguments = requiredArguments;
             AllowedArguments = allowedArguments;
+            AllowedArgumentTypes = allowedArgumentTypes ?? new List<AnnotationArgumentType>();
         }
 
         public virtual IReadOnlyList<string> ProcessAnnotationArguments(IEnumerable<string> arguments)
diff --git a/Rubberduck.Parsing/Annotations/Concrete/DefaultMemberAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/DefaultMemberAnnotation.cs
@@ -1,7 +1,3 @@
-using System.Collections.Generic;
-using System.Linq;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
 using Rubberduck.Resources.Registration;
 
 namespace Rubberduck.Parsing.Annotations
@@ -13,7 +9,6 @@ public sealed class DefaultMemberAnnotation : FixedAttributeValueAnnotationBase
     {
         public DefaultMemberAnnotation()
             : base("DefaultMember", AnnotationTarget.Member, "VB_UserMemId", new[] { WellKnownDispIds.Value.ToString() })
-        {
-        }
+        {}
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/Concrete/DescriptionAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/DescriptionAnnotation.cs
@@ -1,16 +1,12 @@
-﻿using System.Collections.Generic;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
-
-namespace Rubberduck.Parsing.Annotations
+﻿namespace Rubberduck.Parsing.Annotations
 {
     /// <summary>
     /// Used for specifying a member's <c>VB_Description</c> attribute.
     /// </summary>
     public sealed class DescriptionAnnotation : DescriptionAttributeAnnotationBase
     {
         public DescriptionAnnotation()
-            : base("Description", AnnotationTarget.Member, "VB_Description", 1)
+            : base("Description", AnnotationTarget.Member, "VB_Description")
         {}
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/Concrete/DescriptionAttributeAnnotationBase.cs b/Rubberduck.Parsing/Annotations/Concrete/DescriptionAttributeAnnotationBase.cs
@@ -1,14 +1,11 @@
 ﻿using System.Collections.Generic;
-using System.Linq;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
 
 namespace Rubberduck.Parsing.Annotations
 {
     public abstract class DescriptionAttributeAnnotationBase : FlexibleAttributeValueAnnotationBase
     {
-        public DescriptionAttributeAnnotationBase(string name, AnnotationTarget target, string attribute, int valueCount)
-            : base(name, target, attribute, valueCount)
-        { }
+        public DescriptionAttributeAnnotationBase(string name, AnnotationTarget target, string attribute)
+            : base(name, target, attribute, 1, new List<AnnotationArgumentType> { AnnotationArgumentType.Text })
+        {}
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/Concrete/EnumeratorMemberAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/EnumeratorMemberAnnotation.cs
@@ -1,6 +1,3 @@
-using System.Collections.Generic;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
 using Rubberduck.Resources.Registration;
 
 namespace Rubberduck.Parsing.Annotations
diff --git a/Rubberduck.Parsing/Annotations/Concrete/ExcelHotKeyAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/ExcelHotKeyAnnotation.cs
@@ -1,17 +1,14 @@
-﻿using System;
-using System.Collections.Generic;
+﻿using System.Collections.Generic;
 using System.Linq;
 using Rubberduck.Common;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
 
 namespace Rubberduck.Parsing.Annotations
 {
     public sealed class ExcelHotKeyAnnotation : FlexibleAttributeValueAnnotationBase
     {
         public ExcelHotKeyAnnotation()
-            : base("ExcelHotkey", AnnotationTarget.Member, "VB_ProcData.VB_Invoke_Func", 1)
-        { }
+            : base("ExcelHotkey", AnnotationTarget.Member, "VB_ProcData.VB_Invoke_Func", 1, new[] { AnnotationArgumentType.Text})
+        {}
 
         public override IReadOnlyList<string> AnnotationToAttributeValues(IReadOnlyList<string> annotationValues)
         {
diff --git a/Rubberduck.Parsing/Annotations/Concrete/ExposedModuleAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/ExposedModuleAnnotation.cs
@@ -1,7 +1,3 @@
-using System.Collections.Generic;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
-
 namespace Rubberduck.Parsing.Annotations
 {
     /// <summary>
diff --git a/Rubberduck.Parsing/Annotations/Concrete/FlexibleAttributeAnnotationBase.cs b/Rubberduck.Parsing/Annotations/Concrete/FlexibleAttributeAnnotationBase.cs
@@ -6,8 +6,8 @@ namespace Rubberduck.Parsing.Annotations
 {
     public abstract class FlexibleAttributeAnnotationBase : AnnotationBase, IAttributeAnnotation
     {
-        protected FlexibleAttributeAnnotationBase(string name, AnnotationTarget target, bool allowMultiple = false)
-            : base(name, target, 2, null, allowMultiple) //We need at least the attribute name and one value for it.
+        protected FlexibleAttributeAnnotationBase(string name, AnnotationTarget target, IReadOnlyList<AnnotationArgumentType> allowedArgumentType, bool allowMultiple = false)
+            : base(name, target, 2, null, allowedArgumentType, allowMultiple) //We need at least the attribute name and one value for it.
         {}
         
         public IReadOnlyList<string> AnnotationToAttributeValues(IReadOnlyList<string> annotationValues)
diff --git a/Rubberduck.Parsing/Annotations/Concrete/FlexibleAttributeValueAnnotationBase.cs b/Rubberduck.Parsing/Annotations/Concrete/FlexibleAttributeValueAnnotationBase.cs
@@ -9,7 +9,7 @@ public abstract class FlexibleAttributeValueAnnotationBase : AnnotationBase, IAt
         private readonly string _attribute;
         private readonly int _numberOfValues;
 
-        protected FlexibleAttributeValueAnnotationBase(string name, AnnotationTarget target, string attribute, int numberOfValues)
+        protected FlexibleAttributeValueAnnotationBase(string name, AnnotationTarget target, string attribute, int numberOfValues, IReadOnlyList<AnnotationArgumentType> argumentTypes)
             : base(name, target, numberOfValues, numberOfValues)
         {
             _attribute = attribute;
diff --git a/Rubberduck.Parsing/Annotations/Concrete/FolderAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/FolderAnnotation.cs
@@ -6,7 +6,7 @@
     public sealed class FolderAnnotation : AnnotationBase
     {
         public FolderAnnotation()
-            : base("Folder", AnnotationTarget.Module, 1, 1)
+            : base("Folder", AnnotationTarget.Module, 1, 1, new[] { AnnotationArgumentType.Text})
         {}
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/Concrete/IgnoreAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/IgnoreAnnotation.cs
@@ -6,7 +6,7 @@
     public sealed class IgnoreAnnotation : AnnotationBase
     {
         public IgnoreAnnotation()
-            : base("Ignore", AnnotationTarget.General, 1, null, true)
+            : base("Ignore", AnnotationTarget.General, 1, null, new[] { AnnotationArgumentType.Inspection}, true)
         {}
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/Concrete/IgnoreModuleAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/IgnoreModuleAnnotation.cs
@@ -6,7 +6,7 @@
     public sealed class IgnoreModuleAnnotation : AnnotationBase
     {
         public IgnoreModuleAnnotation()
-            : base("IgnoreModule", AnnotationTarget.Module, allowedArguments: null, allowMultiple: true)
+            : base("IgnoreModule", AnnotationTarget.Module, allowedArguments: null, allowedArgumentTypes: new[] { AnnotationArgumentType.Inspection }, allowMultiple: true)
         {}
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/Concrete/IgnoreTestAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/IgnoreTestAnnotation.cs
@@ -6,7 +6,7 @@
     public sealed class IgnoreTestAnnotation : AnnotationBase
     {
         public IgnoreTestAnnotation()
-            : base("IgnoreTest", AnnotationTarget.Member, allowedArguments: 1)
+            : base("IgnoreTest", AnnotationTarget.Member, allowedArguments: 1, allowedArgumentTypes: new []{AnnotationArgumentType.Text})
         {}
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/Concrete/MemberAttributeAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/MemberAttributeAnnotation.cs
@@ -1,8 +1,4 @@
-﻿using System.Collections.Generic;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
-
-namespace Rubberduck.Parsing.Annotations
+﻿namespace Rubberduck.Parsing.Annotations
 {
     /// <summary>
     /// This annotation allows the specification of arbitrary VB_Attribute entries for members.
@@ -14,7 +10,13 @@ namespace Rubberduck.Parsing.Annotations
     public class MemberAttributeAnnotation : FlexibleAttributeAnnotationBase
     {
         public MemberAttributeAnnotation()
-            : base("MemberAttribute", AnnotationTarget.Member | AnnotationTarget.Variable)
+            : base("MemberAttribute", AnnotationTarget.Member | AnnotationTarget.Variable, _argumentTypes)
         {}
+
+        private static AnnotationArgumentType[] _argumentTypes = new[]
+        {
+            AnnotationArgumentType.Attribute,
+            AnnotationArgumentType.Text | AnnotationArgumentType.Number | AnnotationArgumentType.Boolean
+        };
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/Concrete/ModuleAttributeAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/ModuleAttributeAnnotation.cs
@@ -1,16 +1,18 @@
-﻿using System.Collections.Generic;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
-
-namespace Rubberduck.Parsing.Annotations
+﻿namespace Rubberduck.Parsing.Annotations
 {
     /// <summary>
     /// This annotation allows specifying arbitrary VB_Attribute entries.
     /// </summary>
     public class ModuleAttributeAnnotation : FlexibleAttributeAnnotationBase
     {
         public ModuleAttributeAnnotation() 
-        : base("ModuleAttribute", AnnotationTarget.Module)
+        : base("ModuleAttribute", AnnotationTarget.Module, _argumentTypes)
         {}
+
+        private static AnnotationArgumentType[] _argumentTypes = new[]
+        {
+            AnnotationArgumentType.Attribute,
+            AnnotationArgumentType.Text | AnnotationArgumentType.Number | AnnotationArgumentType.Boolean
+        };
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/Concrete/ModuleDescriptionAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/ModuleDescriptionAnnotation.cs
@@ -1,8 +1,4 @@
-﻿using System.Collections.Generic;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
-
-namespace Rubberduck.Parsing.Annotations
+﻿namespace Rubberduck.Parsing.Annotations
 {
     /// <summary>
     /// Used for specifying a module's <c>VB_Description</c> attribute.
@@ -13,7 +9,7 @@ namespace Rubberduck.Parsing.Annotations
     public sealed class ModuleDescriptionAnnotation : DescriptionAttributeAnnotationBase
     {
         public ModuleDescriptionAnnotation()
-            : base("ModuleDescription", AnnotationTarget.Module, "VB_Description", 1)
+            : base("ModuleDescription", AnnotationTarget.Module, "VB_Description")
         {}
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/Concrete/ObsoleteAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/ObsoleteAnnotation.cs
@@ -1,6 +1,5 @@
 ﻿using System.Collections.Generic;
 using System.Linq;
-using Rubberduck.Common;
 
 namespace Rubberduck.Parsing.Annotations
 {
@@ -12,7 +11,7 @@ public sealed class ObsoleteAnnotation : AnnotationBase
         public string ReplacementDocumentation { get; private set; }
 
         public ObsoleteAnnotation()
-            : base("Obsolete", AnnotationTarget.Member | AnnotationTarget.Variable, allowedArguments: 1)
+            : base("Obsolete", AnnotationTarget.Member | AnnotationTarget.Variable, allowedArguments: 1, allowedArgumentTypes: new [] {AnnotationArgumentType.Text})
         {}
 
         public override IReadOnlyList<string> ProcessAnnotationArguments(IEnumerable<string> arguments)
diff --git a/Rubberduck.Parsing/Annotations/Concrete/PredeclaredIdAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/PredeclaredIdAnnotation.cs
@@ -1,7 +1,3 @@
-using System.Collections.Generic;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
-
 namespace Rubberduck.Parsing.Annotations
 {
     /// <summary>
diff --git a/Rubberduck.Parsing/Annotations/Concrete/TestMethodAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/TestMethodAnnotation.cs
@@ -1,6 +1,5 @@
 ﻿using System.Collections.Generic;
 using System.Linq;
-using Rubberduck.Common;
 
 namespace Rubberduck.Parsing.Annotations
 {
@@ -10,7 +9,7 @@ namespace Rubberduck.Parsing.Annotations
     public sealed class TestMethodAnnotation : AnnotationBase, ITestAnnotation
     {
         public TestMethodAnnotation()
-            : base("TestMethod", AnnotationTarget.Member)
+            : base("TestMethod", AnnotationTarget.Member, allowedArguments: 1, allowedArgumentTypes: new []{AnnotationArgumentType.Text})
         {}
 
         public IReadOnlyList<string> ProcessAnnotationArguments(IEnumerable<string> arguments)
diff --git a/Rubberduck.Parsing/Annotations/Concrete/VariableDescriptionAnnotation.cs b/Rubberduck.Parsing/Annotations/Concrete/VariableDescriptionAnnotation.cs
@@ -1,13 +1,9 @@
-﻿using System.Collections.Generic;
-using Rubberduck.Parsing.Grammar;
-using Rubberduck.VBEditor;
-
-namespace Rubberduck.Parsing.Annotations
+﻿namespace Rubberduck.Parsing.Annotations
 {
     public class VariableDescriptionAnnotation : DescriptionAttributeAnnotationBase
     {
         public VariableDescriptionAnnotation()
-            : base("VariableDescription", AnnotationTarget.Variable, "VB_VarDescription", 1)
+            : base("VariableDescription", AnnotationTarget.Variable, "VB_VarDescription")
         {}
     }
 }
diff --git a/Rubberduck.Parsing/Annotations/IAnnotation.cs b/Rubberduck.Parsing/Annotations/IAnnotation.cs
@@ -27,6 +27,11 @@ public interface IAnnotation
         /// </summary>
         int? AllowedArguments { get; }
 
+        /// <summary>
+        /// The allowed types of arguments for the annotation. The last argument type is valid for all optional arguments.
+        /// </summary>
+        IReadOnlyList<AnnotationArgumentType> AllowedArgumentTypes { get; }
+
         IReadOnlyList<string> ProcessAnnotationArguments(IEnumerable<string> arguments);
     }
 
@@ -54,4 +59,29 @@ public enum AnnotationTarget
         /// </summary>
         General = Member | Variable | Identifier,
     }
+
+    [Flags]
+    public enum AnnotationArgumentType
+    {
+        /// <summary>
+        /// Indicates that the annotation argument can be a string.
+        /// </summary>
+        Text = 1 << 0,
+        /// <summary>
+        /// Indicates that the annotation argument can be a number.
+        /// </summary>
+        Number = 1 << 1,
+        /// <summary>
+        /// Indicates that the annotation argument can be a boolean.
+        /// </summary>
+        Boolean = 1 << 2,
+        /// <summary>
+        /// Indicates that the annotation argument can be an inspection name.
+        /// </summary>
+        Inspection = 1 << 3,
+        /// <summary>
+        /// Indicates that the annotation argument can be an attribute name.
+        /// </summary>
+        Attribute = 1 << 4
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,3 @@`
`1`		`-using System.Collections.Generic;`
`2`		`-using System.Linq;`
`3`		`-using Rubberduck.Parsing.Grammar;`
`4`		`-using Rubberduck.VBEditor;`
`5`	`1`	`using Rubberduck.Resources.Registration;`
`6`	`2`
`7`	`3`	`namespace Rubberduck.Parsing.Annotations`
`@@ -13,7 +9,6 @@ public sealed class DefaultMemberAnnotation : FixedAttributeValueAnnotationBase`
`13`	`9`	`{`
`14`	`10`	`public DefaultMemberAnnotation()`
`15`	`11`	`: base("DefaultMember", AnnotationTarget.Member, "VB_UserMemId", new[] { WellKnownDispIds.Value.ToString() })`
`16`		`- {`
`17`		`- }`
	`12`	`+ {}`
`18`	`13`	`}`
`19`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,16 +1,12 @@`
`1`		`-using System.Collections.Generic;`
`2`		`-using Rubberduck.Parsing.Grammar;`
`3`		`-using Rubberduck.VBEditor;`
`4`		`-`
`5`		`-namespace Rubberduck.Parsing.Annotations`
	`1`	`+namespace Rubberduck.Parsing.Annotations`
`6`	`2`	`{`
`7`	`3`	`/// <summary>`
`8`	`4`	`/// Used for specifying a member's <c>VB_Description</c> attribute.`
`9`	`5`	`/// </summary>`
`10`	`6`	`public sealed class DescriptionAnnotation : DescriptionAttributeAnnotationBase`
`11`	`7`	`{`
`12`	`8`	`public DescriptionAnnotation()`
`13`		`- : base("Description", AnnotationTarget.Member, "VB_Description", 1)`
	`9`	`+ : base("Description", AnnotationTarget.Member, "VB_Description")`
`14`	`10`	`{}`
`15`	`11`	`}`
`16`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,14 +1,11 @@`
`1`	`1`	`using System.Collections.Generic;`
`2`		`-using System.Linq;`
`3`		`-using Rubberduck.Parsing.Grammar;`
`4`		`-using Rubberduck.VBEditor;`
`5`	`2`
`6`	`3`	`namespace Rubberduck.Parsing.Annotations`
`7`	`4`	`{`
`8`	`5`	`public abstract class DescriptionAttributeAnnotationBase : FlexibleAttributeValueAnnotationBase`
`9`	`6`	`{`
`10`		`- public DescriptionAttributeAnnotationBase(string name, AnnotationTarget target, string attribute, int valueCount)`
`11`		`- : base(name, target, attribute, valueCount)`
`12`		`- { }`
	`7`	`+ public DescriptionAttributeAnnotationBase(string name, AnnotationTarget target, string attribute)`
	`8`	`+ : base(name, target, attribute, 1, new List<AnnotationArgumentType> { AnnotationArgumentType.Text })`
	`9`	`+ {}`
`13`	`10`	`}`
`14`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,17 +1,14 @@`
`1`		`-using System;`
`2`		`-using System.Collections.Generic;`
	`1`	`+using System.Collections.Generic;`
`3`	`2`	`using System.Linq;`
`4`	`3`	`using Rubberduck.Common;`
`5`		`-using Rubberduck.Parsing.Grammar;`
`6`		`-using Rubberduck.VBEditor;`
`7`	`4`
`8`	`5`	`namespace Rubberduck.Parsing.Annotations`
`9`	`6`	`{`
`10`	`7`	`public sealed class ExcelHotKeyAnnotation : FlexibleAttributeValueAnnotationBase`
`11`	`8`	`{`
`12`	`9`	`public ExcelHotKeyAnnotation()`
`13`		`- : base("ExcelHotkey", AnnotationTarget.Member, "VB_ProcData.VB_Invoke_Func", 1)`
`14`		`- { }`
	`10`	`+ : base("ExcelHotkey", AnnotationTarget.Member, "VB_ProcData.VB_Invoke_Func", 1, new[] { AnnotationArgumentType.Text})`
	`11`	`+ {}`
`15`	`12`
`16`	`13`	`public override IReadOnlyList<string> AnnotationToAttributeValues(IReadOnlyList<string> annotationValues)`
`17`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,8 @@ namespace Rubberduck.Parsing.Annotations`
`6`	`6`	`{`
`7`	`7`	`public abstract class FlexibleAttributeAnnotationBase : AnnotationBase, IAttributeAnnotation`
`8`	`8`	`{`
`9`		`- protected FlexibleAttributeAnnotationBase(string name, AnnotationTarget target, bool allowMultiple = false)`
`10`		`- : base(name, target, 2, null, allowMultiple) //We need at least the attribute name and one value for it.`
	`9`	`+ protected FlexibleAttributeAnnotationBase(string name, AnnotationTarget target, IReadOnlyList<AnnotationArgumentType> allowedArgumentType, bool allowMultiple = false)`
	`10`	`+ : base(name, target, 2, null, allowedArgumentType, allowMultiple) //We need at least the attribute name and one value for it.`
`11`	`11`	`{}`
`12`	`12`
`13`	`13`	`public IReadOnlyList<string> AnnotationToAttributeValues(IReadOnlyList<string> annotationValues)`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ public abstract class FlexibleAttributeValueAnnotationBase : AnnotationBase, IAt`
`9`	`9`	`private readonly string _attribute;`
`10`	`10`	`private readonly int _numberOfValues;`
`11`	`11`
`12`		`- protected FlexibleAttributeValueAnnotationBase(string name, AnnotationTarget target, string attribute, int numberOfValues)`
	`12`	`+ protected FlexibleAttributeValueAnnotationBase(string name, AnnotationTarget target, string attribute, int numberOfValues, IReadOnlyList<AnnotationArgumentType> argumentTypes)`
`13`	`13`	`: base(name, target, numberOfValues, numberOfValues)`
`14`	`14`	`{`
`15`	`15`	`_attribute = attribute;`