fixed sticky built-in declarations' identifier references

Author: retailcoder

Rubberduck.Parsing/Symbols/Declaration.cs

@@ -562,7 +562,11 @@ public override int GetHashCode()
 
         public void ClearReferences()
         {
-            _references = new ConcurrentBag<IdentifierReference>();
+            while (!_references.IsEmpty)
+            {
+                IdentifierReference reference;
+                _references.TryTake(out reference);
+            }
         }
     }
 }

Rubberduck.Parsing/VBA/RubberduckParser.cs

@@ -92,6 +92,10 @@ private void ParseInternal()
             {
                 AddDeclarationsFromProjectReferences(projects);
             }
+            else
+            {
+                _state.ClearBuiltInReferences();
+            }
 
             var components = projects
                 .SelectMany(project => project.VBComponents.Cast<VBComponent>())
@@ -264,8 +268,6 @@ private void Resolve(DeclarationFinder finder)
         {
             try
             {
-                //Parallel.ForEach(_state.AllDeclarations, declaration => declaration.ClearReferences());
-
                 foreach (var kvp in _state.ParseTrees)
                 {
                     ResolveReferences(finder, kvp.Key, kvp.Value);

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -291,6 +291,14 @@ public void ClearDeclarations(VBProject project)
             }
         }
 
+        public void ClearBuiltInReferences()
+        {
+            foreach (var item in AllDeclarations.Where(item => item.IsBuiltIn && item.References.Any()))
+            {
+                item.ClearReferences();
+            }
+        }
+
         public bool ClearDeclarations(VBComponent component)
         {
             var project = component.Collection.Parent;