Initialize commands in constructor

To keep all string properties together, I also moved
AboutCopyright above the commands.

Author: fernandreu

Rubberduck.Core/UI/About/AboutControlViewModel.cs

@@ -17,6 +17,9 @@ public class AboutControlViewModel
         public AboutControlViewModel(IVersionCheck version)
         {
             _version = version;
+
+            UriCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteUri);
+            ViewLogCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), ExecuteViewLog);
         }
 
         public string Version => string.Format(Resources.RubberduckUI.Rubberduck_AboutBuild, _version.CurrentVersion);
@@ -32,46 +35,28 @@ public AboutControlViewModel(IVersionCheck version)
         public string HostExecutable => string.Format(AboutUI.AboutWindow_HostExecutable,
             Path.GetFileName(Application.ExecutablePath).ToUpper()); // .ToUpper() used to convert ExceL.EXE -> EXCEL.EXE
 
-        private CommandBase _uriCommand;
-        public CommandBase UriCommand
+        public string AboutCopyright =>
+            string.Format(AboutUI.AboutWindow_Copyright, DateTime.Now.Year);
+
+        public CommandBase UriCommand { get; }
+
+        public CommandBase ViewLogCommand { get; }
+
+        private void ExecuteUri(object parameter)
         {
-            get
-            {
-                if (_uriCommand != null)
-                {
-                    return _uriCommand;
-                }
-                return _uriCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), uri =>
-                {
-                    Process.Start(new ProcessStartInfo(((Uri)uri).AbsoluteUri));
-                });
-            }
+            Process.Start(new ProcessStartInfo(((Uri)parameter).AbsoluteUri));
         }
 
-        private CommandBase _viewLogCommand;
-        public CommandBase ViewLogCommand
+        private void ExecuteViewLog(object parameter)
         {
-            get
-            {
-                if (_viewLogCommand != null)
-                {
-                    return _viewLogCommand;
-                }
-                return _viewLogCommand = new DelegateCommand(LogManager.GetCurrentClassLogger(), _ =>
-                {
-                    var fileTarget = (FileTarget) LogManager.Configuration.FindTargetByName("file");
+            var fileTarget = (FileTarget) LogManager.Configuration.FindTargetByName("file");
 
-                    var logEventInfo = new LogEventInfo { TimeStamp = DateTime.Now }; 
-                    var fileName = fileTarget.FileName.Render(logEventInfo);
+            var logEventInfo = new LogEventInfo { TimeStamp = DateTime.Now }; 
+            var fileName = fileTarget.FileName.Render(logEventInfo);
 
-                    // The /select argument will only work if the path has backslashes
-                    fileName = fileName.Replace("/", "\\");
-                    Process.Start(new ProcessStartInfo("explorer.exe", $"/select, \"{fileName}\""));
-                });
-            }
+            // The /select argument will only work if the path has backslashes
+            fileName = fileName.Replace("/", "\\");
+            Process.Start(new ProcessStartInfo("explorer.exe", $"/select, \"{fileName}\""));
         }
-
-        public string AboutCopyright =>
-            string.Format(AboutUI.AboutWindow_Copyright, DateTime.Now.Year);
     }
 }