Move band-aid for AssignmentToByValParameterInspection from resolver to the inspection itself

This also makes the ImplicitDefaultMemberAssignmentInspection work correctly without tweaks to the resolver..

Author: MDoerner

Rubberduck.CodeAnalysis/Inspections/Concrete/AssignedByValParameterInspection.cs

@@ -48,12 +48,41 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
                 .Cast<ParameterDeclaration>()
                 .Where(item => !item.IsByRef 
                     && !item.IsIgnoringInspectionResultFor(AnnotationName)
-                    && item.References.Any(reference => reference.IsAssignment));
+                    && item.References.Any(IsAssignmentToDeclaration));
 
             return parameters
                 .Select(param => new DeclarationInspectionResult(this,
                                                       string.Format(InspectionResults.AssignedByValParameterInspection, param.IdentifierName),
                                                       param));
         }
+
+        private static bool IsAssignmentToDeclaration(IdentifierReference reference)
+        {
+            if (!reference.IsAssignment)
+            {
+                return false;
+            }
+
+            if (reference.IsSetAssignment)
+            {
+                return true;
+            }
+
+            var declaration = reference.Declaration;
+            if (declaration == null)
+            {
+                return false;
+            }
+
+            if (declaration.IsObject)
+            {
+                //This can only be legal with a default member access.
+                return false;
+            }
+
+            //This is not perfect in case the referenced declaration is an unbound Variant.
+            //In that case, a default member access might occur after the run-time resolution.
+            return true;
+        }
     }
 }

Rubberduck.Parsing/Symbols/IdentifierReferenceResolver.cs

@@ -193,22 +193,12 @@ private void ResolveDefault(
                 }
             }
 
-            //TODO: Find out what this is about.
-            var reallyIsAssignmentTarget = isAssignmentTarget && isSetAssignment;
-            if (isAssignmentTarget && !isSetAssignment)
-            {
-                var defaultMember = (boundExpression.ReferencedDeclaration?.AsTypeDeclaration as ClassModuleDeclaration)?.DefaultMember;
-                reallyIsAssignmentTarget = defaultMember == null 
-                                       || ((IParameterizedDeclaration) defaultMember).Parameters.All(param => param.IsOptional)
-                                       || defaultMember.DeclarationType == DeclarationType.PropertyLet && ((IParameterizedDeclaration)defaultMember).Parameters.Count(param => !param.IsOptional) == 1;
-            }
-
             _boundExpressionVisitor.AddIdentifierReferences(
                 boundExpression, 
                 _qualifiedModuleName, 
                 _currentScope,
                 _currentParent,
-                reallyIsAssignmentTarget,
+                isAssignmentTarget,
                 hasExplicitLetStatement, 
                 isSetAssignment);
         }

RubberduckTests/Inspections/AssignedByValParameterInspectionTests.cs

@@ -170,6 +170,40 @@ End Sub
             }
         }
 
+        [Test]
+        [Category("Inspections")]
+        public void AssignedByValParameter_NoResultForDefaultMembberAssignment()
+        {
+            var class1 = @"
+Public Property Get Something() As Long
+Attribute Foo.VB_UserMemId = 0
+End Property
+Public Property Let Something(ByVal value As Long)
+Attribute Foo.VB_UserMemId = 0
+End Property
+";
+            var caller = @"
+Option Explicit
+Private Sub DoSomething(ByVal foo As Class1)
+    foo = 42
+End Sub
+";
+            var builder = new MockVbeBuilder();
+            var vbe = builder.ProjectBuilder("TestProject", ProjectProtection.Unprotected)
+                .AddComponent("Class1", ComponentType.ClassModule, class1)
+                .AddComponent("Module1", ComponentType.StandardModule, caller)
+                .AddProjectToVbeBuilder()
+                .Build();
+
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var inspection = new AssignedByValParameterInspection(state);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
+
+                Assert.IsFalse(inspectionResults.Any());
+            }
+        }
+
         [Test]
         [Category("Inspections")]
         public void InspectionName()