Allow ignoring Hungarian notation, do not report for library procedures. Closes #3932

Author: comintern

Rubberduck.CodeAnalysis/Inspections/Concrete/HungarianNotationInspection.cs

@@ -94,8 +94,14 @@ public sealed class HungarianNotationInspection : InspectionBase
             DeclarationType.Variable
         };
 
+        private static readonly List<DeclarationType> IgnoredProcedureTypes = new List<DeclarationType>
+        {
+            DeclarationType.LibraryFunction,
+            DeclarationType.LibraryProcedure
+        };
+
         #endregion
-        
+
         private readonly IPersistanceService<CodeInspectionSettings> _settings;
 
         public HungarianNotationInspection(RubberduckParserState state, IPersistanceService<CodeInspectionSettings> settings)
@@ -112,7 +118,10 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
             var hungarians = UserDeclarations
                 .Where(declaration => !whitelistedNames.Contains(declaration.IdentifierName) &&
                                       TargetDeclarationTypes.Contains(declaration.DeclarationType) &&
-                                      HungarianIdentifierRegex.IsMatch(declaration.IdentifierName))
+                                      !IgnoredProcedureTypes.Contains(declaration.DeclarationType) && 
+                                      !IgnoredProcedureTypes.Contains(declaration.ParentDeclaration.DeclarationType) &&
+                                      HungarianIdentifierRegex.IsMatch(declaration.IdentifierName) &&
+                                      !IsIgnoringInspectionResultFor(declaration, AnnotationName))
                 .Select(issue => new DeclarationInspectionResult(this,
                                                       string.Format(Resources.Inspections.InspectionResults.IdentifierNameInspection,
                                                                     RubberduckUI.ResourceManager.GetString($"DeclarationType_{issue.DeclarationType}", CultureInfo.CurrentUICulture),

RubberduckTests/Inspections/HungarianNotationInspectionTests.cs

@@ -200,12 +200,75 @@ Dim oRange As Object
 
         [Test]
         [Category("Inspections")]
-        public void InspectionName()
+        public void HungarianNotation_DoesNotReturnResult_Ignored()
         {
-            const string inspectionName = "UseMeaningfulNameInspection";
-            var inspection = new UseMeaningfulNameInspection(null, null);
+            const string inputCode =
+                @"Sub Hungarian()
+'@Ignore HungarianNotation
+    Dim oFoo As Object
+End Sub";
+
+            var builder = new MockVbeBuilder();
+            var project = builder.ProjectBuilder("VBAProject", ProjectProtection.Unprotected)
+                .AddComponent("MyClass", ComponentType.ClassModule, inputCode)
+                .Build();
+            var vbe = builder.AddProject(project).Build();
+
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var inspection = new HungarianNotationInspection(state, UseMeaningfulNameInspectionTests.GetInspectionSettings().Object);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
+
+                Assert.AreEqual(0, inspectionResults.Count());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void HungarianNotation_DoesNotReturnResult_LibraryFunctionParameters()
+        {
+            const string inputCode =
+                @"
+Private Declare Function GetUserName Lib ""advapi32.dll"" Alias ""GetUserNameA"" (ByVal lpBuffer As String, nSize As Long) As Long
+";
+
+            var builder = new MockVbeBuilder();
+            var project = builder.ProjectBuilder("VBAProject", ProjectProtection.Unprotected)
+                .AddComponent("MyClass", ComponentType.ClassModule, inputCode)
+                .Build();
+            var vbe = builder.AddProject(project).Build();
+
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var inspection = new HungarianNotationInspection(state, UseMeaningfulNameInspectionTests.GetInspectionSettings().Object);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
 
-            Assert.AreEqual(inspectionName, inspection.Name);
+                Assert.AreEqual(0, inspectionResults.Count());
+            }
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void HungarianNotation_DoesNotReturnResult_LibraryFunction()
+        {
+            const string inputCode =
+                @"
+Private Declare Sub chkVoid Lib ""somelib.dll"" Alias ""chkVoidA"" (number As Long)
+";
+
+            var builder = new MockVbeBuilder();
+            var project = builder.ProjectBuilder("VBAProject", ProjectProtection.Unprotected)
+                .AddComponent("MyClass", ComponentType.ClassModule, inputCode)
+                .Build();
+            var vbe = builder.AddProject(project).Build();
+
+            using (var state = MockParser.CreateAndParse(vbe.Object))
+            {
+                var inspection = new HungarianNotationInspection(state, UseMeaningfulNameInspectionTests.GetInspectionSettings().Object);
+                var inspectionResults = inspection.GetInspectionResults(CancellationToken.None);
+
+                Assert.AreEqual(0, inspectionResults.Count());
+            }
         }
     }
 }