Merge pull request #146 from rubberduck-vba/next

sync with main repo

Author: retailcoder

README.md

@@ -85,7 +85,7 @@ Which basically means it's a reimplementation of Git in C. It also [happens to b
 
 This library makes localizing WPF applications at runtime using resx files a breeze. Thank you [Grant Frisken](http://www.codeproject.com/script/Membership/View.aspx?mid=1079060)!
 
-> Licensed under [The Code Project Open License](http://www.codeproject.com/info/cpol10.aspx).
+> Licensed under [The Code Project Open License](http://www.codeproject.com/info/cpol10.aspx) with the [author's permission](http://www.codeproject.com/Messages/5272045/Re-License.aspx) to re-release under the GPLv3.
 
 ###[Using Raw Input from C# to handle multiple keyboards](http://www.codeproject.com/Articles/17123/Using-Raw-Input-from-C-to-handle-multiple-keyboard)
 

RetailCoder.VBE/Common/Hotkeys/HotkeyInfo.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Text;
 using System.Windows.Forms;
+using Rubberduck.UI;
 
 namespace Rubberduck.Common.Hotkeys
 {
@@ -25,20 +26,21 @@ public override string ToString()
             var builder = new StringBuilder();
             if (_keys.HasFlag(Keys.Alt))
             {
-                builder.Append(Rubberduck.UI.RubberduckUI.GeneralSettings_HotkeyAlt);
+                builder.Append(RubberduckUI.GeneralSettings_HotkeyAlt);
                 builder.Append('+');
             }
             if (_keys.HasFlag(Keys.Control))
             {
-                builder.Append(Rubberduck.UI.RubberduckUI.GeneralSettings_HotkeyCtrl);
+                builder.Append(RubberduckUI.GeneralSettings_HotkeyCtrl);
                 builder.Append('+');
             }
             if (_keys.HasFlag(Keys.Shift))
             {
-                builder.Append(Rubberduck.UI.RubberduckUI.GeneralSettings_HotkeyShift);
+                builder.Append(RubberduckUI.GeneralSettings_HotkeyShift);
                 builder.Append('+');
             }
-            builder.Append(_keys & ~Modifiers);
+            
+            builder.Append(HotkeyDisplayConverter.Convert(_keys & ~Modifiers));
             return builder.ToString();
         }
     }

RetailCoder.VBE/Common/RubberduckHooks.cs

@@ -13,6 +13,7 @@
 using Rubberduck.UI.Command;
 using Rubberduck.UI.Command.Refactorings;
 using NLog;
+using Rubberduck.UI;
 
 namespace Rubberduck.Common
 {

RetailCoder.VBE/Common/WinAPI/RawInput.cs

@@ -39,23 +39,41 @@ protected override void WndProc(ref Message message)
             switch ((WM)message.Msg)
             {
                 case WM.INPUT:
+                {
+                    if (message.LParam == IntPtr.Zero)
+                    {
+                        break;
+                    }
+                    InputData rawBuffer;
+                    var dwSize = 0;
+                    var res = User32.GetRawInputData(message.LParam, DataCommand.RID_INPUT, IntPtr.Zero, ref dwSize, Marshal.SizeOf(typeof(RawInputHeader)));
+                    if (res != 0)
+                    {
+                        var ex = new Win32Exception(Marshal.GetLastWin32Error());
+                        Logger.Error(ex, "Error sizing the rawinput buffer: {0}", ex.Message);
+                        break;                           
+                    }
+
+                    res = User32.GetRawInputData(message.LParam, DataCommand.RID_INPUT, out rawBuffer, ref dwSize, Marshal.SizeOf(typeof(RawInputHeader)));
+                    if (res == -1)
+                    {
+                        var ex = new Win32Exception(Marshal.GetLastWin32Error());
+                        Logger.Error(ex, "Error getting the rawinput buffer: {0}", ex.Message);
+                        break;
+                    }
+                    if (res == dwSize)
                     {
-                        InputData _rawBuffer;
-                        var dwSize = 0;
-                        User32.GetRawInputData(message.LParam, DataCommand.RID_INPUT, IntPtr.Zero, ref dwSize, Marshal.SizeOf(typeof(RawInputHeader)));
-                        int res = User32.GetRawInputData(message.LParam, DataCommand.RID_INPUT, out _rawBuffer, ref dwSize, Marshal.SizeOf(typeof(RawInputHeader)));
-                        if (dwSize != res)
-                        {
-                            var ex = new Win32Exception(Marshal.GetLastWin32Error());
-                            Logger.Error(ex, "Error getting the rawinput buffer: {0}", ex.Message);
-                            return;
-                        }
                         foreach (var device in _devices)
                         {
-                            device.ProcessRawInput(_rawBuffer);
+                            device.ProcessRawInput(rawBuffer);
                         }
                     }
-                    break;
+                    else
+                    {
+                        //Something is seriously f'd up with Windows - the number of bytes copied does not match the reported buffer size.
+                    }
+                }
+                break;
             }
             base.WndProc(ref message);
         }

RetailCoder.VBE/Inspections/AssignedByValParameterInspectionResult.cs

@@ -13,9 +13,10 @@ public class AssignedByValParameterInspectionResult : InspectionResultBase
         public AssignedByValParameterInspectionResult(IInspection inspection, Declaration target)
             : base(inspection, target)
         {
-            _quickFixes = new[]
+            _quickFixes = new CodeInspectionQuickFix[]
             {
                 new PassParameterByReferenceQuickFix(target.Context, QualifiedSelection),
+                new IgnoreOnceQuickFix(Context, QualifiedSelection, inspection.AnnotationName)
             };
         }
 

RetailCoder.VBE/Inspections/CodeInspectionQuickFix.cs

@@ -1,4 +1,5 @@
-using Antlr4.Runtime;
+using System.Windows.Threading;
+using Antlr4.Runtime;
 using Rubberduck.VBEditor;
 
 namespace Rubberduck.Inspections
@@ -11,6 +12,9 @@ public abstract class CodeInspectionQuickFix
 
         public CodeInspectionQuickFix(ParserRuleContext context, QualifiedSelection selection, string description)
         {
+            Dispatcher.CurrentDispatcher.Thread.CurrentCulture = UI.Settings.Settings.Culture;
+            Dispatcher.CurrentDispatcher.Thread.CurrentUICulture = UI.Settings.Settings.Culture;
+
             _context = context;
             _selection = selection;
             _description = description;

RetailCoder.VBE/Inspections/EmptyStringLiteralInspection.cs

@@ -26,8 +26,9 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
             {
                 return new InspectionResultBase[] { };
             }
-            return ParseTreeResults.EmptyStringLiterals.Select(
-                    context => new EmptyStringLiteralInspectionResult(this,
+            return ParseTreeResults.EmptyStringLiterals
+                .Where(s => !IsInspectionDisabled(s.ModuleName.Component, s.Context.Start.Line))
+                .Select(context => new EmptyStringLiteralInspectionResult(this,
                             new QualifiedContext<ParserRuleContext>(context.ModuleName, context.Context)));
         }
 

RetailCoder.VBE/Inspections/EmptyStringLiteralInspectionResult.cs

@@ -13,9 +13,10 @@ public class EmptyStringLiteralInspectionResult : InspectionResultBase
         public EmptyStringLiteralInspectionResult(IInspection inspection, QualifiedContext<ParserRuleContext> qualifiedContext)
             : base(inspection, qualifiedContext.ModuleName, qualifiedContext.Context)
         {
-            _quickFixes = new[]
+            _quickFixes = new CodeInspectionQuickFix[]
             {
-                new RepaceEmptyStringLiteralStatementQuickFix(Context, QualifiedSelection), 
+                new RepaceEmptyStringLiteralStatementQuickFix(Context, QualifiedSelection),
+                new IgnoreOnceQuickFix(Context, QualifiedSelection, Inspection.AnnotationName)
             };
         }
 

RetailCoder.VBE/Inspections/EncapsulatePublicFieldInspectionResult.cs

@@ -16,9 +16,10 @@ public class EncapsulatePublicFieldInspectionResult : InspectionResultBase
         public EncapsulatePublicFieldInspectionResult(IInspection inspection, Declaration target, RubberduckParserState state)
             : base(inspection, target)
         {
-            _quickFixes = new[]
+            _quickFixes = new CodeInspectionQuickFix[]
             {
                 new EncapsulateFieldQuickFix(target.Context, target.QualifiedSelection, target, state),
+                new IgnoreOnceQuickFix(Context, QualifiedSelection, Inspection.AnnotationName)
             };
         }
 

RetailCoder.VBE/Inspections/FunctionReturnValueNotUsedInspectionResult.cs

@@ -34,9 +34,10 @@ public FunctionReturnValueNotUsedInspectionResult(
             var root = new ConvertToProcedureQuickFix(context, QualifiedSelection, returnStatements);
             var compositeFix = new CompositeCodeInspectionFix(root);
             children.ToList().ForEach(child => compositeFix.AddChild(new ConvertToProcedureQuickFix(child.Item1, child.Item2, child.Item3)));
-            _quickFixes = new[]
+            _quickFixes = new CodeInspectionQuickFix[]
             {
-                compositeFix
+                compositeFix,
+                new IgnoreOnceQuickFix(Context, QualifiedSelection, Inspection.AnnotationName)
             };
         }