Skip to content

Commit 5cb0c52

Browse files
committed
don't skip loading Rubberduck.tlb
1 parent 2d1f896 commit 5cb0c52

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

Rubberduck.Parsing/VBA/RubberduckParser.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -382,6 +382,7 @@ private string GetReferenceProjectId(IReference reference, IReadOnlyList<IVBProj
382382
private void SyncComReferences(IReadOnlyList<IVBProject> projects)
383383
{
384384
var loadTasks = new List<Task>();
385+
var unmapped = new List<IReference>();
385386

386387
foreach (var vbProject in projects)
387388
{
@@ -397,8 +398,8 @@ private void SyncComReferences(IReadOnlyList<IVBProject> projects)
397398
// skip loading Rubberduck.tlb (GUID is defined in AssemblyInfo.cs)
398399
if (reference.Guid == "{E07C841C-14B4-4890-83E9-8C80B06DD59D}")
399400
{
400-
// todo: figure out why Rubberduck.tlb can't be loaded that way
401-
continue;
401+
// todo: figure out why Rubberduck.tlb *sometimes* throws
402+
//continue;
402403
}
403404
var referencedProjectId = GetReferenceProjectId(reference, projects);
404405

@@ -442,6 +443,7 @@ private void SyncComReferences(IReadOnlyList<IVBProject> projects)
442443
}
443444
catch (Exception exception)
444445
{
446+
unmapped.Add(reference);
445447
Logger.Warn(string.Format("Types were not loaded from referenced type library '{0}'.", reference.Name));
446448
Logger.Error(exception);
447449
}
@@ -458,7 +460,6 @@ private void SyncComReferences(IReadOnlyList<IVBProject> projects)
458460
mappedIds.Add(item.ReferencedProjectId);
459461
}
460462

461-
var unmapped = new List<IReference>();
462463
foreach (var project in projects)
463464
{
464465
var references = project.References;

0 commit comments

Comments
 (0)