Correct filtering logic

IvenBach · IvenBach · commit 5baddb000b2e · 2018-08-15T11:32:00.000-07:00
diff --git a/Rubberduck.Core/UI/Settings/InspectionSettingsViewModel.cs b/Rubberduck.Core/UI/Settings/InspectionSettingsViewModel.cs
@@ -88,9 +88,7 @@ private bool FilterResults(object setting)
             var cis = setting as CodeInspectionSetting;
 
             return cis.Description.ToUpper().Contains(_inspectionSettingsDescriptionFilter.ToUpper())
-                && _selectedSeverityFilter == _allResultsFilter 
-                    ? true
-                    : cis.Severity.ToString() == _selectedSeverityFilter;
+                && (_selectedSeverityFilter.Equals(_allResultsFilter) || cis.Severity.ToString().Equals(_selectedSeverityFilter));
         }
 
         private ListCollectionView _inspectionSettings;

Original file line number	Diff line number	Diff line change
`@@ -88,9 +88,7 @@ private bool FilterResults(object setting)`
`88`	`88`	`var cis = setting as CodeInspectionSetting;`
`89`	`89`
`90`	`90`	`return cis.Description.ToUpper().Contains(_inspectionSettingsDescriptionFilter.ToUpper())`
`91`		`- && _selectedSeverityFilter == _allResultsFilter`
`92`		`- ? true`
`93`		`- : cis.Severity.ToString() == _selectedSeverityFilter;`
	`91`	`+ && (_selectedSeverityFilter.Equals(_allResultsFilter) \|\| cis.Severity.ToString().Equals(_selectedSeverityFilter));`
`94`	`92`	`}`
`95`	`93`
`96`	`94`	`private ListCollectionView _inspectionSettings;`