removed unused VbComponentExtensions

Author: retailcoder

RetailCoder.VBE/Extensions/CodePaneExtensions.cs

@@ -28,35 +28,7 @@ public static QualifiedSelection GetSelection(this CodePane code)
             }
 
             var selection = new Selection(startLine, startColumn, endLine, endColumn);
-            return new QualifiedSelection(code.CodeModule.Parent.QualifiedName(), selection);
-        }
-
-        /// <summary>
-        /// Returns a <see cref="Selection"/> representing the position 
-        /// </summary>
-        ///
-        /// <param name="selection">    The selection. </param>
-        /// <returns>   A QualifiedSelection object representing the procedure the cursor is currently in. </returns>
-        public static Selection SelectedProcedure(this CodePane code, Selection selection)
-        {
-            vbext_ProcKind kind;
-            var procedure = code.CodeModule.get_ProcOfLine(selection.StartLine, out kind);
-            var startLine = code.CodeModule.get_ProcStartLine(procedure, kind);
-            var endLine = startLine + code.CodeModule.get_ProcCountLines(procedure, kind) + 1;
-
-            return new Selection(startLine, 1, endLine, 1);
-        }
-
-        /// <summary>
-        /// Sets the cursor to the first position of the given line.
-        /// </summary>
-        /// <param name="codePane"></param>
-        /// <param name="lineNumber"></param>
-        public static void SetSelection(this CodePane codePane, int lineNumber)
-        {
-            var line = codePane.CodeModule.Lines[lineNumber, 1];
-            var selection = new Selection(lineNumber, 1, lineNumber, line.Length);
-            codePane.SetSelection(selection);
+            return new QualifiedSelection(new QualifiedModuleName(code.CodeModule.Parent), selection);
         }
 
         /// <summary>

RetailCoder.VBE/UI/CodeInspections/CodeInspectionsDockablePresenter.cs

@@ -74,16 +74,10 @@ private void OnNavigateCodeIssue(object sender, NavigateCodeEventArgs e)
         {
             try
             {
-                var location = VBE.FindInstruction(e.QualifiedName, e.Selection);
-                location.CodeModule.CodePane.SetSelection(e.Selection);
-
-                var codePane = location.CodeModule.CodePane;
-                var selection = location.Selection;
-                codePane.SetSelection(selection);
+                e.QualifiedName.Component.CodeModule.CodePane.SetSelection(e.Selection);
             }
-            catch (Exception exception)
+            catch (COMException)
             {
-                Debug.Assert(false, exception.ToString());
             }
         }
 

RetailCoder.VBE/VBA/RubberduckParser.cs

@@ -50,7 +50,7 @@ private VBComponentParseResult Parse(VBComponent component)
             try
             {
                 VBComponentParseResult cachedValue;
-                var name = component.QualifiedName();
+                var name = new QualifiedModuleName(component); // already a performance hit
                 if (ParseResultCache.TryGetValue(name, out cachedValue))
                 {
                     return cachedValue;
@@ -61,7 +61,7 @@ private VBComponentParseResult Parse(VBComponent component)
 
                 TokenStreamRewriter rewriter;
                 var parseTree = Parse(lines, out rewriter);
-                var comments = ParseComments(component);
+                var comments = ParseComments(name);
                 var result = new VBComponentParseResult(component, parseTree, comments, rewriter);
 
                 ParseResultCache.AddOrUpdate(name, module => result, (qName, module) => result);
@@ -73,11 +73,9 @@ private VBComponentParseResult Parse(VBComponent component)
             }
         }
 
-        private IEnumerable<CommentNode> ParseComments(VBComponent component)
+        private IEnumerable<CommentNode> ParseComments(QualifiedModuleName qualifiedName)
         {
-            var code = component.CodeModule.Code();
-            var qualifiedName = component.QualifiedName();
-
+            var code = qualifiedName.Component.CodeModule.Code();
             var commentBuilder = new StringBuilder();
             var continuing = false;
 

Rubberduck.Parsing/ParserRuleContextExtensions.cs

@@ -43,17 +43,6 @@ public static IEnumerable<QualifiedContext<TContext>> GetContexts<TListener, TCo
             return listener.Members;
         }
 
-        public static QualifiedContext<TContext> ToQualifiedContext<TContext>(this TContext context, QualifiedModuleName name) where TContext : ParserRuleContext
-        {
-            return new QualifiedContext<TContext>(name, context);
-        }
-
-        public static QualifiedSelection GetQualifiedSelection(this ParserRuleContext context, QualifiedModuleName name)
-        {
-            var selection = context.GetSelection();
-            return new QualifiedSelection(name, selection);
-        }
-
         public static Selection GetSelection(this ParserRuleContext context)
         {
             if (context == null)

Rubberduck.Parsing/QualifiedModuleName.cs

@@ -8,6 +8,11 @@ public struct QualifiedModuleName
         public QualifiedModuleName(VBComponent component)
         {
             _component = component;
+
+            var module = _component.CodeModule;
+            _contentHashCode = module.CountOfLines > 0 
+                ? module.get_Lines(1, module.CountOfLines).GetHashCode() 
+                : 0;
         }
 
         public QualifiedMemberName QualifyMemberName(string member)
@@ -17,25 +22,26 @@ public QualifiedMemberName QualifyMemberName(string member)
 
         private readonly VBComponent _component;
         public VBComponent Component { get { return _component; } }
-
         public VBProject Project { get { return _component == null ? null : _component.Collection.Parent; } }
 
+        private readonly int _contentHashCode;
+
         public override string ToString()
         {
             return _component == null ? string.Empty : Project.Name + "." + _component.Name;
         }
 
         public override int GetHashCode()
         {
-            return _component.GetHashCode();
+            return _component == null ? 0 : _component.GetHashCode();
         }
 
         public override bool Equals(object obj)
         {
             try
             {
                 var other = (QualifiedModuleName)obj;
-                return other.Component == Component;
+                return other.Component == Component && other._contentHashCode == _contentHashCode;
             }
             catch (InvalidCastException)
             {

Rubberduck.Parsing/Rubberduck.Parsing.csproj

@@ -81,7 +81,6 @@
     </Compile>
     <Compile Include="Symbols\IdentifierReference.cs" />
     <Compile Include="Symbols\IdentifierReferenceListener.cs" />
-    <Compile Include="VBComponentExtensions.cs" />
     <Compile Include="VBComponentParseResult.cs" />
     <Compile Include="VBProjectParseResult.cs" />
   </ItemGroup>

Rubberduck.Parsing/VBComponentExtensions.cs

@@ -11,7 +11,7 @@ public class VBComponentParseResult
         public VBComponentParseResult(VBComponent component, IParseTree parseTree, IEnumerable<CommentNode> comments, TokenStreamRewriter rewriter)
         {
             _component = component;
-            _qualifiedName = component.QualifiedName();
+            _qualifiedName = new QualifiedModuleName(component);
             _parseTree = parseTree;
             _comments = comments;
             _rewriter = rewriter;