Address review comments, tracked down the last of the ExplicitCallerInfoArguments and replaced them with nameof.

Author: comintern

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerItemViewModel.cs

@@ -41,7 +41,9 @@ public virtual void Synchronize(List<Declaration> updated)
                 return;
             }
 
-            var matching = updated.FirstOrDefault(decl => Declaration.DeclarationType == decl?.DeclarationType && Declaration.QualifiedName.Equals(decl?.QualifiedName));
+            var matching = updated.FirstOrDefault(decl =>
+                Declaration.DeclarationType == decl?.DeclarationType &&
+                Declaration.QualifiedName.Equals(decl.QualifiedName));
 
             if (matching is null)
             {

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerItemViewModelBase.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
-using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Linq;
 using System.Windows;
@@ -75,13 +74,12 @@ public virtual string PanelTitle
 
         public virtual string Description => Declaration?.DescriptionString ?? string.Empty;
 
-        [SuppressMessage("ReSharper", "ExplicitCallerInfoArgument")]
         protected void OnNameChanged()
         {
-            OnPropertyChanged("Name");
-            OnPropertyChanged("NameWithSignature");
-            OnPropertyChanged("PanelTitle");
-            OnPropertyChanged("Description");
+            OnPropertyChanged(nameof(Name));
+            OnPropertyChanged(nameof(NameWithSignature));
+            OnPropertyChanged(nameof(PanelTitle));
+            OnPropertyChanged(nameof(Description));
         }
 
         public virtual QualifiedSelection? QualifiedSelection => Declaration?.QualifiedSelection;
@@ -232,8 +230,7 @@ public string Filter
                 }
 
                 OnPropertyChanged();
-                // ReSharper disable once ExplicitCallerInfoArgument
-                OnPropertyChanged("Filtered");
+                OnPropertyChanged(nameof(Filtered));
             }
         }
 

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerMemberViewModel.cs

@@ -76,7 +76,9 @@ protected sealed override void AddNewChildren(List<Declaration> updated)
         {
             if (updated != null)
             {
-                var updates = updated.Where(item => SubMemberTypes.Contains(item.DeclarationType) && item.ParentDeclaration.Equals(Declaration)).ToList();
+                var updates = updated.Where(item =>
+                        SubMemberTypes.Contains(item.DeclarationType) && item.ParentDeclaration.Equals(Declaration))
+                    .ToList();
 
                 AddChildren(updates.Select(item => new CodeExplorerSubMemberViewModel(this, item)));
 

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerReferenceViewModel.cs

@@ -60,8 +60,7 @@ public void Synchronize(Declaration project, List<ReferenceModel> updated)
 
             if (used != Reference.IsUsed)
             {
-                // ReSharper disable once ExplicitCallerInfoArgument
-                OnPropertyChanged("IsDimmed");
+                OnPropertyChanged(nameof(IsDimmed));
             }
         }
     }

Rubberduck.Core/Navigation/CodeExplorer/CodeExplorerViewModel.cs

@@ -243,6 +243,13 @@ private void HandleStateChanged(object sender, ParserStateEventArgs e)
             }
         }
 
+        /// <summary>
+        /// Updates the ViewModel tree to reflect changes in user declarations after a reparse.
+        /// </summary>
+        /// <param name="declarations">
+        /// The new declarations. This should always be the complete declaration set, and materializing
+        /// the IEnumerable should be deferred to UI thread.
+        /// </param>
         private void Synchronize(IEnumerable<Declaration> declarations)
         {
             _uiDispatcher.Invoke(() =>

RubberduckTests/CodeExplorer/CodeExplorerComparerTests.cs

@@ -6,6 +6,7 @@
 
 namespace RubberduckTests.CodeExplorer
 {
+    // TODO: These tests should probably be refactored to use test cases.
     [TestFixture]
     public class CodeExplorerComparerTests
     {