included identifier name in inspection result for meaningful names; reworded a bit.

Author: retailcoder

RetailCoder.VBE/Inspections/InspectionsUI.Designer.cs

@@ -118,15 +118,15 @@
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
   <data name="EmptyStringLiteralInspection" xml:space="preserve">
-    <value>Empty String Literal Detected.</value>
+    <value>Intent of empty string literal could be clarified with 'vbNullString'.</value>
   </data>
   <data name="EmptyStringLiteralInspectionQuickFix" xml:space="preserve">
     <value>Replace '""' with 'vbNullString'.</value>
   </data>
   <data name="UseMeaningfulNameInspection" xml:space="preserve">
-    <value>Suboptimal Name Detected.</value>
+    <value>Identifier '{0}' could probably use a better name.</value>
   </data>
   <data name="UseMeaningfulNameInspectionQuickFix" xml:space="preserve">
-    <value>Rename</value>
+    <value>Rename identifier</value>
   </data>
 </root>

RetailCoder.VBE/Inspections/InspectionsUI.resx

@@ -8,10 +8,12 @@ namespace Rubberduck.Inspections
 {
     public class UseMeaningfulNameInspection : IInspection
     {
+        private readonly IMessageBox _messageBox;
         private readonly ICodePaneWrapperFactory _wrapperFactory;
 
-        public UseMeaningfulNameInspection()
+        public UseMeaningfulNameInspection(IMessageBox messageBox)
         {
+            _messageBox = messageBox;
             _wrapperFactory = new CodePaneWrapperFactory();
             Severity = CodeInspectionSeverity.Suggestion;
         }
@@ -29,7 +31,7 @@ public IEnumerable<CodeInspectionResultBase> GetInspectionResults(RubberduckPars
                                                    char.IsDigit(declaration.IdentifierName.Last()) ||
                                                    !declaration.IdentifierName.Any(c => new[] {'a', 'e', 'i', 'o', 'u', 'y'}.Contains(c))
                                                   ))
-                            .Select(issue => new UseMeaningfulNameInspectionResult(this, issue, state, _wrapperFactory, new MessageBox()))
+                            .Select(issue => new UseMeaningfulNameInspectionResult(this, issue, state, _wrapperFactory, _messageBox))
                             .ToList();
 
             return issues;