Skip to content

Commit 595e36b

Browse files
committed
renamed quickfix to describe its action rather than the trigger for the inspection results it can be used with.
1 parent 604487a commit 595e36b

File tree

8 files changed

+19
-19
lines changed

8 files changed

+19
-19
lines changed

Rubberduck.CodeAnalysis/QuickFixes/Concrete/WriteOnlyPropertyQuickFix.cs renamed to Rubberduck.CodeAnalysis/QuickFixes/Concrete/IntroduceGetAccessorQuickFix.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ namespace Rubberduck.CodeAnalysis.QuickFixes.Concrete
4141
/// ]]>
4242
/// </after>
4343
/// </example>
44-
internal sealed class WriteOnlyPropertyQuickFix : QuickFixBase
44+
internal sealed class IntroduceGetAccessorQuickFix : QuickFixBase
4545
{
46-
public WriteOnlyPropertyQuickFix()
46+
public IntroduceGetAccessorQuickFix()
4747
: base(typeof(WriteOnlyPropertyInspection))
4848
{}
4949

Rubberduck.Resources/Inspections/QuickFixes.Designer.cs

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Rubberduck.Resources/Inspections/QuickFixes.cs.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@
201201
<data name="SetObjectVariableQuickFix" xml:space="preserve">
202202
<value>Použij klíčové slovo 'Set'</value>
203203
</data>
204-
<data name="WriteOnlyPropertyQuickFix" xml:space="preserve">
204+
<data name="IntroduceGetAccessorQuickFix" xml:space="preserve">
205205
<value>Přidej accessor 'property get'</value>
206206
</data>
207207
<data name="ChangeDimToPrivateQuickFix" xml:space="preserve">

Rubberduck.Resources/Inspections/QuickFixes.de.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@
192192
<data name="IntroduceLocalVariableQuickFix" xml:space="preserve">
193193
<value>Lokale Variable einführen</value>
194194
</data>
195-
<data name="WriteOnlyPropertyQuickFix" xml:space="preserve">
195+
<data name="IntroduceGetAccessorQuickFix" xml:space="preserve">
196196
<value>'Property Get' Zugriff hinzufügen</value>
197197
</data>
198198
<data name="ChangeDimToPrivateQuickFix" xml:space="preserve">

Rubberduck.Resources/Inspections/QuickFixes.es.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@
195195
<data name="SetObjectVariableQuickFix" xml:space="preserve">
196196
<value>Use la palabra clave 'Set'</value>
197197
</data>
198-
<data name="WriteOnlyPropertyQuickFix" xml:space="preserve">
198+
<data name="IntroduceGetAccessorQuickFix" xml:space="preserve">
199199
<value>Añadir Get a propiedad</value>
200200
</data>
201201
<data name="ChangeDimToPrivateQuickFix" xml:space="preserve">

Rubberduck.Resources/Inspections/QuickFixes.fr.resx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@
195195
<data name="IntroduceLocalVariableQuickFix" xml:space="preserve">
196196
<value>Introduire une variable locale</value>
197197
</data>
198-
<data name="WriteOnlyPropertyQuickFix" xml:space="preserve">
198+
<data name="IntroduceGetAccessorQuickFix" xml:space="preserve">
199199
<value>Ajouter un accesseur 'Property Get'</value>
200200
</data>
201201
<data name="ApplicationWorksheetFunctionQuickFix" xml:space="preserve">

Rubberduck.Resources/Inspections/QuickFixes.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,8 @@
195195
<data name="SetObjectVariableQuickFix" xml:space="preserve">
196196
<value>Use 'Set' keyword</value>
197197
</data>
198-
<data name="WriteOnlyPropertyQuickFix" xml:space="preserve">
199-
<value>Add property get accessor</value>
198+
<data name="IntroduceGetAccessorQuickFix" xml:space="preserve">
199+
<value>Add 'Property Get' accessor</value>
200200
</data>
201201
<data name="ChangeDimToPrivateQuickFix" xml:space="preserve">
202202
<value>Replace 'Dim' with 'Private'</value>

RubberduckTests/QuickFixes/WriteOnlyPropertyQuickFixTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ Public Property Let Foo(value1, ByVal value2 As Integer, ByRef value3 As Long, v
7272

7373
protected override IQuickFix QuickFix(RubberduckParserState state)
7474
{
75-
return new WriteOnlyPropertyQuickFix();
75+
return new IntroduceGetAccessorQuickFix();
7676
}
7777

7878
protected override IVBE TestVbe(string code, out IVBComponent component)

0 commit comments

Comments
 (0)