Removed InspectionType default value from inspection classes

Author: rkapka

Rubberduck.Inspections/Abstract/InspectionBase.cs

@@ -22,7 +22,6 @@ public abstract class InspectionBase : IInspection
         protected InspectionBase(RubberduckParserState state)
         {
             State = state;
-            Severity = CodeInspectionSeverity.Warning;
             Name = GetType().Name;
         }
 
@@ -34,7 +33,7 @@ protected InspectionBase(RubberduckParserState state)
         /// <summary>
         /// Gets the type of inspection; used for regrouping inspections.
         /// </summary>
-        public abstract CodeInspectionType InspectionType { get; }
+        public CodeInspectionType InspectionType { get; set; } = CodeInspectionType.CodeQualityIssues;
 
         /// <summary>
         /// The inspection type name, obtained by reflection.
@@ -44,7 +43,7 @@ protected InspectionBase(RubberduckParserState state)
         /// <summary>
         /// Inspection severity level. Can control whether an inspection is enabled.
         /// </summary>
-        public CodeInspectionSeverity Severity { get; set; }
+        public CodeInspectionSeverity Severity { get; set; } = CodeInspectionSeverity.Warning;
 
         /// <summary>
         /// Meta-information about why an inspection exists.

Rubberduck.Inspections/Abstract/ParseTreeInspectionBase.cs

@@ -1,5 +1,4 @@
 using Rubberduck.Parsing.Inspections.Abstract;
-using Rubberduck.Parsing.Inspections.Resources;
 using Rubberduck.Parsing.VBA;
 
 namespace Rubberduck.Inspections.Abstract
@@ -9,7 +8,6 @@ public abstract class ParseTreeInspectionBase : InspectionBase, IParseTreeInspec
         protected ParseTreeInspectionBase(RubberduckParserState state)
             : base(state) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
         public abstract IInspectionListener Listener { get; }
         public virtual ParsePass Pass => ParsePass.CodePanePass;
     }

Rubberduck.Inspections/Concrete/ApplicationWorksheetFunctionInspection.cs

@@ -17,8 +17,6 @@ public class ApplicationWorksheetFunctionInspection : InspectionBase
         public ApplicationWorksheetFunctionInspection(RubberduckParserState state)
             : base(state) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
-
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             var excel = State.DeclarationFinder.Projects.SingleOrDefault(item => !item.IsUserDefined && item.IdentifierName == "Excel");

Rubberduck.Inspections/Concrete/AssignedByValParameterInspection.cs

@@ -15,8 +15,6 @@ public AssignedByValParameterInspection(RubberduckParserState state)
             : base(state)
         { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
-
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             var parameters = State.DeclarationFinder.UserDeclarations(DeclarationType.Parameter)

Rubberduck.Inspections/Concrete/BooleanAssignedInIfElseInspection.cs

@@ -7,7 +7,6 @@
 using Rubberduck.Parsing.Grammar;
 using Rubberduck.Parsing.Inspections.Abstract;
 using Rubberduck.Parsing.Inspections.Resources;
-using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 using Rubberduck.VBEditor;
 
@@ -18,8 +17,6 @@ public sealed class BooleanAssignedInIfElseInspection : ParseTreeInspectionBase
         public BooleanAssignedInIfElseInspection(RubberduckParserState state)
             : base(state) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
-
         public override IInspectionListener Listener { get; } =
             new BooleanAssignedInIfElseListener();
 

Rubberduck.Inspections/Concrete/ConstantNotUsedInspection.cs

@@ -17,8 +17,6 @@ public sealed class ConstantNotUsedInspection : InspectionBase
         public ConstantNotUsedInspection(RubberduckParserState state)
             : base(state) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
-
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             var results = State.DeclarationFinder.UserDeclarations(DeclarationType.Constant)

Rubberduck.Inspections/Concrete/DefTypeStatementInspection.cs

@@ -20,8 +20,7 @@ public DefTypeStatementInspection(RubberduckParserState state)
         {
             Listener = new DefTypeStatementInspectionListener();
         }
-
-        public override CodeInspectionType InspectionType => CodeInspectionType.LanguageOpportunities;
+        
         public override IInspectionListener Listener { get; }
 
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()

Rubberduck.Inspections/Concrete/DefaultProjectNameInspection.cs

@@ -4,7 +4,6 @@
 using Rubberduck.Inspections.Results;
 using Rubberduck.Parsing.Inspections;
 using Rubberduck.Parsing.Inspections.Abstract;
-using Rubberduck.Parsing.Inspections.Resources;
 using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA;
 
@@ -16,8 +15,6 @@ public sealed class DefaultProjectNameInspection : InspectionBase
         public DefaultProjectNameInspection(RubberduckParserState state)
             : base(state) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
-
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             var projects = State.DeclarationFinder.UserDeclarations(DeclarationType.Project)

Rubberduck.Inspections/Concrete/EmptyCaseBlockInspection.cs

@@ -20,8 +20,6 @@ public EmptyCaseBlockInspection(RubberduckParserState state)
         public override IInspectionListener Listener { get; } =
             new EmptyCaseBlockListener();
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
-
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             return Listener.Contexts

Rubberduck.Inspections/Concrete/EmptyDoWhileBlockInspection.cs

@@ -17,8 +17,6 @@ internal class EmptyDoWhileBlockInspection : ParseTreeInspectionBase
         public EmptyDoWhileBlockInspection(RubberduckParserState state)
             : base(state) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
-
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
             return Listener.Contexts