Clean up the ParseErrorEventArgs

Author: bclothier

Rubberduck.Core/UI/ParserErrors/ParseErrorListItem.cs

@@ -1,4 +1,5 @@
 using Rubberduck.Parsing.VBA;
+using Rubberduck.VBEditor.SafeComWrappers.Abstract;
 
 namespace Rubberduck.UI.ParserErrors
 {
@@ -20,9 +21,9 @@ public ParseErrorListItem(ParseErrorEventArgs error)
 
         public string Value => ToString();
 
-        public void Navigate()
+        public void Navigate(IVBE vbe)
         {
-            _error.Navigate();
+            _error.Navigate(vbe);
         }
 
         public override string ToString()

Rubberduck.Core/UI/ParserErrors/ParserErrorsPresenter.cs

@@ -17,9 +17,12 @@ public interface IParserErrorsPresenter
 
     public class ParserErrorsPresenter : DockableToolwindowPresenter, IParserErrorsPresenter
     {
+        private readonly IVBE _vbe;
+
         public ParserErrorsPresenter(IVBE vbe, IAddIn addin) 
             : base(vbe, addin, new SimpleListControl(RubberduckUI.ParseErrors_Caption), null)
         {
+            _vbe = vbe;
             _source = new BindingList<ParseErrorListItem>();
             var control = UserControl as SimpleListControl;
             Debug.Assert(control != null);
@@ -29,7 +32,7 @@ public ParserErrorsPresenter(IVBE vbe, IAddIn addin)
         private void Control_Navigate(object sender, ListItemActionEventArgs e)
         {
             var selection = (ParseErrorListItem) e.SelectedItem;
-            selection.Navigate();
+            selection.Navigate(_vbe);
         }
 
         private readonly IBindingList _source;

Rubberduck.Parsing/VBA/ParseErrorEventArgs.cs

@@ -1,5 +1,4 @@
 using System;
-using Rubberduck.Parsing.Symbols;
 using Rubberduck.Parsing.VBA.Parsing.ParsingExceptions;
 using Rubberduck.VBEditor;
 using Rubberduck.VBEditor.SafeComWrappers.Abstract;
@@ -8,38 +7,33 @@ namespace Rubberduck.Parsing.VBA
 {
     public class ParseErrorEventArgs : EventArgs
     {
-        public ParseErrorEventArgs(SyntaxErrorException exception, IVBComponent component)
+        private readonly QualifiedModuleName _moduleName;
+
+        public ParseErrorEventArgs(SyntaxErrorException exception, QualifiedModuleName moduleName)
         {
-            _exception = exception;
-            _component = component;
+            Exception = exception;
+            _moduleName = moduleName;
         }
 
-        private readonly SyntaxErrorException _exception;
-        public SyntaxErrorException Exception { get { return _exception; } }
+        public SyntaxErrorException Exception { get; }
+
+        public string ComponentName => _moduleName.ComponentName;
+        public string ProjectName => _moduleName.ProjectName;
 
-        private readonly IVBComponent _component;
-        public string ComponentName { get { return _component.Name; } }
-        public string ProjectName
+        public void Navigate(IVBE vbe)
         {
-            get
+            var selection = new Selection(Exception.LineNumber, Exception.Position, Exception.LineNumber, Exception.Position + Exception.OffendingSymbol.Text.Length - 1);
+            
+            if (!_moduleName.TryGetComponent(vbe, out var component))
             {
-                using (var collection = _component.Collection)
-                using (var parent = collection.Parent)
-                {
-                    return parent.Name;
-                }
+                return;
             }
-        }
 
-        public void Navigate()
-        {
-            var selection = new Selection(_exception.LineNumber, _exception.Position, _exception.LineNumber, _exception.Position + _exception.OffendingSymbol.Text.Length - 1);
-            using (var module = _component.CodeModule)
+            using (component)
+            using (var module = component.CodeModule)
+            using (var pane = module.CodePane)
             {
-                using (var pane = module.CodePane)
-                {
-                    pane.Selection = selection;
-                }
+                pane.Selection = selection;
             }
         }
     }

Rubberduck.VBEEditor/QualifiedModuleName.cs

@@ -149,4 +149,44 @@ public override bool Equals(object obj)
             return !a.Equals(b);
         }
     }
+
+    public static class QualifiedModuleNameExtensions
+    {
+
+        public static bool TryGetProject(this QualifiedModuleName moduleName, IVBE vbe, out IVBProject project)
+        {
+            using (var projects = vbe.VBProjects)
+            {
+                foreach (var item in projects)
+                {
+                    if (item.ProjectId == moduleName.ProjectId && item.Name == moduleName.ProjectName)
+                    {
+                        project = item;
+                        return true;
+                    }
+
+                    item.Dispose();
+                }
+
+                project = null;
+                return false;
+            }
+        }
+
+        public static bool TryGetComponent(this QualifiedModuleName moduleName, IVBE vbe, out IVBComponent component)
+        {
+            if (TryGetProject(moduleName, vbe, out var project))
+            {
+                using (project)
+                using (var components = project.VBComponents)
+                {
+                    component = components[moduleName.ComponentName];
+                    return true;
+                }
+            }
+
+            component = null;
+            return false;
+        }
+    }
 }