More tests, bug fix

Author: Hosch250

RetailCoder.VBE/UI/Settings/TodoSettingPresenter.cs

@@ -50,8 +50,8 @@ private void AddMarker(object sender, EventArgs e)
 
         private void AddMarkerTextChanged(object sender, EventArgs e)
         {
-            _addTodoMarkerView.IsValidMarker = _view.TodoMarkers.All(t => t.Text != _addTodoMarkerView.MarkerText.ToUpper()) && 
-                                               _addTodoMarkerView.MarkerText != string.Empty;
+            _addTodoMarkerView.IsValidMarker = _view.TodoMarkers.All(t => t.Text.Equals(_addTodoMarkerView.MarkerText, StringComparison.CurrentCultureIgnoreCase) && 
+                                               _addTodoMarkerView.MarkerText != string.Empty);
         }
 
         private void ConfirmAddMarker(object sender, EventArgs e)

RubberduckTests/TodoControllerTests.cs

@@ -44,7 +44,6 @@ public void ViewTextIsNotNullOrEmptyAfterControllerConstruction()
             var markers = new List<ToDoMarker> {new ToDoMarker("Todo:", TodoPriority.Medium)};
 
             var view = new TodoListSettingsUserControl(markers, new Mock<GridViewSort<ToDoMarker>>("", false).Object);
-            var addTodoMarkerView = new Mock<IAddTodoMarkerView>().Object;
 
             //assert
             Assert.AreEqual("Todo:", view.ActiveMarkerText);
@@ -128,5 +127,45 @@ public void RemoveReallyDoesRemoveSelectedItem()
 
             Assert.AreEqual(2, view.Object.TodoMarkers.Count);
         }
+
+        [TestMethod]
+        public void AddReallyDoesDisplayAddMarkerWindow()
+        {
+            var markers = GetTestMarkers();
+
+            var addView = new Mock<IAddTodoMarkerView>();
+
+            var view = new Mock<ITodoSettingsView>();
+            view.SetupProperty(v => v.TodoMarkers, new BindingList<ToDoMarker>(markers));
+
+            // Shut up R#, I need that to process the event
+            // ReSharper disable once UnusedVariable
+            var presenter = new TodoSettingPresenter(view.Object, addView.Object);
+
+            view.Raise(v => v.AddMarker += null, EventArgs.Empty);
+
+            addView.Verify(a => a.Show(), Times.Once());
+        }
+
+        [TestMethod]
+        public void AddReallyDoesBlockExistingNames()
+        {
+            var markers = GetTestMarkers();
+
+            var addView = new Mock<IAddTodoMarkerView>();
+            addView.SetupProperty(a => a.MarkerText, "TODO:");
+            addView.SetupProperty(a => a.IsValidMarker);
+
+            var view = new Mock<ITodoSettingsView>();
+            view.SetupProperty(v => v.TodoMarkers, new BindingList<ToDoMarker>(markers));
+
+            // Shut up R#, I need that to process the event
+            // ReSharper disable once UnusedVariable
+            var presenter = new TodoSettingPresenter(view.Object, addView.Object);
+
+            addView.Raise(a => a.TextChanged += null, EventArgs.Empty);
+
+            Assert.AreEqual(false, addView.Object.IsValidMarker);
+        }
     }
 }