Make the VBERuntime in the ComMessagePumper use lazy initialization instead of that weird funky homebrewn static/instance construction.

Make DetermineVersion static.

Author: bclothier

Rubberduck.VBEEditor/ComManagement/ComMessagePumper.cs

@@ -7,16 +7,14 @@ namespace Rubberduck.VBEditor.ComManagement
     public static class ComMessagePumper
     {
         private static SynchronizationContext UiContext { get; set; }
-        private static IVBERuntime Runtime { get; set; }
+        private static readonly Lazy<IVBERuntime> Runtime = new Lazy<IVBERuntime>(() => new VBERuntimeAccessor());
 
         public static void Initialize()
         {
             if (UiContext == null)
             {
                 UiContext = SynchronizationContext.Current;
             }
-
-            Runtime = new VBERuntimeAccessor();
         }
 
         /// <summary>
@@ -37,7 +35,7 @@ public static int PumpMessages()
         {
             CheckContext();
 
-            return Runtime.DoEvents();
+            return Runtime.Value.DoEvents();
         }
 
         private static void CheckContext()

Rubberduck.VBEEditor/ComManagement/VBERuntime/VBERuntimeAccessor.cs

@@ -35,7 +35,7 @@ public VBERuntimeAccessor()
             }
         }
 
-        private IVBERuntime DetermineVersion()
+        private static IVBERuntime DetermineVersion()
         {
             IVBERuntime runtime;
             try