actually dispose the designer

MDoerner · MDoerner · commit 4fd5ed8a9923 · 2018-01-07T23:49:07.000+01:00
diff --git a/Rubberduck.VBEEditor/SafeComWrappers/VBA/VBComponent.cs b/Rubberduck.VBEEditor/SafeComWrappers/VBA/VBComponent.cs
@@ -41,27 +41,29 @@ public IControls Controls
         {
             get
             {
-                var designer = IsWrappingNullReference
+                using (var designer = IsWrappingNullReference
                     ? null
-                    : new UserForm(Target.Designer as VB.Forms.UserForm);
-
-                return designer == null 
-                    ? new Controls(null) 
-                    : designer.Controls;
+                    : new UserForm(Target.Designer as VB.Forms.UserForm))
+                {
+                    return designer == null
+                        ? new Controls(null)
+                        : designer.Controls;
+                }
             }
         }
 
         public IControls SelectedControls
         {
             get
             {
-                var designer = IsWrappingNullReference
+                using (var designer = IsWrappingNullReference
                     ? null
-                    : new UserForm(Target.Designer as VB.Forms.UserForm);
-
-                return designer == null
-                    ? new Controls(null)
-                    : designer.Selected;
+                    : new UserForm(Target.Designer as VB.Forms.UserForm))
+                {
+                    return designer == null
+                        ? new Controls(null)
+                        : designer.Selected;
+                }
             }
         }
         

Original file line number	Diff line number	Diff line change
`@@ -41,27 +41,29 @@ public IControls Controls`
`41`	`41`	`{`
`42`	`42`	`get`
`43`	`43`	`{`
`44`		`- var designer = IsWrappingNullReference`
	`44`	`+ using (var designer = IsWrappingNullReference`
`45`	`45`	`? null`
`46`		`- : new UserForm(Target.Designer as VB.Forms.UserForm);`
`47`		`-`
`48`		`- return designer == null`
`49`		`- ? new Controls(null)`
`50`		`- : designer.Controls;`
	`46`	`+ : new UserForm(Target.Designer as VB.Forms.UserForm))`
	`47`	`+ {`
	`48`	`+ return designer == null`
	`49`	`+ ? new Controls(null)`
	`50`	`+ : designer.Controls;`
	`51`	`+ }`
`51`	`52`	`}`
`52`	`53`	`}`
`53`	`54`
`54`	`55`	`public IControls SelectedControls`
`55`	`56`	`{`
`56`	`57`	`get`
`57`	`58`	`{`
`58`		`- var designer = IsWrappingNullReference`
	`59`	`+ using (var designer = IsWrappingNullReference`
`59`	`60`	`? null`
`60`		`- : new UserForm(Target.Designer as VB.Forms.UserForm);`
`61`		`-`
`62`		`- return designer == null`
`63`		`- ? new Controls(null)`
`64`		`- : designer.Selected;`
	`61`	`+ : new UserForm(Target.Designer as VB.Forms.UserForm))`
	`62`	`+ {`
	`63`	`+ return designer == null`
	`64`	`+ ? new Controls(null)`
	`65`	`+ : designer.Selected;`
	`66`	`+ }`
`65`	`67`	`}`
`66`	`68`	`}`
`67`	`69`