Add ImplicitlyTypedConstInspection and tests

Author: IvenBach

Rubberduck.CodeAnalysis/Inspections/Concrete/ImplicitlyTypedConstInspection.cs

@@ -0,0 +1,43 @@
+using System.Collections.Generic;
+using System.Linq;
+using Rubberduck.Inspections.Abstract;
+using Rubberduck.Parsing.VBA;
+using Rubberduck.Parsing.Inspections.Abstract;
+using Rubberduck.Inspections.Results;
+using Rubberduck.Parsing.Symbols;
+
+namespace Rubberduck.CodeAnalysis.Inspections.Concrete
+{
+    public sealed class ImplicitlyTypedConstInspection : InspectionBase
+    {
+        public ImplicitlyTypedConstInspection(RubberduckParserState state)
+            : base(state) { }
+
+        protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
+        {
+            var declarationFinder = State.DeclarationFinder;
+
+            var implicitlyTypedConsts = declarationFinder.AllDeclarations
+                .Where(declaration => declaration.DeclarationType == DeclarationType.Constant
+                    && declaration.AsTypeContext == null);
+
+            return implicitlyTypedConsts.Select(Result);
+        }
+
+        private IInspectionResult Result(Declaration declaration)
+        {
+            return new IdentifierReferenceInspectionResult(
+                this,
+                declaration.DescriptionString,
+                State,
+                new IdentifierReference(
+                    declaration.QualifiedModuleName,
+                    declaration.ParentScopeDeclaration,
+                    declaration.ParentDeclaration,
+                    declaration.IdentifierName,
+                    declaration.Selection,
+                    declaration.Context,
+                    declaration));
+        }
+    }
+}

RubberduckTests/Inspections/ImplicitlyTypedConstInspectionTests.cs

@@ -0,0 +1,61 @@
+using System.Linq;
+using NUnit.Framework;
+using Rubberduck.CodeAnalysis.Inspections.Concrete;
+using Rubberduck.Parsing.Inspections.Abstract;
+using Rubberduck.Parsing.VBA;
+using Rubberduck.VBEditor.SafeComWrappers;
+
+namespace RubberduckTests.Inspections
+{
+    [TestFixture]
+    public class ImplicitlyTypedConstInspectionTests : InspectionTestsBase
+    {
+        [Test]
+        [Category("Inspections")]
+        public void InspectionName()
+        {
+            var inspection = new ImplicitlyTypedConstInspection(null);
+
+            var expected = nameof(ImplicitlyTypedConstInspection);
+            var actual = inspection.Name;
+            Assert.AreEqual(expected, actual);
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ImplicitlyTypedConst_ReturnsResult()
+        {
+            const string inputCode =
+@"Public Sub Foo()
+    Const bar = 0
+End Sub";
+
+            const int expected = 1;
+
+            var results = InspectionResultsForModules(("FooClass", inputCode, ComponentType.ClassModule));
+            var actual = results.Count();
+            Assert.AreEqual(expected , actual);
+        }
+
+        [Test]
+        [Category("Inspections")]
+        public void ImplicitlyTypedConst_DoesNotReturnResult()
+        {
+            const string inputCode =
+@"Public Sub Foo()
+    Const bar As Long = 0
+End Sub";
+
+            const int expected = 0;
+
+            var results = InspectionResultsForModules(("FooClass", inputCode, ComponentType.ClassModule));
+            var actual = results.Count();
+            Assert.AreEqual(expected, actual);
+        }
+
+        protected override IInspection InspectionUnderTest(RubberduckParserState state)
+        {
+            return new ImplicitlyTypedConstInspection(state);
+        }
+    }
+}