Address review

Author: Hosch250

Rubberduck.CodeAnalysis/Inspections/Concrete/UnderscoreInPublicClassModuleMemberInspection.cs

@@ -18,7 +18,7 @@ protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
             var names = State.DeclarationFinder.UserDeclarations(Parsing.Symbols.DeclarationType.Member)
                 .Where(w => w.ParentDeclaration.DeclarationType == Parsing.Symbols.DeclarationType.ClassModule)
                 .Where(w => !State.DeclarationFinder.FindAllInterfaceImplementingMembers().Contains(w))
-                .Where(w => w.Accessibility == Parsing.Symbols.Accessibility.Public)
+                .Where(w => w.Accessibility == Parsing.Symbols.Accessibility.Public || w.Accessibility == Parsing.Symbols.Accessibility.Implicit)
                 .Where(w => w.IdentifierName.Contains('_'))
                 .ToList();
 

Rubberduck.Resources/Inspections/InspectionInfo.Designer.cs

@@ -350,6 +350,6 @@ If the parameter can be null, ignore this inspection result; passing a null valu
     <value>An assignment is immediately overridden by another assignment or is never referenced.</value>
   </data>
   <data name="UnderscoreInPublicClassModuleMemberInspection" xml:space="preserve">
-    <value>A class module with public members with underscores cannot implement interfaces that do not expose said member.</value>
+    <value>A class module that contains members with underscores cannot be implemented by other classes. The underscore is used as a separator between the interface/object name and the implemented member name: having an underscore in the member name confuses the compiler, which then refuses to compile the project. Avoid underscores in public member names by following a 'PascalCase' naming convention.</value>
   </data>
 </root>

Rubberduck.Resources/Inspections/InspectionInfo.resx

@@ -379,6 +379,6 @@
     <value>An assignment is immediately overridden by another assignment or is never referenced.</value>
   </data>
   <data name="UnderscoreInPublicClassModuleMemberInspection" xml:space="preserve">
-    <value>Public member '{0}' has underscore in name.</value>
+    <value>Public member name '{0}' contains an underscore.</value>
   </data>
 </root>

Rubberduck.Resources/Inspections/InspectionResults.Designer.cs

@@ -132,7 +132,7 @@ public void Implicit_WithUnderscore()
                 var inspector = InspectionsHelper.GetInspector(inspection);
                 var inspectionResults = inspector.FindIssuesAsync(state, CancellationToken.None).Result;
 
-                Assert.AreEqual(0, inspectionResults.Count());
+                Assert.AreEqual(1, inspectionResults.Count());
             }
         }