Merge pull request #3887 from bclothier/BuildRegistryWithWix

Installer no longer removes user settings. If this comes up as an issue, let it be by-design.

Author: retailcoder

Rubberduck.Deployment/InnoSetup/Installer Build Script.iss

@@ -103,8 +103,11 @@ Source: "{#IncludesDir}Rubberduck.RegisterAddIn.reg"; DestDir: "{app}"; Flags: i
 ; Use [Code] section (RegisterAddIn procedure) to register the entries instead.
 #include <Rubberduck.reg.iss>
 
-[UninstallDelete]
-Type: filesandordirs; Name: "{userappdata}\{#AppName}"
+; Commneted out because we don't want to delete users setting when they are just
+; uninstalling to install another version of Rubberduck. Considered prompting to
+; delete but not for right now. 
+; [UninstallDelete]
+; Type: filesandordirs; Name: "{userappdata}\{#AppName}"
 
 [CustomMessages]
 ; TODO add additional languages here by adding include files in \Includes folder
@@ -1063,5 +1066,8 @@ end;
 ///</remarks>
 procedure CurUninstallStepChanged(CurUninstallStep: TUninstallStep);
 begin
-  if CurUninstallStep = usUninstall then UnregisterAddin();
+  if CurUninstallStep = usUninstall then
+  begin
+    UnregisterAddin();
+  end;
 end;