Merge pull request #3477 from IpshitaC/IpshitaC-hacktoberfest

retailcoder · web-flow · commit 4d72489e5579 · 2017-10-17T12:47:08.000-04:00
Changed inspection type for 'empty block' inspections
diff --git a/Rubberduck.Inspections/Concrete/EmptyCaseBlockInspection.cs b/Rubberduck.Inspections/Concrete/EmptyCaseBlockInspection.cs
@@ -19,7 +19,7 @@ public EmptyCaseBlockInspection(RubberduckParserState state)
         public override IInspectionListener Listener { get; } =
             new EmptyCaseBlockListener();
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
+        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Concrete/EmptyDoWhileBlockInspection.cs b/Rubberduck.Inspections/Concrete/EmptyDoWhileBlockInspection.cs
@@ -16,7 +16,7 @@ internal class EmptyDoWhileBlockInspection : ParseTreeInspectionBase
         public EmptyDoWhileBlockInspection(RubberduckParserState state)
             : base(state, CodeInspectionSeverity.Suggestion) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
+        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Concrete/EmptyElseBlockInspection.cs b/Rubberduck.Inspections/Concrete/EmptyElseBlockInspection.cs
@@ -16,7 +16,7 @@ internal class EmptyElseBlockInspection : ParseTreeInspectionBase
         public EmptyElseBlockInspection(RubberduckParserState state)
             : base(state, CodeInspectionSeverity.DoNotShow) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
+        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
@@ -38,4 +38,4 @@ public override void EnterElseBlock([NotNull] VBAParser.ElseBlockContext context
             }
         }
     }
-}
+}
diff --git a/Rubberduck.Inspections/Concrete/EmptyForEachBlockInspection.cs b/Rubberduck.Inspections/Concrete/EmptyForEachBlockInspection.cs
@@ -16,7 +16,7 @@ internal class EmptyForEachBlockInspection : ParseTreeInspectionBase
         public EmptyForEachBlockInspection(RubberduckParserState state)
             : base(state, CodeInspectionSeverity.DoNotShow) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
+        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
@@ -38,4 +38,4 @@ public override void EnterForEachStmt([NotNull] VBAParser.ForEachStmtContext con
             }
         }
     }
-}
+}
diff --git a/Rubberduck.Inspections/Concrete/EmptyForLoopBlockInspection.cs b/Rubberduck.Inspections/Concrete/EmptyForLoopBlockInspection.cs
@@ -16,7 +16,7 @@ internal class EmptyForLoopBlockInspection : ParseTreeInspectionBase
         public EmptyForLoopBlockInspection(RubberduckParserState state)
             : base(state, CodeInspectionSeverity.DoNotShow) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
+        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Concrete/EmptyIfBlockInspection.cs b/Rubberduck.Inspections/Concrete/EmptyIfBlockInspection.cs
@@ -18,7 +18,7 @@ internal class EmptyIfBlockInspection : ParseTreeInspectionBase
         public EmptyIfBlockInspection(RubberduckParserState state)
             : base(state, CodeInspectionSeverity.DoNotShow) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
+        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
diff --git a/Rubberduck.Inspections/Concrete/EmptyWhileWendBlockInspection.cs b/Rubberduck.Inspections/Concrete/EmptyWhileWendBlockInspection.cs
@@ -16,7 +16,7 @@ internal class EmptyWhileWendBlockInspection : ParseTreeInspectionBase
         public EmptyWhileWendBlockInspection(RubberduckParserState state)
             : base(state, CodeInspectionSeverity.DoNotShow) { }
 
-        public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;
+        public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
         protected override IEnumerable<IInspectionResult> DoGetInspectionResults()
         {
diff --git a/RubberduckTests/Inspections/EmptyCaseBlockInspectionTests.cs b/RubberduckTests/Inspections/EmptyCaseBlockInspectionTests.cs
@@ -15,7 +15,7 @@ public class EmptyCaseBlockInspectionTests
         public void EmptyCaseBlock_InspectionType()
         {
             var inspection = new EmptyCaseBlockInspection(null);
-            var expectedInspection = CodeInspectionType.CodeQualityIssues;
+            var expectedInspection = CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
             Assert.AreEqual(expectedInspection, inspection.InspectionType);
         }
diff --git a/RubberduckTests/Inspections/EmptyDoWhileBlockInspectionTests.cs b/RubberduckTests/Inspections/EmptyDoWhileBlockInspectionTests.cs
@@ -16,7 +16,7 @@ public class EmptyDoWhileBlockInspectionTests
         public void EmptyDoWhileBlock_InspectionType()
         {
             var inspection = new EmptyDoWhileBlockInspection(null);
-            var expectedInspection = CodeInspectionType.CodeQualityIssues;
+            var expectedInspection = CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
             Assert.AreEqual(expectedInspection, inspection.InspectionType);
         }
diff --git a/RubberduckTests/Inspections/EmptyElseBlockInspectionTests.cs b/RubberduckTests/Inspections/EmptyElseBlockInspectionTests.cs
@@ -15,7 +15,7 @@ public class EmptyElseBlockInspectionTests
         public void InspectionType()
         {
             var inspection = new EmptyElseBlockInspection(null);
-            var expectedInspection = CodeInspectionType.CodeQualityIssues;
+            var expectedInspection = CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
             Assert.AreEqual(expectedInspection, inspection.InspectionType);
         }
@@ -234,4 +234,4 @@ End If
             Assert.AreEqual(expectedCount, actualResults.Count());
         }
     }
-}
+}
diff --git a/RubberduckTests/Inspections/EmptyForEachBlockInspectionTests.cs b/RubberduckTests/Inspections/EmptyForEachBlockInspectionTests.cs
@@ -16,7 +16,7 @@ public class EmptyForEachInspectionTests
         public void EmptyForEachBlock_InspectionType()
         {
             var inspection = new EmptyForEachBlockInspection(null);
-            var expectedInspection = CodeInspectionType.CodeQualityIssues;
+            var expectedInspection = CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
             Assert.AreEqual(expectedInspection, inspection.InspectionType);
         }
diff --git a/RubberduckTests/Inspections/EmptyForLoopBlockInspectionTests.cs b/RubberduckTests/Inspections/EmptyForLoopBlockInspectionTests.cs
@@ -15,7 +15,7 @@ public class EmptyForLoopBlockInspectionTests
         public void EmptyForLoopBlock_InspectionType()
         {
             var inspection = new EmptyForLoopBlockInspection(null);
-            var expectedInspection = CodeInspectionType.CodeQualityIssues;
+            var expectedInspection = CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
             Assert.AreEqual(expectedInspection, inspection.InspectionType);
         }
diff --git a/RubberduckTests/Inspections/EmptyWhileWendBlockInspectionTests.cs b/RubberduckTests/Inspections/EmptyWhileWendBlockInspectionTests.cs
@@ -15,7 +15,7 @@ public class EmptyWhileWendBlockInspectionTests
         public void EmptyWhileWendBlock_InspectionType()
         {
             var inspection = new EmptyWhileWendBlockInspection(null);
-            var expectedInspection = CodeInspectionType.CodeQualityIssues;
+            var expectedInspection = CodeInspectionType.MaintainabilityAndReadabilityIssues;
 
             Assert.AreEqual(expectedInspection, inspection.InspectionType);
         }

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ public EmptyCaseBlockInspection(RubberduckParserState state)`
`19`	`19`	`public override IInspectionListener Listener { get; } =`
`20`	`20`	`new EmptyCaseBlockListener();`
`21`	`21`
`22`		`- public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;`
	`22`	`+ public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;`
`23`	`23`
`24`	`24`	`protected override IEnumerable<IInspectionResult> DoGetInspectionResults()`
`25`	`25`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ internal class EmptyDoWhileBlockInspection : ParseTreeInspectionBase`
`16`	`16`	`public EmptyDoWhileBlockInspection(RubberduckParserState state)`
`17`	`17`	`: base(state, CodeInspectionSeverity.Suggestion) { }`
`18`	`18`
`19`		`- public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;`
	`19`	`+ public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;`
`20`	`20`
`21`	`21`	`protected override IEnumerable<IInspectionResult> DoGetInspectionResults()`
`22`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ internal class EmptyElseBlockInspection : ParseTreeInspectionBase`
`16`	`16`	`public EmptyElseBlockInspection(RubberduckParserState state)`
`17`	`17`	`: base(state, CodeInspectionSeverity.DoNotShow) { }`
`18`	`18`
`19`		`- public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;`
	`19`	`+ public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;`
`20`	`20`
`21`	`21`	`protected override IEnumerable<IInspectionResult> DoGetInspectionResults()`
`22`	`22`	`{`
`@@ -38,4 +38,4 @@ public override void EnterElseBlock([NotNull] VBAParser.ElseBlockContext context`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`	`}`
`41`		`-}`
	`41`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ internal class EmptyForEachBlockInspection : ParseTreeInspectionBase`
`16`	`16`	`public EmptyForEachBlockInspection(RubberduckParserState state)`
`17`	`17`	`: base(state, CodeInspectionSeverity.DoNotShow) { }`
`18`	`18`
`19`		`- public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;`
	`19`	`+ public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;`
`20`	`20`
`21`	`21`	`protected override IEnumerable<IInspectionResult> DoGetInspectionResults()`
`22`	`22`	`{`
`@@ -38,4 +38,4 @@ public override void EnterForEachStmt([NotNull] VBAParser.ForEachStmtContext con`
`38`	`38`	`}`
`39`	`39`	`}`
`40`	`40`	`}`
`41`		`-}`
	`41`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ internal class EmptyIfBlockInspection : ParseTreeInspectionBase`
`18`	`18`	`public EmptyIfBlockInspection(RubberduckParserState state)`
`19`	`19`	`: base(state, CodeInspectionSeverity.DoNotShow) { }`
`20`	`20`
`21`		`- public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;`
	`21`	`+ public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;`
`22`	`22`
`23`	`23`	`protected override IEnumerable<IInspectionResult> DoGetInspectionResults()`
`24`	`24`	`{`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ internal class EmptyWhileWendBlockInspection : ParseTreeInspectionBase`
`16`	`16`	`public EmptyWhileWendBlockInspection(RubberduckParserState state)`
`17`	`17`	`: base(state, CodeInspectionSeverity.DoNotShow) { }`
`18`	`18`
`19`		`- public override CodeInspectionType InspectionType => CodeInspectionType.CodeQualityIssues;`
	`19`	`+ public override CodeInspectionType InspectionType => CodeInspectionType.MaintainabilityAndReadabilityIssues;`
`20`	`20`
`21`	`21`	`protected override IEnumerable<IInspectionResult> DoGetInspectionResults()`
`22`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public class EmptyCaseBlockInspectionTests`
`15`	`15`	`public void EmptyCaseBlock_InspectionType()`
`16`	`16`	`{`
`17`	`17`	`var inspection = new EmptyCaseBlockInspection(null);`
`18`		`- var expectedInspection = CodeInspectionType.CodeQualityIssues;`
	`18`	`+ var expectedInspection = CodeInspectionType.MaintainabilityAndReadabilityIssues;`
`19`	`19`
`20`	`20`	`Assert.AreEqual(expectedInspection, inspection.InspectionType);`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ public class EmptyDoWhileBlockInspectionTests`
`16`	`16`	`public void EmptyDoWhileBlock_InspectionType()`
`17`	`17`	`{`
`18`	`18`	`var inspection = new EmptyDoWhileBlockInspection(null);`
`19`		`- var expectedInspection = CodeInspectionType.CodeQualityIssues;`
	`19`	`+ var expectedInspection = CodeInspectionType.MaintainabilityAndReadabilityIssues;`
`20`	`20`
`21`	`21`	`Assert.AreEqual(expectedInspection, inspection.InspectionType);`
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ public class EmptyElseBlockInspectionTests`
`15`	`15`	`public void InspectionType()`
`16`	`16`	`{`
`17`	`17`	`var inspection = new EmptyElseBlockInspection(null);`
`18`		`- var expectedInspection = CodeInspectionType.CodeQualityIssues;`
	`18`	`+ var expectedInspection = CodeInspectionType.MaintainabilityAndReadabilityIssues;`
`19`	`19`
`20`	`20`	`Assert.AreEqual(expectedInspection, inspection.InspectionType);`
`21`	`21`	`}`
`@@ -234,4 +234,4 @@ End If`
`234`	`234`	`Assert.AreEqual(expectedCount, actualResults.Count());`
`235`	`235`	`}`
`236`	`236`	`}`
`237`		`-}`
	`237`	`+}`