Merge pull request #1847 from Hosch250/Issue1845

Fix Implicit Reference to Active Sheet Inspection

Author: retailcoder

RetailCoder.VBE/Inspections/ImplicitActiveSheetReferenceInspection.cs

@@ -36,7 +36,9 @@ public override IEnumerable<InspectionResultBase> GetInspectionResults()
             }
 
             var matches = BuiltInDeclarations.Where(item =>
-                Targets.Contains(item.IdentifierName)).ToList();
+                        Targets.Contains(item.IdentifierName) &&
+                        item.ParentScope == "EXCEL.EXE;Excel._Global" &&
+                        item.AsTypeName == "Range").ToList();
 
             var issues = matches.Where(item => item.References.Any())
                 .SelectMany(declaration => declaration.References);

Rubberduck.Parsing/Symbols/ClassModuleDeclaration.cs

@@ -104,6 +104,19 @@ public bool IsGlobalClassModule
                     attributeIsGlobalClassModule = value.Single() == "True";
                 }
                 _isGlobal = attributeIsGlobalClassModule;
+
+                if (!_isGlobal.Value)
+                {
+                    foreach (var type in Subtypes)
+                    {
+                        if (type is ClassModuleDeclaration && ((ClassModuleDeclaration) type).IsGlobalClassModule)
+                        {
+                            _isGlobal = true;
+                            break;
+                        }
+                    }
+                }
+
                 return _isGlobal.Value;
             }
         }

Rubberduck.Parsing/Symbols/ReferencedDeclarationsCollector.cs

@@ -207,6 +207,11 @@ public List<Declaration> GetDeclarationsForReference(Reference reference)
                     attributes.AddPredeclaredIdTypeAttribute();
                 }
 
+                if (typeAttributes.wTypeFlags.HasFlag(TYPEFLAGS.TYPEFLAG_FAPPOBJECT))
+                {
+                    attributes.AddGlobalClassAttribute();
+                }
+
                 Declaration moduleDeclaration;
                 switch (typeDeclarationType)
                 {

Rubberduck.Parsing/VBA/Attributes.cs

@@ -39,5 +39,10 @@ public void AddPredeclaredIdTypeAttribute()
         {
             Add("VB_PredeclaredId", new[] {"True"});
         }
+
+        public void AddGlobalClassAttribute()
+        {
+            Add("VB_GlobalNamespace", new[] {"True"});
+        }
     }
 }