Skip to content

Commit 49ee629

Browse files
committed
changed Selection.ToString to a culture-neutral implementation
1 parent b16b9c8 commit 49ee629

File tree

4 files changed

+8
-7
lines changed

4 files changed

+8
-7
lines changed

RetailCoder.VBE/UI/Controls/SearchView.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
SelectedItem="{Binding SelectedItem}">
4343
<DataGrid.Columns>
4444
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=SearchResults_MemberName}" Binding="{Binding QualifiedMemberName.MemberName}" />
45-
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=SearchResults_Line}" Binding="{Binding Selection.StartLine}" />
45+
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=SearchResults_Location}" Binding="{Binding Selection}" />
4646
<DataGridTextColumn Header="{Resx ResxName=Rubberduck.UI.RubberduckUI, Key=SearchResults_Context}" Binding="{Binding ResultText}" Width="*" />
4747
</DataGrid.Columns>
4848
</controls:GroupingGrid>

RetailCoder.VBE/UI/RubberduckUI.Designer.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

RetailCoder.VBE/UI/RubberduckUI.resx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1317,8 +1317,9 @@ All our stargazers, likers &amp; followers, for the warm fuzzies
13171317
<data name="SearchResults_Caption" xml:space="preserve">
13181318
<value>Search Results</value>
13191319
</data>
1320-
<data name="SearchResults_Line" xml:space="preserve">
1321-
<value>Line</value>
1320+
<data name="SearchResults_Location" xml:space="preserve">
1321+
<value>Location</value>
1322+
<comment>The applicable selection, in L1C1 notation</comment>
13221323
</data>
13231324
<data name="SearchResults_MemberName" xml:space="preserve">
13241325
<value>Member</value>

Rubberduck.VBEEditor/Selection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public bool Equals(Selection other)
7777

7878
public override string ToString()
7979
{
80-
return string.Format("Start: L{0}C{1} End: L{2}C{3}", _startLine, _startColumn, _endLine, _endColumn);
80+
return string.Format("L{0}C{1} - L{2}C{3}", _startLine, _startColumn, _endLine, _endColumn);
8181
}
8282

8383
public override bool Equals(object obj)

0 commit comments

Comments
 (0)