Merge pull request #2080 from Hosch250/Issue2065

Restrict states allowed to run tests.  Close #2065

Author: Hosch250

RetailCoder.VBE/UI/Command/RunAllTestsCommand.cs

@@ -6,6 +6,7 @@
 using Rubberduck.UI.UnitTesting;
 using Rubberduck.UnitTesting;
 using Rubberduck.VBEditor.Extensions;
+using System.Linq;
 
 namespace Rubberduck.UI.Command
 {
@@ -27,9 +28,11 @@ public RunAllTestsCommand(VBE vbe, RubberduckParserState state, ITestEngine engi
             _state = state;
         }
 
+        private static readonly ParserState[] AllowedRunStates = { ParserState.ResolvedDeclarations, ParserState.ResolvingReferences, ParserState.Ready };
+
         protected override bool CanExecuteImpl(object parameter)
         {
-            return _vbe.IsInDesignMode();
+            return _vbe.IsInDesignMode() && AllowedRunStates.Contains(_state.Status);
         }
 
         protected override void ExecuteImpl(object parameter)

RetailCoder.VBE/UI/UnitTesting/TestExplorerViewModel.cs

@@ -84,24 +84,26 @@ private void RunCompleted(object sender, TestRunEventArgs e)
             TotalDuration = e.Duration;
         }
 
+        private static readonly ParserState[] AllowedRunStates = { ParserState.ResolvedDeclarations, ParserState.ResolvingReferences, ParserState.Ready };
+
         private bool CanExecuteRunPassedTestsCommand(object obj)
         {
-            return _vbe.IsInDesignMode() && _model.Tests.Any(test => test.Result.Outcome == TestOutcome.Succeeded);
+            return _vbe.IsInDesignMode() && AllowedRunStates.Contains(_state.Status) && _model.Tests.Any(test => test.Result.Outcome == TestOutcome.Succeeded);
         }
 
         private bool CanExecuteRunFailedTestsCommand(object obj)
         {
-            return _vbe.IsInDesignMode() && _model.Tests.Any(test => test.Result.Outcome == TestOutcome.Failed);
+            return _vbe.IsInDesignMode() && AllowedRunStates.Contains(_state.Status) && _model.Tests.Any(test => test.Result.Outcome == TestOutcome.Failed);
         }
 
         private bool CanExecuteRunNotExecutedTestsCommand(object obj)
         {
-            return _vbe.IsInDesignMode() && _model.Tests.Any(test => test.Result.Outcome == TestOutcome.Unknown);
+            return _vbe.IsInDesignMode() && AllowedRunStates.Contains(_state.Status) && _model.Tests.Any(test => test.Result.Outcome == TestOutcome.Unknown);
         }
 
         private bool CanExecuteRepeatLastRunCommand(object obj)
         {
-            return _vbe.IsInDesignMode() && _model.LastRun.Any();
+            return _vbe.IsInDesignMode() && AllowedRunStates.Contains(_state.Status) && _model.LastRun.Any();
         }
 
         public event EventHandler<EventArgs> TestCompleted;