Add a new IsError function to ParseProgressEventArgs to simplify the check for error state.

Author: bclothier

Rubberduck.Core/UnitTesting/TestEngine.cs

@@ -53,9 +53,7 @@ private void StateChangedHandler(object sender, ParserStateEventArgs e)
                 });
             }
 
-            if (_testRequested && (e.State == ParserState.ResolverError || 
-                                   e.State == ParserState.Error ||
-                                   e.State == ParserState.UnexpectedError))
+            if (_testRequested && !e.IsError)
             {
                 _testRequested = false;
             }

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -51,6 +51,11 @@ public ParserStateEventArgs(ParserState state, CancellationToken token)
 
         public ParserState State { get; }
         public CancellationToken Token { get; }
+
+        public bool IsError => (State == ParserState.ResolverError ||
+                                State == ParserState.Error ||
+                                State == ParserState.UnexpectedError);
+
     }
 
     public class RubberduckStatusMessageEventArgs : EventArgs
@@ -535,10 +540,7 @@ public ParserState GetModuleState(QualifiedModuleName module)
 
         private readonly object _statusLockObject = new object(); 
         private ParserState _status;
-        public ParserState Status
-        {
-            get => _status;
-        }
+        public ParserState Status => _status;
 
         private void SetStatusWithCancellation(ParserState value, CancellationToken token)
         {
@@ -659,7 +661,7 @@ private IReadOnlyList<UnboundMemberDeclaration> AllUnresolvedMemberDeclarationsF
         }
 
         private readonly ConcurrentBag<SerializableProject> _builtInDeclarationTrees = new ConcurrentBag<SerializableProject>();
-        public IProducerConsumerCollection<SerializableProject> BuiltInDeclarationTrees { get { return _builtInDeclarationTrees; } }
+        public IProducerConsumerCollection<SerializableProject> BuiltInDeclarationTrees => _builtInDeclarationTrees;
 
         /// <summary>
         /// Gets a copy of the collected declarations, excluding the built-in ones.