Skip to content

Commit 44ac1aa

Browse files
committed
Inverted dependency graph for Rubberduck.CodeAnalysis,
For that purpose we cleaned up Settings and their loading behaviour a bit and moved most of the interfaces relating to it into Rubberduck.SettingsProvider. The Defaults are now loaded differently, registration is probably utterly broken, though. Furthermore this extracts the CodeInspectionSettings defaults to RD.CodeAnalysis to make them accessible for the loader there.
1 parent 10adc78 commit 44ac1aa

File tree

87 files changed

+1672
-1326
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

87 files changed

+1672
-1326
lines changed

Rubberduck.CodeAnalysis/Inspections/Concrete/HungarianNotationInspection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
using System.Globalization;
33
using System.Linq;
44
using System.Text.RegularExpressions;
5+
using Rubberduck.CodeAnalysis.Settings;
56
using Rubberduck.Inspections.Abstract;
67
using Rubberduck.Inspections.Inspections.Extensions;
78
using Rubberduck.Inspections.Results;
89
using Rubberduck.Parsing.Inspections.Abstract;
910
using Rubberduck.Parsing.Symbols;
1011
using Rubberduck.Parsing.VBA;
1112
using Rubberduck.Resources;
12-
using Rubberduck.Settings;
1313
using Rubberduck.SettingsProvider;
1414

1515
namespace Rubberduck.Inspections.Concrete

Rubberduck.CodeAnalysis/Inspections/Concrete/UseMeaningfulNameInspection.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
using System.Collections.Generic;
22
using System.Globalization;
33
using System.Linq;
4+
using Rubberduck.CodeAnalysis.Settings;
45
using Rubberduck.Common;
56
using Rubberduck.Inspections.Abstract;
67
using Rubberduck.Inspections.Results;
@@ -9,7 +10,6 @@
910
using Rubberduck.Parsing.Symbols;
1011
using Rubberduck.Parsing.VBA;
1112
using Rubberduck.Resources;
12-
using Rubberduck.Settings;
1313
using Rubberduck.SettingsProvider;
1414
using static Rubberduck.Parsing.Grammar.VBAParser;
1515

Rubberduck.Core/CodeAnalysis/Inspections/InspectionProvider.cs renamed to Rubberduck.CodeAnalysis/Inspections/InspectionProvider.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,15 @@
22
using System.Linq;
33
using Rubberduck.Parsing.Inspections.Abstract;
44
using Rubberduck.Settings;
5+
using Rubberduck.CodeAnalysis.Settings;
56

67
namespace Rubberduck.CodeAnalysis.Inspections
78
{
89
public class InspectionProvider : IInspectionProvider
910
{
1011
public InspectionProvider(IEnumerable<IInspection> inspections)
1112
{
12-
var defaultSettings = new DefaultSettings<CodeInspectionSettings>().Default;
13+
var defaultSettings = new DefaultSettings<CodeInspectionSettings, Properties.CodeInspectionDefaults>().Default;
1314
var defaultNames = defaultSettings.CodeInspections.Select(x => x.Name);
1415
var defaultInspections = inspections.Where(inspection => defaultNames.Contains(inspection.Name));
1516

0 commit comments

Comments
 (0)