Skip to content

Commit 444f98e

Browse files
committed
added constructor, kept Children readonly :)
1 parent ef1ad16 commit 444f98e

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

Rubberduck.Parsing/Symbols/SerializableDeclaration.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,14 @@ public class SerializableDeclarationTree
1414
public readonly SerializableDeclaration Node;
1515

1616
[DataMember(IsRequired = true)]
17-
public IEnumerable<SerializableDeclarationTree> Children;
17+
public readonly IEnumerable<SerializableDeclarationTree> Children;
1818

1919
public SerializableDeclarationTree(Declaration declaration)
2020
: this(new SerializableDeclaration(declaration)) { }
2121

22+
public SerializableDeclarationTree(Declaration declaration, IEnumerable<SerializableDeclarationTree> children)
23+
: this(new SerializableDeclaration(declaration), children) { }
24+
2225
public SerializableDeclarationTree(SerializableDeclaration node)
2326
: this(node, Enumerable.Empty<SerializableDeclarationTree>()) { }
2427

Rubberduck.Parsing/VBA/RubberduckParser.cs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,6 @@ private void SyncComReferences(IReadOnlyList<IVBProject> projects)
499499

500500
private SerializableDeclarationTree GetSerializableTreeForDeclaration(Declaration declaration, List<Declaration> declarations)
501501
{
502-
var output = new SerializableDeclarationTree(declaration);
503502
var children = new List<SerializableDeclarationTree>();
504503
var nodes = declarations.Where(x => x.ParentDeclaration.Equals(declaration)).ToList();
505504
declarations.RemoveAll(nodes.Contains);
@@ -508,8 +507,7 @@ private SerializableDeclarationTree GetSerializableTreeForDeclaration(Declaratio
508507
children.Add(GetSerializableTreeForDeclaration(item, declarations));
509508
}
510509

511-
output.Children = children;
512-
return output;
510+
return new SerializableDeclarationTree(declaration, children);
513511
}
514512

515513
private void LoadSerializedBuiltInReferences(RubberduckParserState state)

0 commit comments

Comments
 (0)