Merge pull request #1747 from Hosch250/Issue1744

Prevent hooks from requesting a parse for each component when opening a repo

Author: retailcoder

RetailCoder.VBE/App.cs

@@ -34,6 +34,7 @@ public sealed class App : IDisposable
         private IRubberduckHooks _hooks;
         private bool _handleSinkEvents = true;
         private readonly BranchesViewViewModel _branchesVM;
+        private readonly SourceControlViewViewModel _panelVM;
 
         private readonly Logger _logger;
 
@@ -67,11 +68,14 @@ public App(VBE vbe, IMessageBox messageBox,
             _logger = LogManager.GetCurrentClassLogger();
 
             var sourceControlPanel = (SourceControlPanel) sourceControlPresenter.Window();
-            var panelVM = (SourceControlViewViewModel) sourceControlPanel.ViewModel;
-            _branchesVM = (BranchesViewViewModel) panelVM.TabItems.Single(t => t.ViewModel.Tab == SourceControlTab.Branches).ViewModel;
+            _panelVM = (SourceControlViewViewModel) sourceControlPanel.ViewModel;
+            _branchesVM = (BranchesViewViewModel) _panelVM.TabItems.Single(t => t.ViewModel.Tab == SourceControlTab.Branches).ViewModel;
 
-            _branchesVM.MergeStarted += _branchesVM_MergeStarted;
-            _branchesVM.MergeCompleted += _branchesVM_MergeCompleted;
+            _panelVM.OpenRepoStarted += DisableSinkEventHandlers;
+            _panelVM.OpenRepoCompleted += EnableSinkEventHandlersAndUpdateCache;
+
+            _branchesVM.MergeStarted += DisableSinkEventHandlers;
+            _branchesVM.MergeCompleted += EnableSinkEventHandlersAndUpdateCache;
 
             _hooks.MessageReceived += _hooks_MessageReceived;
             _configService.SettingsChanged += _configService_SettingsChanged;
@@ -94,7 +98,7 @@ public App(VBE vbe, IMessageBox messageBox,
             UiDispatcher.Initialize();
         }
 
-        private void _branchesVM_MergeCompleted(object sender, EventArgs e)
+        private void EnableSinkEventHandlersAndUpdateCache(object sender, EventArgs e)
         {
             _handleSinkEvents = true;
 
@@ -105,7 +109,7 @@ private void _branchesVM_MergeCompleted(object sender, EventArgs e)
             _parser.State.OnParseRequested(this);
         }
 
-        private void _branchesVM_MergeStarted(object sender, EventArgs e)
+        private void DisableSinkEventHandlers(object sender, EventArgs e)
         {
             _handleSinkEvents = false;
         }
@@ -446,10 +450,16 @@ public void Dispose()
                 return;
             }
 
+            if (_panelVM != null)
+            {
+                _panelVM.OpenRepoStarted -= DisableSinkEventHandlers;
+                _panelVM.OpenRepoCompleted -= EnableSinkEventHandlersAndUpdateCache;
+            }
+
             if (_branchesVM != null)
             {
-                _branchesVM.MergeStarted -= _branchesVM_MergeStarted;
-                _branchesVM.MergeCompleted -= _branchesVM_MergeCompleted;
+                _branchesVM.MergeStarted -= DisableSinkEventHandlers;
+                _branchesVM.MergeCompleted -= EnableSinkEventHandlersAndUpdateCache;
             }
 
             if (_hooks != null)

RetailCoder.VBE/UI/SourceControl/SourceControlViewViewModel.cs

@@ -391,15 +391,18 @@ private void OpenRepo()
                 var project = _vbe.ActiveVBProject;
                 var repo = new Repository(project.Name, folderPicker.SelectedPath, string.Empty);
 
+                OnOpenRepoStarted();
                 try
                 {
                     Provider = _providerFactory.CreateProvider(project, repo, _wrapperFactory);
                 }
                 catch (SourceControlException ex)
                 {
+                    OnOpenRepoCompleted();
                     ViewModel_ErrorThrown(null, new ErrorEventArgs(ex.Message, ex.InnerException.Message, NotificationType.Error));
                     return;
                 }
+                OnOpenRepoCompleted();
 
                 AddOrUpdateLocalPathConfig(repo);
 
@@ -409,6 +412,8 @@ private void OpenRepo()
 
         private void CloneRepo()
         {
+            OnOpenRepoStarted();
+
             try
             {
                 _provider = _providerFactory.CreateProvider(_vbe.ActiveVBProject);
@@ -427,6 +432,7 @@ private void CloneRepo()
                 return;
             }
 
+            OnOpenRepoCompleted();
             CloseCloneRepoGrid();
 
             SetChildPresenterSourceControlProviders(_provider);
@@ -454,6 +460,7 @@ private void OpenRepoAssignedToProject()
 
             try
             {
+                OnOpenRepoStarted();
                 Provider = _providerFactory.CreateProvider(_vbe.ActiveVBProject,
                     _config.Repositories.First(repo => repo.Name == _vbe.ActiveVBProject.Name), _wrapperFactory);
                 Status = RubberduckUI.Online;
@@ -463,6 +470,8 @@ private void OpenRepoAssignedToProject()
                 ViewModel_ErrorThrown(null, new ErrorEventArgs(ex.Message, ex.InnerException.Message, NotificationType.Error));
                 Status = RubberduckUI.Offline;
             }
+
+            OnOpenRepoCompleted();
         }
 
         private void Refresh()
@@ -590,6 +599,26 @@ public ICommand LoginGridCancelCommand
             }
         }
 
+        public event EventHandler<EventArgs> OpenRepoStarted;
+        private void OnOpenRepoStarted()
+        {
+            var handler = OpenRepoStarted;
+            if (handler != null)
+            {
+                handler(this, EventArgs.Empty);
+            }
+        }
+
+        public event EventHandler<EventArgs> OpenRepoCompleted;
+        private void OnOpenRepoCompleted()
+        {
+            var handler = OpenRepoCompleted;
+            if (handler != null)
+            {
+                handler(this, EventArgs.Empty);
+            }
+        }
+
         public void Dispose()
         {
             if (_state != null)