Linting

Author: Andrew Mansell

Rubberduck.Core/Common/WinAPI/SHCore.cs

@@ -2,10 +2,13 @@
 
 namespace Rubberduck.Common.WinAPI
 {
+    /// <summary>
+    /// Native functions from SHCore.dll
+    /// </summary>
     public static class SHCore
     {
         /// <summary>
-        /// Sets the DPI awerness level of the current process.
+        /// Sets the DPI awareness level of the current process.
         /// </summary>
         /// <param name="awareness">DPI awareness level.</param>
         /// <returns>HRESULT of S_OK, E_INVALIDARG or E_ACCESSDENIED.</returns>

Rubberduck.Core/Common/WindowsVersion.cs

@@ -2,13 +2,13 @@
 
 namespace Rubberduck.Common
 {
-    public struct WindowsVersion : IComparable<WindowsVersion>
+    public struct WindowsVersion : IComparable<WindowsVersion>, IEquatable<WindowsVersion>
     {
-        public static WindowsVersion Windows10 = new WindowsVersion(10, 0, 10240);
-        public static WindowsVersion Windows81 = new WindowsVersion(6, 3, 9200);
-        public static WindowsVersion Windows8 = new WindowsVersion(6, 2, 9200);
-        public static WindowsVersion Windows7_SP1 = new WindowsVersion(6, 1, 7601);
-        public static WindowsVersion WindowsVista_SP2 = new WindowsVersion(6, 0, 6002);
+        public static readonly WindowsVersion Windows10 = new WindowsVersion(10, 0, 10240);
+        public static readonly WindowsVersion Windows81 = new WindowsVersion(6, 3, 9200);
+        public static readonly WindowsVersion Windows8 = new WindowsVersion(6, 2, 9200);
+        public static readonly WindowsVersion Windows7_SP1 = new WindowsVersion(6, 1, 7601);
+        public static readonly WindowsVersion WindowsVista_SP2 = new WindowsVersion(6, 0, 6002);
 
         public WindowsVersion(int major, int minor, int build)
         {
@@ -21,6 +21,7 @@ public WindowsVersion(int major, int minor, int build)
         public int Minor { get; }
         public int Build { get; }
 
+
         public int CompareTo(WindowsVersion other)
         {
             var majorComparison = Major.CompareTo(other.Major);
@@ -36,6 +37,27 @@ public int CompareTo(WindowsVersion other)
                 : Build.CompareTo(other.Build);
         }
 
+        public bool Equals(WindowsVersion other)
+        {
+            return Major == other.Major && Minor == other.Minor && Build == other.Build;
+        }
+
+        public override bool Equals(object other)
+        {
+            return other is WindowsVersion otherVersion && Equals(otherVersion);
+        }
+
+        public override int GetHashCode()
+        {
+            unchecked
+            {
+                var hashCode = Major;
+                hashCode = (hashCode * 397) ^ Minor;
+                hashCode = (hashCode * 397) ^ Build;
+                return hashCode;
+            }
+        }
+
         public static bool operator ==(WindowsVersion os1, WindowsVersion os2)
         {
             return os1.CompareTo(os2) == 0;