fixed state-reporting (breaks 12 tests that involve identifier references of declarations in another module)

Author: retailcoder

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -144,17 +144,30 @@ public void SetModuleState(VBComponent component, ParserState state, SyntaxError
             Status = EvaluateParserState();
         }
 
-        //private static readonly ParserState[] States = Enum.GetValues(typeof(ParserState)).Cast<ParserState>().ToArray();
+        private static readonly ParserState[] States = Enum.GetValues(typeof(ParserState)).Cast<ParserState>().ToArray();
         private ParserState EvaluateParserState()
         {
             var moduleStates = _moduleStates.Values.ToList();
+            if (States.Any(state => moduleStates.All(module => module == state)))
+            {
+                // all modules have the same state - we're done here:
+                return moduleStates.First();
+            }
+
+            if (moduleStates.Any(module => module > ParserState.Ready)) // only states beyond "ready" are error states
+            {
+                // any error state seals the deal:
+                return moduleStates.Max();
+            }
 
-            var prelim = moduleStates.Max();
-            if (prelim == ParserState.Parsed && moduleStates.Any(s => s != ParserState.Parsed))
+            if (moduleStates.Any(module => module != ParserState.Ready))
             {
-                prelim = moduleStates.Where(s => s != ParserState.Parsed).Max();
+                // any module not ready means at least one of them has work in progress;
+                // report the least advanced of them, except if that's 'Pending':
+                return moduleStates.Except(new[]{ParserState.Pending}).Min();
             }
-            return prelim;
+
+            return default(ParserState); // default value is 'Pending'.
         }
 
         public ParserState GetModuleState(VBComponent component)