stabilized parser a bit; no more systematic AccessViolationException, but RubberduckParserState._projects is still not right.

Author: retailcoder

RetailCoder.VBE/App.cs

@@ -274,8 +274,8 @@ async void sink_ProjectRenamed(object sender, DispatcherRenamedEventArgs<VBProje
                 return;
             }
 
-            Debug.WriteLine(string.Format("Project '{0}' was renamed.", e.Item.Name));
-            _parser.State.ClearDeclarations(e.Item);
+            Debug.WriteLine("Project '{0}' was renamed to '{1}'.", e.OldName, e.Item.Name);
+            _parser.State.RemoveProject(e.OldName);
             _parser.State.OnParseRequested(sender);
         }
 

Rubberduck.Parsing/Symbols/Declaration.cs

@@ -101,9 +101,6 @@ public Declaration(
                 result = value;
             }
             _customFolder = result;
-            _isArray = IsArray();
-            _hasTypeHint = HasTypeHint();
-            _isTypeSpecified = IsTypeSpecified();
         }
 
         private readonly bool _isBuiltIn;

Rubberduck.Parsing/Symbols/ReferencedDeclarationsCollector.cs

@@ -42,8 +42,9 @@ private enum REGKIND
             REGKIND_NONE = 2
         }
 
+
         [DllImport("oleaut32.dll", CharSet = CharSet.Unicode)]
-        private static extern void LoadTypeLibEx(string strTypeLibName, REGKIND regKind, out ITypeLib TypeLib);
+        private static extern Int32 LoadTypeLibEx(string strTypeLibName, REGKIND regKind, out ITypeLib TypeLib);
 
         private static readonly IDictionary<VarEnum, string> TypeNames = new Dictionary<VarEnum, string>
         {

Rubberduck.Parsing/VBA/RubberduckParserState.cs

@@ -47,7 +47,7 @@ public sealed class RubberduckParserState
         public event EventHandler<ParseRequestEventArgs> ParseRequest;
 
         // circumvents VBIDE API's tendency to return a new instance at every parse, which breaks reference equality checks everywhere
-        private readonly IDictionary<string,VBProject> _projects = new Dictionary<string,VBProject>();
+        private readonly IDictionary<string,Func<VBProject>> _projects = new Dictionary<string,Func<VBProject>>();
 
         private readonly ConcurrentDictionary<QualifiedModuleName, ConcurrentDictionary<Declaration, byte>> _declarations =
             new ConcurrentDictionary<QualifiedModuleName, ConcurrentDictionary<Declaration, byte>>();
@@ -81,20 +81,35 @@ public void AddProject(VBProject project)
             var name = project.ProjectName();
             if (!_projects.ContainsKey(name))
             {
-                _projects.Add(name, project);
+                _projects.Add(name, () => project);
             }
         }
 
-        public void RemoveProject(VBProject project)
+        public void RemoveProject(string name)
         {
-            var name = project.ProjectName();
             if (_projects.ContainsKey(name))
             {
                 _projects.Remove(name);
             }
         }
 
-        public IReadOnlyList<VBProject> Projects { get { return _projects.Values.ToList(); } }
+        public void RemoveProject(VBProject project)
+        {
+            var name = project.ProjectName();
+            RemoveProject(name);
+
+            // note: attempt to fix ghost projects
+            name = project.Name;
+            RemoveProject(name);
+        }
+
+        public IEnumerable<VBProject> Projects
+        {
+            get
+            {
+                return _projects.Values.Select(project => project.Invoke());
+            }
+        }
 
         public IReadOnlyList<Tuple<VBComponent, SyntaxErrorException>> ModuleExceptions
         {

Rubberduck.SourceControl/GitProvider.cs

@@ -10,7 +10,7 @@
 
 namespace Rubberduck.SourceControl
 {
-    public class GitProvider : SourceControlProviderBase
+    public class GitProvider : SourceControlProviderBase // note: why not : IDisposable?
     {
         private readonly LibGit2Sharp.Repository _repo;
         private readonly LibGit2Sharp.Credentials _credentials;

Rubberduck.VBEEditor/NativeWindowMethods.cs renamed to Rubberduck.VBEEditor/NativeMethods.cs

@@ -8,8 +8,10 @@ namespace Rubberduck.VBEditor
     /// <summary>
     /// Collection of WinAPI methods and extensions to handle native windows.
     /// </summary>
-    // Special Thank You to Carlos Quintero for supplying the project with the original code this file is based on.
-    public static class NativeWindowMethods
+    /// <remarks>
+    /// **Special Thanks** to Carlos Quintero for supplying the project with the original code this file is based on.
+    /// </remarks>
+    public static class NativeMethods
     {
         /// <summary>   Sends a message to the OS. </summary>
         ///

Rubberduck.VBEEditor/QualifiedSelection.cs

@@ -30,6 +30,16 @@ public override int GetHashCode()
             } 
         }
 
+        public static bool operator ==(QualifiedSelection selection1, QualifiedSelection selection2)
+        {
+            return selection1.Equals(selection2);
+        }
+
+        public static bool operator !=(QualifiedSelection selection1, QualifiedSelection selection2)
+        {
+            return !(selection1 == selection2);
+        }
+
         public override bool Equals(object obj)
         {
             var other = (QualifiedSelection) obj;

Rubberduck.VBEEditor/Rubberduck.VBEditor.csproj

@@ -93,7 +93,7 @@
     <Compile Include="Extensions\CodeModuleExtensions.cs" />
     <Compile Include="CodeModuleSelection.cs" />
     <Compile Include="IActiveCodePaneEditor.cs" />
-    <Compile Include="NativeWindowMethods.cs" />
+    <Compile Include="NativeMethods.cs" />
     <Compile Include="QualifiedMemberName.cs" />
     <Compile Include="QualifiedModuleName.cs" />
     <Compile Include="QualifiedSelection.cs" />

Rubberduck.VBEEditor/Selection.cs

@@ -82,6 +82,16 @@ public override string ToString()
                 : string.Format("L{0}C{1} - L{2}C{3}", _startLine, _startColumn, _endLine, _endColumn);
         }
 
+        public static bool operator ==(Selection selection1, Selection selection2)
+        {
+            return selection1.Equals(selection2);
+        }
+
+        public static bool operator !=(Selection selection1, Selection selection2)
+        {
+            return !(selection1 == selection2);
+        }
+
         public override bool Equals(object obj)
         {
             return Equals((Selection) obj);

Rubberduck.VBEEditor/VBEHost/FallbackApp.cs

@@ -6,7 +6,7 @@
 
 namespace Rubberduck.VBEditor.VBEHost
 {
-    public class FallbackApp : IHostApplication
+    public sealed class FallbackApp : IHostApplication
     {
         private readonly VBE _vbe;
         private readonly CommandBarButton _runButton;